[netmod] Yangdoctors last call review of draft-ietf-netmod-factory-default-07

Carl Moberg via Datatracker <noreply@ietf.org> Wed, 27 November 2019 14:35 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carl Moberg via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: last-call@ietf.org, draft-ietf-netmod-factory-default.all@ietf.org, netmod@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Carl Moberg <calle@tail-f.com>
Message-ID: <157486532395.21897.4045220357632951501@ietfa.amsl.com>
Date: Wed, 27 Nov 2019 06:35:24 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/e_TRWoMtLHT-8rVBRcDL3Bnk80g>
Subject: [netmod] Yangdoctors last call review of draft-ietf-netmod-factory-default-07

Reviewer: Carl Moberg
Review result: Ready with Nits

This is my YANG doctors review of the ietf-factory-default.yang module as
part of draft-ietf-netmod-factory-default-07.

The module cleanly passes validation using the YANG validator site and
I have successfully loaded it into one NETCONF server implementation.

This module is ready with a cosmetic nit and a suggestion.

I suggest fixing the following textual nit:

OLD
       configuration datastores (i.e.,<running> , <startup><candidate>) to
       their factory default content.";

NEW:
       configuration datastores (i.e. <running>, <startup>, and
       <candidate>) to their factory default content.";

I suggest adding a revision-date to the filename in the <CODE BEGINS> block.

OLD:
 <CODE BEGINS> file "ietf-factory-default.yang"

 NEW:
 <CODE BEGINS> file "ietf-factory-default@2019-11-27.yang"

 (Obviously replacing the date with the release date of the module)

[netmod] Yangdoctors last call review of draft-ie… Carl Moberg via Datatracker
Re: [netmod] [Last-Call] Yangdoctors last call re… Benjamin Kaduk
Re: [netmod] Yangdoctors last call review of draf… Qin Wu