Re: [netmod] WG adoption poll draft-kwatsen-netmod-artwork-folding-08

Robert Wilton <rwilton@cisco.com> Fri, 19 October 2018 10:41 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF981130EBF; Fri, 19 Oct 2018 03:41:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.563
X-Spam-Level:
X-Spam-Status: No, score=-14.563 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.064, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UBZ_rDuuB8xq; Fri, 19 Oct 2018 03:41:08 -0700 (PDT)
Received: from aer-iport-2.cisco.com (aer-iport-2.cisco.com [173.38.203.52]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5FC99130EED; Fri, 19 Oct 2018 03:41:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=8956; q=dns/txt; s=iport; t=1539945667; x=1541155267; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to; bh=4wq5i7B+Kq7Wr9RBxocLXL1JsCa/38SpVR370m455EE=; b=MTiSVOsIVlvoc6stI/3d1+24biVGf98+3BIqYcvrtRkb+gz+tspnXr21 n8dU599jh1/WrEpVt73XLrzonoi1X8lcEfrIV+MqaKzmTwLSLKkVAXDYM qxJgRC2nGq8vtR0nbpvOSsSP5ibTGtN5JvKgKps39SZcY0uMowFt2Yp9g c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BXAACUs8lb/xbLJq1jGgEBAQEBAgE?= =?us-ascii?q?BAQEHAgEBAQGBZYEOSIEVbRIog3WId40kJZFHhVyBZg0YAQqBdYIORgKFJzg?= =?us-ascii?q?WAQMBAQIBAQJtHAyFOQEBAQEDAQEhSwsMBAsRBAEBAScDAgInHwkIBgEMBgI?= =?us-ascii?q?BAReDBgGCAQ+mVYEuH4UchGAFi2aBQT+BEScMgl+DGwEBgS4BCwcBgyKCVwK?= =?us-ascii?q?eQQmQZgYXgU+Ec4JuJoZTkBWGPYFaIWRxMxoIGxU7gmyLGYU/PjCJJw8Xgic?= =?us-ascii?q?BAQ?=
X-IronPort-AV: E=Sophos;i="5.54,399,1534809600"; d="scan'208,217";a="7361855"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Oct 2018 10:41:05 +0000
Received: from [10.63.23.63] (dhcp-ensft1-uk-vla370-10-63-23-63.cisco.com [10.63.23.63]) by aer-core-4.cisco.com (8.15.2/8.15.2) with ESMTP id w9JAf4Nl009102; Fri, 19 Oct 2018 10:41:04 GMT
To: adrian@olddog.co.uk, "'Lou Berger'" <lberger@labn.net>, "'NetMod WG'" <netmod@ietf.org>
Cc: "'NetMod WG Chairs'" <netmod-chairs@ietf.org>
References: <7fe4a6a2-ec5e-1336-d5c0-34fd698e26fb@labn.net> <09fa01d46794$3ed5b280$bc811780$@olddog.co.uk>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <1dbbb6ae-d660-6047-68ac-116dccbe21c4@cisco.com>
Date: Fri, 19 Oct 2018 11:41:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <09fa01d46794$3ed5b280$bc811780$@olddog.co.uk>
Content-Type: multipart/alternative; boundary="------------B32A31832BED323DDA14A535"
Content-Language: en-US
X-Outbound-SMTP-Client: 10.63.23.63, dhcp-ensft1-uk-vla370-10-63-23-63.cisco.com
X-Outbound-Node: aer-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/ej6zt53qiZfWAyidUTtU2opNFAk>
Subject: Re: [netmod] WG adoption poll draft-kwatsen-netmod-artwork-folding-08
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2018 10:41:13 -0000

Hi Adrian, all,

What is the intended scope?

1) Is it just for examples of YANG requests/replies, or in future, 
instance data.  If so, then I think that the solution is useful for this.

2) Or should the WG consider allowing a longer line length for YANG 
modules?  Currently they are limited to something like 69 characters so 
that they can be inserted into the RFC, but possibly with line folding 
we could possibly consider increasing that, but perhaps that would make 
them harder to read/review.

3) I think that there are also cases where tree diagrams wrap and need 
to be constrained to 69 characters.  Although I don't think that 
applying the folding algorithm to tree diagrams directly is necessarily 
a great idea, it might be that tools like pyang could be modified with 
an option to generate output that is consistent with the definition of 
the folded output so that it can be unfolded if required.

To give an example of 3:

Rather than this:

    module: ietf-if-l3-vlan
      augment /if:interfaces/if:interface/if-cmn:encapsulation/
                                                     if-cmn:encaps-type:
        +--:(dot1q-vlan)
           +--rw dot1q-vlan
              +--rw outer-tag!
              |  +--rw tag-type    dot1q-tag-type
              |  +--rw vlan-id     ieee:vlanid
              +--rw second-tag!
                 +--rw tag-type    dot1q-tag-type
                 +--rw vlan-id     ieee:vlanid

the tooling could be modified to optionally generate this instead:

========== NOTE: '\\' line wrapping per BCP XX (RFC XXXX) ===========
  
   module: ietf-if-l3-vlan
      augment /if:interfaces/if:interface/if-cmn:encapsulation/\
                                                    \if-cmn:encaps-type:
        +--:(dot1q-vlan)
           +--rw dot1q-vlan
              +--rw outer-tag!
              |  +--rw tag-type    dot1q-tag-type
              |  +--rw vlan-id     ieee:vlanid
              +--rw second-tag!
                 +--rw tag-type    dot1q-tag-type
                 +--rw vlan-id     ieee:vlanid

One other question:

How does the algorithm know it has reached the end of the artwork?  I.e. 
should there also be an end line marker?

Thanks,
Rob


On 19/10/2018 11:12, Adrian Farrel wrote:
> Hey Lou,
>
> As an author, I support adoption and would particularly welcome feedback from
> the WG to know whether this approach addresses the needs of those writing drafts
> for YANG models.
>
> Thanks,
> Adrian
>
>> -----Original Message-----
>> From: netmod [mailto:netmod-bounces@ietf.org] On Behalf Of Lou Berger
>> Sent: 18 October 2018 14:04
>> To: NetMod WG
>> Cc: NetMod WG Chairs
>> Subject: [netmod] WG adoption poll draft-kwatsen-netmod-artwork-folding-08
>>
>> All,
>>
>> This is start of a two week poll on making
>> draft-kwatsen-netmod-artwork-folding-08 a working group
>> document. Please send email to the list indicating "yes/support" or
>> "no/do not support".  If indicating no, please state your reservations
>> with the document.  If yes, please also feel free to provide comments
>> you'd like to see addressed once the document is a WG document.
>>
>> The poll ends Oct 1.
>>
>> Thanks,
>>
>> Lou (and co-chairs)
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod
> .
>