IETF Logo Mail Archive

[netmod] RtgDir review: draft-ietf-netmod-schema-mount-10.txt

"Bocci, Matthew (Nokia - GB)" <matthew.bocci@nokia.com> Fri, 29 June 2018 08:36 UTC

Return-Path: <matthew.bocci@nokia.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0568E12F295; Fri, 29 Jun 2018 01:36:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W7QYGdIEy3ie; Fri, 29 Jun 2018 01:36:08 -0700 (PDT)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40132.outbound.protection.outlook.com [40.107.4.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EE06B130DE5; Fri, 29 Jun 2018 01:36:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E22CGrSTds9z7vTppt2niO2X8oes51WZ86skoChNNRo=; b=Ue7D/DKm/r3nsWIbuWPvIE78BUhTksvcBUS9+4OoqhCDVlKEBIuNiQmCu81e7UhN1/Z/YnXGUr5Z4b089QFSDOrGhel8pRqr2lDCxRgtmPlhLqSY5T1ucYjgHaXlJUfaScMsRPPRXstg3kVkEzmKkbK2VAPPhEnNuPrTZk0VeOE=
Received: from AM6PR0702MB3622.eurprd07.prod.outlook.com (52.133.24.24) by AM6PR0702MB3671.eurprd07.prod.outlook.com (52.133.24.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.15; Fri, 29 Jun 2018 08:36:02 +0000
Received: from AM6PR0702MB3622.eurprd07.prod.outlook.com ([fe80::a9c4:6a95:761a:1868]) by AM6PR0702MB3622.eurprd07.prod.outlook.com ([fe80::a9c4:6a95:761a:1868%2]) with mapi id 15.20.0930.005; Fri, 29 Jun 2018 08:36:02 +0000
From: "Bocci, Matthew (Nokia - GB)" <matthew.bocci@nokia.com>
To: "rtg-ads@ietf.org" <rtg-ads@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-netmod-schema-mount.all@ietf.org" <draft-ietf-netmod-schema-mount.all@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-netmod-schema-mount-10.txt
Thread-Index: AQHUD4Q2ATC78UxYtkqtoak3I6AEQw==
Date: Fri, 29 Jun 2018 08:36:02 +0000
Message-ID: <8072D6C6-B951-4836-A423-9E71BED4F8DD@nokia.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.e.1.180613
authentication-results: spf=none (sender IP is ) smtp.mailfrom=matthew.bocci@nokia.com;
x-originating-ip: [81.108.178.133]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM6PR0702MB3671; 7:lDNqnsuvZ1NUx0OsErlR7yGWjsNa994Tqeu0sur8fg33/5F4QXmkeD1rMCPuLqDww1FjvTwQ8vSUiaLIAfY1InKuPpTNwGIzQUftzpQyQRBiR1Vr/n7EfFc2BE+vcs+PHQ7ZzkhQyazdgnZHzAbPn6tHAv0FKlXaIigRcIbJRMAlcnQSZTVqzVrymiUA8KYMHdesN3pTJCQZtc72OtDUUrZIS9bH8QYZPDOW5izUI4nbZ80XiVpJnwvKDEmvb+hk
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: a004735a-241b-468e-4c44-08d5dd9b5920
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7167020)(7193020); SRVR:AM6PR0702MB3671;
x-ms-traffictypediagnostic: AM6PR0702MB3671:
x-microsoft-antispam-prvs: <AM6PR0702MB367106A00592F48698C9090AEB4E0@AM6PR0702MB3671.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(21748063052155);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231254)(11241501184)(806099)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM6PR0702MB3671; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0702MB3671;
x-forefront-prvs: 0718908305
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(396003)(136003)(346002)(376002)(199004)(189003)(4326008)(2616005)(6506007)(55236004)(36756003)(186003)(8936002)(6436002)(33656002)(53936002)(102836004)(9326002)(2900100001)(486006)(2351001)(25786009)(2906002)(450100002)(99286004)(7736002)(66066001)(5660300001)(6486002)(5250100002)(97736004)(68736007)(2501003)(81156014)(81166006)(8676002)(6916009)(54896002)(105586002)(82746002)(106356001)(5640700003)(54906003)(478600001)(6116002)(6512007)(3846002)(476003)(316002)(58126008)(86362001)(83716003)(256004)(14454004)(26005)(14444005)(6306002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM6PR0702MB3671; H:AM6PR0702MB3622.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: nokia.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: FpKg/oRiFCXonXEJ6kXObxgAzdGqNC+xkSYsZMBi10+/YokE9t7wzfc972EoEPF/VQcNltx9ZdHKkXvf9fheh+/duViTBbA1AuJtKGLy+624f/vvUxO9VPRTNMQ2bJq9xF7U8ftF3H0CBcwpXuebiXQvuaD+tsfxXIpEN87ST2VSK5fwkYiU8Fh5eUKEACgnIbU2B6pH0F51R/ZXKuqKViLDxjkZQY/ZL3IPgBuWelWwhrzdBH8fSHA6d8oRje7BC9TTqrM0WW56qX+E++6YZOIIUEreQu5mSkdbh6E61zUfhi4DNrvarZFTrCFdWxkL/vrZNo6hAsXPWXq8dEWXuBycry/C6f9fnfgh3D0tlUGBe8LvSUEtX2dRT/vNqBnFBOpeP9Z2tmjZS44pl2USOQ==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_8072D6C6B9514836A4239E71BED4F8DDnokiacom_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a004735a-241b-468e-4c44-08d5dd9b5920
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2018 08:36:02.6950 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0702MB3671
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/ifa4TbvbBqKOwpucEX18eM7gRDA>
Subject: [netmod] RtgDir review: draft-ietf-netmod-schema-mount-10.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2018 08:36:12 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-netmod-schema-mount-10.txt
Reviewer: Matthew Bocci
Review Date: 11 June 2018
IETF LC End Date: unknown
Intended Status: Standards Track

Summary:

This document is basically ready for publication, but has nits that should be considered prior to publication.

Comments:

The draft is clearly written and easy to understand. I have no significant concerns although there are a few minor editorial nits that I think should be addressed.


Major Issues:

No major issues found.

Minor Issues:

No minor issues found.

Nits:

I found the references to the mechanism as simply "schema mount" made the document harder to parse than it should be. For example
"The basic idea of schema mount is to label...". It would be more readable to always refer to the mechanism as "a schema mount" or "the schema mount"
as appropriate.

There are a few other places where the indefinite article is missing e.g. the definitions in section 2.1 would be
more readable if they started with 'a', thus: "schema: a collection of schema trees..."

Section 2.1 Glossary of new terms
"- Schema: collection of schema trees with a common root"
I am not sure that you can really say that 'schema' is a new term. Maybe this could be rephrased to say "the term schema is used in this document to refer to..."

v2.23.0 | Report a Bug | By Email