Re: [netmod] AD review of draft-ietf-netmod-rfc7223bis-01

Benoit Claise <bclaise@cisco.com> Mon, 18 December 2017 15:21 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF152127369 for <netmod@ietfa.amsl.com>; Mon, 18 Dec 2017 07:21:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.611
X-Spam-Level:
X-Spam-Status: No, score=-12.611 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kxpp50R8K0W3 for <netmod@ietfa.amsl.com>; Mon, 18 Dec 2017 07:20:58 -0800 (PST)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A12C1241F3 for <netmod@ietf.org>; Mon, 18 Dec 2017 07:20:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2699; q=dns/txt; s=iport; t=1513610458; x=1514820058; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=jBN1moYkPf1Z44VESJl9aUX00ekl6CbXMONnTg0zhL0=; b=iz3FVLIbA2AR7RuhTnr+hn4Hdn1/0ZYhf9fTO/N9C8rXzt7Z8r8N4c+0 27qVNAHQjndevvvFkMOvcWNtA5bc//WKdzriudsOL08weSWR5suxoNXNZ 6fsvPoSuUQ4Bh9291tOZ/1698aUgDO8ni9ze0zYwCyU2DhGm7oxDbtNuw 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0C6AwDN2zda/xbLJq1cGQEBAQEBAQEBAQEBAQcBAQEBAYQkdCAHhAaLFY9vJpc1ggEKI4UYAoVJFQEBAQEBAQEBAWsohSQBBSMEEUEQCw4KAgImAgJXBg0GAgEBiiYJB6l+gW06imgBAQEBAQEBAQEBAQEBAQEBAQEBH4EPgl+DZIISDIJ3gyMLAQGBNSKDK4JjBZIbkSGHf4NxiTyCeYkch16NG39aiASBOzUjgU8yGggbFYJlCYROQDeKFgEBAQ
X-IronPort-AV: E=Sophos;i="5.45,422,1508803200"; d="scan'208";a="941222"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2017 15:20:56 +0000
Received: from [10.55.221.36] (ams-bclaise-nitro3.cisco.com [10.55.221.36]) by aer-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id vBIFKuwa019589; Mon, 18 Dec 2017 15:20:56 GMT
To: Martin Bjorklund <mbj@tail-f.com>
Cc: netmod@ietf.org
References: <4f4df77e-c88e-502d-56b0-5007e93a854f@cisco.com> <20171218.155539.2007718529213229529.mbj@tail-f.com>
From: Benoit Claise <bclaise@cisco.com>
Message-ID: <42a03f3a-9211-7cc1-e7f6-eaf57ce08645@cisco.com>
Date: Mon, 18 Dec 2017 16:20:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171218.155539.2007718529213229529.mbj@tail-f.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/ij7BQBDveefT4GIflkUlTiCAV00>
Subject: Re: [netmod] AD review of draft-ietf-netmod-rfc7223bis-01
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Dec 2017 15:21:03 -0000

Perfect.
Thank you.

Regards, B.
> Benoit Claise <bclaise@cisco.com> wrote:
>> Dear all,
>>
>> In order not to be the bottleneck in the process, here is my AD review
>> of draft-ietf-netmod-rfc7223bis-01
>> <https://datatracker.ietf.org/doc/draft-ietf-netmod-rfc7223bis/>
>>
>> Editorial:
>>
>> -
>>     An interface is identified by its name, which is unique within the
>>     server.  This property is captured in the "interface-ref"_and_
>>     typedef, which other YANG modules SHOULD use when they need to
>>     reference an interface.
>>
>> NEW:
>>     An interface is identified by its name, which is unique within the
>>     server.  This property is captured in the "interface-ref"
>>     typedef, which other YANG modules SHOULD use when they need to
>>     reference an interface.
> Ok, now fixed.
>
>
>> -
>>     Note that NETCONF and SNMP may
>>     differ in the time granularity in which they provide access to the
>>     counters.
>>
>> I guess we want to remove the reference to NETCONF?
>> Proposal:
>>     Note the server that implements the YANG module and the SNMP Agent may
>>     differ in the time granularity in which they provide access to the
>>     counters.
> Ok, fixed.
>
>>   -
>> We want to mention that "or:" comes from "ietf-origin@2017-08-17.yang"
>> in draft-ietf-netmod-revised-datastores
> I added:
>
>    This example uses the "origin" annotation, which is defined in the
>    module "ietf-origin" [I-D.ietf-netmod-revised-datastores].
>
>
> (I added this text to rfc7277bis as well).
>
>
>
> /martin
>
>
>> <rpc-reply
>>         xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"
>>         message-id="101">
>>       <data>
>>         <interfaces
>>             xmlns="urn:ietf:params:xml:ns:yang:ietf-interfaces"
>>             xmlns:ianaift="urn:ietf:params:xml:ns:yang:iana-if-type"
>>             xmlns:vlan="http://example.com/vlan"
>>             xmlns:or="urn:ietf:params:xml:ns:yang:ietf-origin">
>>
>>           <interface or:origin="or:intended">
>>             <name>eth0</name>
>>             <type>ianaift:ethernetCsmacd</type>
>>             <enabled>false</enabled>
>>             <admin-status>down</admin-status>
>>             <oper-status>down</oper-status>
>>             <if-index>2</if-index>
>>             <phys-address>00:01:02:03:04:05</phys-address>
>>             <statistics>
>>               <discontinuity-time>
>>                 2013-04-01T03:00:00+00:00
>>               </discontinuity-time>
>>               <!-- counters now shown here -->
>>             </statistics>
>>           </interface>
>>
>> Regards, Benoit (as OPS AD)
>>
> .
>