Re: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext version 4

"Rob Wilton (rwilton)" <rwilton@cisco.com> Thu, 03 October 2019 11:57 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2909B120814; Thu, 3 Oct 2019 04:57:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=dujPE/Cc; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=0q2g2o/q
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q0cXHgvcKKOY; Thu, 3 Oct 2019 04:57:09 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 157E212080C; Thu, 3 Oct 2019 04:57:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2890; q=dns/txt; s=iport; t=1570103829; x=1571313429; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BJM3Bee3VFVocJIcyRFDfiRoA1JYUCtau//R7F76XRU=; b=dujPE/CcmTTM/1IiInlv8FNTXbtfj6LlvLJiQiSR0peXYJg91GrRzurw bhF/2mVWJzg/M8G4NgeTixK0PvNWe1gHp1140D+lLVSNpWKcsNQQ3IQVL TacWS3ZRqK2ms5RNRRfSfz49MgMonLbOo8coiPfqpOHm2BMeD86xQ29V+ M=;
IronPort-PHdr: =?us-ascii?q?9a23=3AG3iShRFpU0zYrVjLEFPvbp1GYnJ96bzpIg4Y7I?= =?us-ascii?q?YmgLtSc6Oluo7vJ1Hb+e4z1A3SRYuO7fVChqKWqK3mVWEaqbe5+HEZON0pNV?= =?us-ascii?q?cejNkO2QkpAcqLE0r+eeT1bigmG8JqX15+9Hb9Ok9QS47z?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AUAACA4ZVd/5JdJa1mGgEBAQEBAgE?= =?us-ascii?q?BAQEMAgEBAQGBVQMBAQEBCwGBSlADbVYgBAsqCodfA4pDglyXeIEugSQDVAk?= =?us-ascii?q?BAQEMAQEjCgIBAYRAAoJFIzYHDgIDCQEBBAEBAQIBBQRthS0MhUsBAQEBAxI?= =?us-ascii?q?LHQYBASwLAQsEAgEIDgMEAQEBHhAyHQgCBA4FCBqDAYFqAx0BAgyjPwKBOIh?= =?us-ascii?q?hgieCfQEBBYE4AoNMGIIXAwaBNAGMDRiBQD+BEUaCTD6CYQEBAgEXgUmDPYI?= =?us-ascii?q?mjROIMIkIjgJuCoIjhwiOK4I5h06PN5ZJkRECBAIEBQIOAQEFgVkGLIFYcBU?= =?us-ascii?q?7gmxQEBSBT4NzhRSFP3SBKY5PAYEiAQE?=
X-IronPort-AV: E=Sophos;i="5.67,252,1566864000"; d="scan'208";a="640863963"
Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 03 Oct 2019 11:57:08 +0000
Received: from XCH-ALN-006.cisco.com (xch-aln-006.cisco.com [173.36.7.16]) by rcdn-core-10.cisco.com (8.15.2/8.15.2) with ESMTPS id x93Bv7Hd029751 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 3 Oct 2019 11:57:08 GMT
Received: from xhs-aln-001.cisco.com (173.37.135.118) by XCH-ALN-006.cisco.com (173.36.7.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 3 Oct 2019 06:57:07 -0500
Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 3 Oct 2019 06:57:06 -0500
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 3 Oct 2019 06:57:06 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nhl3XUFOeQFCGWVbUJiEZpYWsT71BQQN/+PdKBz6QyBIk8BtjgF7Mj+xI4xoFAbGsZT51eS8/d1t6sIb8oKX3l2Z4JBSjOPRfJqAqI8Wc9K7dGPUJmua5TBwley3E9fgYbEhDXDLqJWLpRpB8onzL04Gq35ynIKIDSKmjN/fGlN+vMkXaFxpzqPdlGaJ1+uomEDRtuxmnEL/VKizMVygCmVcWf6zEdcqhhJah8yhkZLxw98RZ5d4sXsqdAp5Q3Mkk84rg5Lu7npw+GAnCaouzPgX0qumgN0acRkSuyD1UgNSzt5UFHUD6Sdf730k84RjYg97/hDO6C+WyDXiwkD2Vw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LxITr0rLUDginWAisKr8er/bahB3cbGui7Im7uL2e54=; b=iEJwhuk/u6EtsO7N49iHd4jFTSoB9mtoEM9MNgczBgJmN4nqHysh5xRfMh4+rfcTjLSIGE+LU8RLmrtE6up/HdjXIFd6/YJ77I5YLF/+BkhRIZTSJG3Rv7fFcTO2OVsEopcoqPINRWtc/oBX+fzxmiZwzBb//NYaf4fRx++yGrlxXrpHnt5VZZRG5yuf1kF144LdwwQBm7DarChYBFEBoRHIsulxNoxy525BfoySPf9nB/KnZR4eHacWFWF+/ZBagTnhnsNKXrfaBIU0uwcSBEl+jL4TNy1J4O1X3VQf+qrjWIVpPJPv+Kk1wu1xAglbQt4HaYiOpc2QRITGWH4e0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LxITr0rLUDginWAisKr8er/bahB3cbGui7Im7uL2e54=; b=0q2g2o/q4E582Zj04kGfLfvua73yAal/m2vX4CLLBn7uUj02wEAClfJpdAEO1Syc1pcmZ5t1zvu9FVV4jGg8B9QWoaMFCuEfrQcB9xgZDhv9bf2qe2LO0ZlUB/SmEPu5lJUiBK2++2auGzoFydmViELf2AKrxLuLLSnuSIuQgrI=
Received: from MN2PR11MB4366.namprd11.prod.outlook.com (52.135.38.209) by MN2PR11MB4463.namprd11.prod.outlook.com (52.135.38.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 11:57:05 +0000
Received: from MN2PR11MB4366.namprd11.prod.outlook.com ([fe80::cca:41bd:b0bb:c549]) by MN2PR11MB4366.namprd11.prod.outlook.com ([fe80::cca:41bd:b0bb:c549%2]) with mapi id 15.20.2305.023; Thu, 3 Oct 2019 11:57:05 +0000
From: "Rob Wilton (rwilton)" <rwilton@cisco.com>
To: Martin Bjorklund <mbj@tail-f.com>
CC: "joelja@bogus.com" <joelja@bogus.com>, "draft-ietf-netmod-yang-data-ext@ietf.org" <draft-ietf-netmod-yang-data-ext@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext version 4
Thread-Index: AQHVdPUFaxWzJBQvFkCRO1cP0jGpVqdF5WVwgALohgCAAAtrsA==
Date: Thu, 3 Oct 2019 11:57:05 +0000
Message-ID: <MN2PR11MB4366C8FB7E9E370CFD96A1B1B59F0@MN2PR11MB4366.namprd11.prod.outlook.com>
References: <CBBD7EDD-0B53-4720-B76B-7932655FF27A@bogus.com> <MN2PR11MB436626F5D5BF2869BEF18C83B59D0@MN2PR11MB4366.namprd11.prod.outlook.com> <20191003.131552.11890873935623292.mbj@tail-f.com>
In-Reply-To: <20191003.131552.11890873935623292.mbj@tail-f.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rwilton@cisco.com;
x-originating-ip: [173.38.220.43]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0095e89a-584a-4fe7-7e9f-08d747f8cfa0
x-ms-traffictypediagnostic: MN2PR11MB4463:
x-ms-exchange-purlcount: 2
x-microsoft-antispam-prvs: <MN2PR11MB44630804099F7F46E43CE0D3B59F0@MN2PR11MB4463.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01792087B6
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(13464003)(189003)(199004)(305945005)(74316002)(7736002)(6916009)(66476007)(5660300002)(66556008)(76116006)(66946007)(64756008)(66446008)(26005)(186003)(476003)(99286004)(11346002)(486006)(446003)(53546011)(102836004)(6506007)(7696005)(76176011)(229853002)(54906003)(316002)(71190400001)(6306002)(71200400001)(9686003)(6436002)(55016002)(33656002)(14444005)(256004)(25786009)(478600001)(2906002)(86362001)(3846002)(6116002)(66066001)(81156014)(14454004)(8676002)(81166006)(966005)(6246003)(8936002)(52536014)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4463; H:MN2PR11MB4366.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: GlWAnnc68eA5RVp3kPfu3oeVSJfxHrFrQ4qpex0/AkrhDahnP/ipzXAhiMZfO1bTkW91+sGBVyMqPoP/qdZ41eNM9EPJPUczdBury4QcR4/01drbO/TGD0dBScuyf/6jdwK2nYOM55ZS9m9/PaLmqBlLkgmGUyJudf0SD4lplcRbkZ2L5TvnrNKPB/I5LEG/7+B2SGR/YA6bZIywo9x9BkrotL8VKomm08gHgjmIvflci5jlh/evluLgBT0FzhyQwh3m4XHK1PttfuL7AmMFr4CDz+5/TEc9IN5UnSrbfQI9C/tD6LYkqsm0Gs1jnNDfqCyFFfHl1DZMdnH+uYUWD3025yth/+5OOymcMiBvO0Zz598jj9orQGxdktwsYnsquOIhQXQBucDDNmbecLEss7eEy3+3YUlA/AJ6hNeDSmTrYvsl6CN+S5YitNOYssCSqQE7jmHvoIHF1JnIiL/fRQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0095e89a-584a-4fe7-7e9f-08d747f8cfa0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2019 11:57:05.4809 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dxNa0q1Z9XjWZwlL08zr3jjawNlIubTcPC4427zsKdtDKOmhRD4/aSdpYYJSlH94R09U3KJpt5HgQAA1wimajA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4463
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.16, xch-aln-006.cisco.com
X-Outbound-Node: rcdn-core-10.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/ip2bbzGKyXn5lRA9e0EcSZNLoR4>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext version 4
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Oct 2019 11:57:12 -0000

Looks good to me.

Thanks,
Rob


> -----Original Message-----
> From: Martin Bjorklund <mbj@tail-f.com>;
> Sent: 03 October 2019 12:16
> To: Rob Wilton (rwilton) <rwilton@cisco.com>;
> Cc: joelja@bogus.com; draft-ietf-netmod-yang-data-ext@ietf.org;
> netmod@ietf.org
> Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext
> version 4
> 
> Hi,
> 
> Thank you for the review.  Comments inline.
> 
> "Rob Wilton (rwilton)" <rwilton@cisco.com>; wrote:
> > Hi,
> >
> > I've reviewed this document, and other than 2 minor nits, I believe
> > that it is ready for publication.
> >
> > Two minor comments:
> >
> >
> >   1.  Section 1.1.1 NMDA.  There should be a comma before "and are
> >   not redefined here".
> 
> Fixed.
> 
> >   2.  I wonder whether it would be useful to have a sentence in the
> >   "Definitions" section that defines how a structure is encoded.
> >   Although I appreciate that this is specified in the YANG module
> >   itself.  An alternative could be a forward reference from the
> >   Definitions section to the YANG module.  This could also cover the
> >   Xpath behaviour as well.
> 
> This is probably a good idea.  Perhaps also add a small example:
> 
> 
>    A YANG data structure is encoded in the same way as an "anydata"
>    node.  This means that the name of the structure is encoded as a
>    "container", with the instantiated children encoded as child nodes to
>    this node.  For example, this structure:
> 
>      module example-errors {
>        ...
> 
>        sx:structure my-error {
>          leaf error-number {
>            type int;
>          }
>        }
>      }
> 
>    can be encoded in JSON as:
> 
>      "example-module:my-error": {
>        "error-number": 131
>      }
> 
> 
> 
> /martin
> 
> 
> 
> >
> > Thanks,
> > Rob
> >
> >
> > From: netmod <netmod-bounces@ietf.org>; On Behalf Of Joel Jaeggli
> > Sent: 27 September 2019 06:32
> > To: NETMOD Working Group <netmod@ietf.org>;
> > Subject: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext
> > version 4
> >
> > All,
> >
> > This starts a two week working group last call for
> > draft-ietf-netmod-yang-data-ext-04
> >
> > The working group last call ends on  Friday October 11th 2019.  Please
> send your comments to the working group mailing list.
> >
> > Positive comments, e.g., "I've reviewed this document and believe it is
> ready for publication", are welcome!  This is useful and important, even
> from authors.
> >
> >
> > https://tools.ietf.org/html/draft-ietf-netmod-yang-data-ext-04
> >
> >
> > The diff from 03, produced prior to IETF 105 is available here:
> >
> >
> > https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-netmo
> > d-yang-data-ext-04.txt
> >
> >
> > Thanks
> > Joel
> >
> >