Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7277bis-00

Hello,

I've reviewed this document and believe it is ready for publication.

The focus of my review this time was on validating the module and the example modules and example data through running code. I implemented NMDA for the open source tools we use and added a testcase that reproduces the result specified in "Appendix E. Example: NETCONF <get-data> Reply" after loading the configuration specified in "Appendix D.  Example: NETCONF <get-config> Reply" and providing the config false; data and system originated configuration as needed. I can confirm the implementation validated the example modules and the example data producing identical output.

IMO the examples are demonstrating well the concept of NMDA and its application for the ietf-interfaces module.

I had an issue with a bug in ietf-netconf-datastores@2017-08-24.yang I had to fix in order to use the <get-data> RPC. The bug is already reported on the mailing-list.

diff ietf-patched/ietf-netconf-datastores@2017-08-24.yang ietf-draft/ietf-netconf-datastores@2017-08-24.yang
140c140
<         when 'derived-from-or-self(../datastore, "ds:operational")';
---
>         when 'derived-from-or-self(../datastore, "or:operational")';

Vladimir

On 11/28/2017 08:29 PM, Kent Watsen wrote:
> All,
>
> This starts a two-week working group last call on
> draft-ietf-netmod-rfc7277bis-00.
>
> Please recall that this update's intention is to
> modify the YANG module to be in line with the NMDA
> guidelines [1].  Reviewing the diff between the two
> drafts [2] should reveal just this.
>
> The working group last call ends on December 12.
> Please send your comments to the netmod mailing list.
>
> Positive comments, e.g., "I've reviewed this document
> and believe it is ready for publication", are welcome!
> This is useful and important, even from authors.
>
> [1] https://tools.ietf.org/html/draft-dsdt-nmda-guidelines-01
> [2] https://tools.ietf.org/rfcdiff?url2=draft-ietf-netmod-rfc7277bis-00.txt
>
> Thank you,
> Netmod Chairs
>
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod