Re: [netmod] [Netconf] [netconf] Comments on draft-ietf-netconf-nmda-netconf-05

Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Wed, 25 April 2018 10:42 UTC

Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26E5C12DA6F; Wed, 25 Apr 2018 03:42:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GtSIRGwN810O; Wed, 25 Apr 2018 03:42:25 -0700 (PDT)
Received: from atlas5.jacobs-university.de (atlas5.jacobs-university.de [212.201.44.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6163712DA6E; Wed, 25 Apr 2018 03:42:25 -0700 (PDT)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by atlas5.jacobs-university.de (Postfix) with ESMTP id 85290CFF; Wed, 25 Apr 2018 12:42:23 +0200 (CEST)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from atlas5.jacobs-university.de ([10.70.0.217]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10032) with ESMTP id nkZA4Z_Nufd9; Wed, 25 Apr 2018 12:42:22 +0200 (CEST)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hermes.jacobs-university.de", Issuer "Jacobs University CA - G01" (verified OK)) by atlas5.jacobs-university.de (Postfix) with ESMTPS; Wed, 25 Apr 2018 12:42:23 +0200 (CEST)
Received: from localhost (demetrius4.jacobs-university.de [212.201.44.49]) by hermes.jacobs-university.de (Postfix) with ESMTP id 5CA9F20035; Wed, 25 Apr 2018 12:42:23 +0200 (CEST)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius4.jacobs-university.de [212.201.44.32]) (amavisd-new, port 10024) with ESMTP id YYfV_fcvbHbg; Wed, 25 Apr 2018 12:42:22 +0200 (CEST)
Received: from elstar.local (unknown [10.50.231.133]) by hermes.jacobs-university.de (Postfix) with ESMTP id D153320031; Wed, 25 Apr 2018 12:42:22 +0200 (CEST)
Received: by elstar.local (Postfix, from userid 501) id 736F242C1339; Wed, 25 Apr 2018 12:42:22 +0200 (CEST)
Date: Wed, 25 Apr 2018 12:42:22 +0200
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: Rohit R Ranade <rohitrranade@huawei.com>
Cc: "netconf@ietf.org" <netconf@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Message-ID: <20180425104222.2asz5wiuierdumr4@elstar.local>
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
Mail-Followup-To: Rohit R Ranade <rohitrranade@huawei.com>, "netconf@ietf.org" <netconf@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
References: <991B70D8B4112A4699D5C00DDBBF878A6B1E92F6@DGGEMA502-MBX.china.huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <991B70D8B4112A4699D5C00DDBBF878A6B1E92F6@DGGEMA502-MBX.china.huawei.com>
User-Agent: NeoMutt/20171215
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/kPmwFciicpaouwlfB95u_OniRYc>
Subject: Re: [netmod] [Netconf] [netconf] Comments on draft-ietf-netconf-nmda-netconf-05
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 10:42:28 -0000

On Wed, Apr 25, 2018 at 04:22:24AM +0000, Rohit R Ranade wrote:
> Hi All,
> 
> I plan to implement this draft and hence had some implementation related clarifications.
> 
> 
> 1.       I feel that there should be more text added about "origin" filtering mechanism. I am not clear about some aspects of origin filtering.
> 
> RFC 8342 : NMDA RFC provides the below example
> 
> <interfaces xmlns:or="urn:ietf:params:xml:ns:yang:ietf-origin"
>                  or:origin="or:intended">
>        <interface>
>          <name>lo0</name>
>          <description>loopback</description>
>          <ip-address or:origin="or:system">127.0.0.1</ip-address>
>          <ip-address>::1</ip-address>
>        </interface>
>      </interfaces>
> If user provides <origin-filter> as "system" ONLY, then he will NOT get this record in output. Because the keys have originated from "intended" . Right ?
> So, If user wants to get the system originated data, he MUST give all the origins in the <origin-filter> where the keys of the system data have originated from. Can you please confirm whether this is OK.

I would expect that <origin-filter>or:system</origin-filter> would
select the ip-address tagged with or:origin="or:system" and that the
system would return any necessary container or list elements and the
necessary key elements (since otherwise the value returned is just
useless). So the result would be:

      <interfaces xmlns:or="urn:ietf:params:xml:ns:yang:ietf-origin"
                  or:origin="or:intended">
        <interface>
          <name>lo0</name>
          <ip-address or:origin="or:system">127.0.0.1</ip-address>
        </interface>
      </interfaces>
 
> Another example given in RFC 8342 is as below:
>      <interfaces xmlns:or="urn:ietf:params:xml:ns:yang:ietf-origin"
>                  or:origin="or:intended">
>        <interface or:origin="or:system">
>          <name>lo0</name>
>          <ip-address>127.0.0.1</ip-address>
>          <ip-address>::1</ip-address>
>        </interface>
>      </interfaces>
> 
> ?  Here keys are originated from "system", but it is under container of "intended". So if user gives "system" for "origin-filter", the output will still NOT have this instance output ?

We allow origin values on containers or lists in order to inherit
them, i.e., to achieve a more compact encoding. Anyway, if a leaf node
matches, then I think any encompassing containers and list should be
included in the result so that the matching leaf can be reported. So
you would return

      <interfaces xmlns:or="urn:ietf:params:xml:ns:yang:ietf-origin"
                  or:origin="or:intended">
        <interface or:origin="or:system">
          <name>lo0</name>
          <ip-address>127.0.0.1</ip-address>
          <ip-address>::1</ip-address>
        </interface>
      </interfaces>

instead of not returning anything at all.

> ?  Also the container is not defined as "presence" in C.3.  Interface Example, but still it has origin whether that is Ok ?
 
Why not?

/js

-- 
Juergen Schoenwaelder           Jacobs University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>