Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04

Balázs Lengyel <balazs.lengyel@ericsson.com> Sun, 17 November 2019 12:44 UTC

Return-Path: <balazs.lengyel@ericsson.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B4B7A1200F9 for <netmod@ietfa.amsl.com>; Sun, 17 Nov 2019 04:44:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.99
X-Spam-Level:
X-Spam-Status: No, score=-1.99 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xUuDf60M8Jp0 for <netmod@ietfa.amsl.com>; Sun, 17 Nov 2019 04:44:45 -0800 (PST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0612.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe06::612]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D24B21200F5 for <netmod@ietf.org>; Sun, 17 Nov 2019 04:44:44 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J8rp6q2fPypHQsY9twSNIFXMu4Qx0jCTrtgw4tsCAG1rd1o8mgayuy7hdqoZGkFgfGEvgHwwuxZOeT+mwIb4e6+bhfvDg9wYinJ1gTv/hA+Eh4hT/a6WG8SUuWzXRkfzI50V6TGOu0ggAPl3PJ/s/ral6EIbEWtdxhIfbE0MT3R9Ehu5nONn9E5C0XelWLHYCujsHRFgvmLryqOP01/40Tb9LLaojAYuteTOTW/IuE6IMShIvzzaecZ0JOjzdA03IJvH3T5aittz6t+STdAS+dZriMzN9KW7+HnfCRr0QS0cQtToa23pN//DarT1m5x+rpyGDbvqc68zvHhzChYBAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xLS59S2N6jgOV3hnlBL6b1sfK4Kzi8kScisvnhhDWtE=; b=Fm82uulBl4YPXs+EpPj+KcvIX+uBZakRzqJ7wp5iCiwTqzxeFisfuowncLa/nc3lp3WdIB5x7I6blO6mqWoi0ny56rHdM9wZXPRU4p3UThcptq96ryUsqGmwtey0JYNbMO0S7yEejysqjtIS2RxOhJvP0ALwfV/I9mSBu5B5ZeIUgHB25QEdKqdBet64AkGwRbUwpb4ki0I8aYeh2jgm2b8EzILwR1X2fPKMCi1Ya76VFPHVCn3X0iwvTr3HhkGYe3YBHK3o2V85ErFpuKqO/GaDqaGMaqHtoKlVlQ3+11O1VCXnwcfhu7VSn7NdDvJBu+Wy74Dk3d6EwaYVSPk6ug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xLS59S2N6jgOV3hnlBL6b1sfK4Kzi8kScisvnhhDWtE=; b=YxJ0hoJ0IjnFLcNrS4QuLJR22zc9DCC/IHQKtMyFU6iKIqdvWgTognSUed/Tos+lm6oO2pZJy3inU0Ogm7Rya9dzMNBhFNlN0mjRVLk16NhkrqtRdMjc00ogntwoxjN2TodIuIq2X+9e9kbVoAFQOIz/QRjBgWjMF6skGSSy/kU=
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com (10.186.170.77) by AM7PR07MB6341.eurprd07.prod.outlook.com (10.186.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.10; Sun, 17 Nov 2019 12:44:42 +0000
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::749e:982d:1c62:367b]) by AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::749e:982d:1c62:367b%4]) with mapi id 15.20.2474.012; Sun, 17 Nov 2019 12:44:42 +0000
From: =?utf-8?B?QmFsw6F6cyBMZW5neWVs?= <balazs.lengyel@ericsson.com>
To: Andy Bierman <andy@yumaworks.com>
CC: Martin Bjorklund <mbj@tail-f.com>, NetMod WG <netmod@ietf.org>
Thread-Topic: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04
Thread-Index: AQHVf2MbQga78mSle0Opwa3noseNw6dUAaKAgAAieICAKsPXIIAAEVSAgBCKobA=
Date: Sun, 17 Nov 2019 12:44:41 +0000
Message-ID: <AM7PR07MB6214DC76B10D687FB5A8C92EF0720@AM7PR07MB6214.eurprd07.prod.outlook.com>
References: <20191010.140525.904627955349075516.mbj@tail-f.com> <CABCOCHShFd41gcGLTSjJQMWCA4Ak_QX2iHpng_6DBqLRf23vqw@mail.gmail.com> <CABCOCHQsuHR_Y_LR53_VVLSAeuMQWG8Ae_-C2v-GSj-9RELGTg@mail.gmail.com> <AM7PR07MB621401A82C579C14C2D42C82F0790@AM7PR07MB6214.eurprd07.prod.outlook.com> <CABCOCHSCsbmNmeQadriQy=WMrJ1E+O7zinr6fXN-o2D_W05bdQ@mail.gmail.com>
In-Reply-To: <CABCOCHSCsbmNmeQadriQy=WMrJ1E+O7zinr6fXN-o2D_W05bdQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.lengyel@ericsson.com;
x-originating-ip: [31.133.152.152]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 704a1469-3566-4949-4e9b-08d76b5beadc
x-ms-traffictypediagnostic: AM7PR07MB6341:
x-microsoft-antispam-prvs: <AM7PR07MB634132B0DD6A3F80C3407F41F0720@AM7PR07MB6341.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 02243C58C6
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(346002)(396003)(376002)(136003)(199004)(189003)(486006)(85202003)(99286004)(229853002)(66446008)(7736002)(6436002)(316002)(66574012)(81166006)(6306002)(4326008)(85182001)(9686003)(66476007)(74316002)(66616009)(76116006)(6916009)(66556008)(64756008)(52536014)(8936002)(66946007)(86362001)(55016002)(6246003)(476003)(11346002)(446003)(256004)(66066001)(6116002)(790700001)(33656002)(3846002)(8676002)(81156014)(5660300002)(54896002)(2906002)(186003)(54906003)(7696005)(76176011)(102836004)(53546011)(6506007)(71190400001)(71200400001)(478600001)(14454004)(25786009)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM7PR07MB6341; H:AM7PR07MB6214.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ITrpHC41RbHoB4XLAeGRBPyhPk+hnv/XlCFQj5+XT39zJYNqe1k9jO7XX1ewTcs1oLEFGj1uizpxYbf6RtmvIyJXBbNCuVkeqXwfzf0wmLXpqkRe74stxzSvElBmHnp2hqj6OI0tGNTm1oG+t/8R8hUWUzG4XiskILTb9eqfPgSP44ctfM2y7OvbpBzNFZNWQDAtY0/ydYvBGs7IfSzWN39jdZpRQ7NYVck30pQJR+PqGxxdn/aF1eJ+/2Bay9QJnNz/xm1gSQN3SQwS6tWPRSgSFNTC/EUPiWVrGrFS22PMIvMa53h+syJURAu8VTxGzsBmDH20XdH8lo5l4z8wrHpZd24gEGAdBlJlXvA3LzTUY5EhwonQm0y7PWWIurGAR+Q+/hnTj/I14k/79jsihXbcbje9ePuTnweXpBt7La966gU20dtM8eo6t/86thBZ
x-ms-exchange-transport-forked: True
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_0296_01D59D87.D5052E50"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 704a1469-3566-4949-4e9b-08d76b5beadc
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2019 12:44:42.0208 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DvLWPY+iXmZNZ7bPHVmC/Ku+vDSZf9D4XelWP/W2a5jBB6YGsNQ6xPnhNwkw9y9Y8VNs1yJoEgzCvnwRHerX51yBYbnnZ7SUN+a00WqL9S4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6341
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/kU8q_ooJtbuV2hrYmDoqqarIEp4>
Subject: Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Nov 2019 12:44:48 -0000

See below, BALAZS

 

From: Andy Bierman <andy@yumaworks.com> 
Sent: 2019. november 7., csütörtök 7:44
To: Balázs Lengyel <balazs.lengyel@ericsson.com>
Cc: Martin Bjorklund <mbj@tail-f.com>om>; NetMod WG <netmod@ietf.org>
Subject: Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04

 

 

IMO section 3 is too specific about the content within the content-data node.

The only requirement should be that it is valid XML or JSON according to

the schema listed.  All content should be identified, so if you include or:origin attributes

then ietf-origin MUST be in the schema list.  It is a bad idea to force tools to accept

invalid XML (e.g., no xmlns for a prefix that is used.

BALAZS: Don’t really agree. We intentionally allow the violation of the schema (as described)
-  partial data set are allowed

*	It is allowed to only have config=false data

People requested to explicitly mention UTF-8

IMHO it is good to mention metadata/XML attributes as they are useful and are not regulated by the schema

 

The text about the required file-name structure if timestamps are present

seems rather arbitrary.  What if the tool generating the file is not aware of

specific YANG objects, so it does not know there are data nodes representing timestamps?

Why is this needed? The file contains revision and timestamp meta-data.

 

 

   If the leaf name is present in the instance data header this MUST
      be used.  Revision-date MUST be set to the latest revision date
      inside the instance data set.

 

I do not understand the text above.

IMO none of sec. 3 MUST requirements are needed.

Looks like a lot of CLRs to me.

BALAZS: To make it easier I will make the inclusion of date/timestamp optional.

 

These are nearly the exact same rules we have for naming YANG files.

Name+date

Even for a YANG module we require that an internal data element, the module’s argument must match the file name’s beginning.

Even for a YANG module we recommend that an internal data element, the revision’s argument must match the file name’s middle part.

Many people like it that the file’s name immediately tells you what it is and what version.

 

 

Hard to see what harm to the Internet is caused

by a YID file that is named "incorrectly".  Tools will create their own file extensions, because

lumping everything in with .xml or .json is shortsighted. Why does the standard say SHALL

use .xml or .json?  Is this a general requirement for all XML or JSON content?

If not, then why is being added here?

BALAZS: It was an earlier decision of the netmod group to use just json/xml. I would like a more descriptive extension but was outvoted.

 

How does the tool that reads the YID file know what version of the YID template is being used?

(Or do you think this module is perfect, and will never be updated?)

Seems like the very first leaf should be a "yid-version", similar to "yang-version" in YANG.

BALAZS:  OK, I will add the yid-version. (Otherwise the module is perfect :-)  )

 

 

Andy