Re: [netmod] References to the "tags" typedef

Christian Hopps <chopps@chopps.org> Thu, 03 October 2019 19:49 UTC

Return-Path: <chopps@chopps.org>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE2A11200B7 for <netmod@ietfa.amsl.com>; Thu, 3 Oct 2019 12:49:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y3AMPa16fAPs for <netmod@ietfa.amsl.com>; Thu, 3 Oct 2019 12:49:45 -0700 (PDT)
Received: from smtp.chopps.org (smtp.chopps.org [54.88.81.56]) by ietfa.amsl.com (Postfix) with ESMTP id 87639120098 for <netmod@ietf.org>; Thu, 3 Oct 2019 12:49:45 -0700 (PDT)
Received: from stubbs.int.chopps.org (unknown [172.222.100.236]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by smtp.chopps.org (Postfix) with ESMTPSA id C8DB160530; Thu, 3 Oct 2019 15:49:44 -0400 (EDT)
From: Christian Hopps <chopps@chopps.org>
Message-Id: <1B318BB7-9214-45DC-94AC-E164198CF97D@chopps.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_75FC9128-9F04-4378-AD20-09BFBBAB3CC8"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Thu, 3 Oct 2019 15:49:43 -0400
In-Reply-To: <824BC817-DAFD-41CE-88B7-D24A32F22E19@gmail.com>
Cc: Christian Hopps <chopps@chopps.org>, Robert Wilton <rwilton@cisco.com>, "netmod@ietf.org" <netmod@ietf.org>
To: Mahesh Jethanandani <mjethanandani@gmail.com>
References: <MN2PR11MB4366172C3044D238A5BE7C30B59F0@MN2PR11MB4366.namprd11.prod.outlook.com> <824BC817-DAFD-41CE-88B7-D24A32F22E19@gmail.com>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/klxVd2pI9QZj1cAYKTXhQBWmlBY>
Subject: Re: [netmod] References to the "tags" typedef
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Oct 2019 19:49:49 -0000


> On Oct 3, 2019, at 2:34 PM, Mahesh Jethanandani <mjethanandani@gmail.com>; wrote:
> 
> 
> 
>> On Oct 3, 2019, at 2:37 AM, Rob Wilton (rwilton) <rwilton@cisco.com>; wrote:
>> 
>> Hi Chris,
>> 
>> I know that this is late, but ...
>> 
>> The YANG packages draft (https://tools.ietf.org/html/draft-rwilton-netmod-yang-packages-01, but an updated version will be posted soon), is currently using the module-tags typedef to allow a package definition to contain a list of tags.
>> 
>> E.g.
>> module: ietf-yang-package
>>      +--ro yang-package
>>         +--ro name                      yang:yang-identifier
>>         +--ro version                   yang-sem-ver
>>         +--ro revision-date?            yanglib:revision-identifier
>>         +--ro location*                 inet:uri
>>         +--ro description?              string
>>         +--ro reference?                string
>>         +--ro previous-version?         yang-sem-ver
>>         +--ro tag*                      tags:tag
>>         +--ro referentially-complete?   Boolean
>>         ...
>> 
>> This package definition goes into an instance data document, for which the schema should just be ietf-yang-package, but by it importing ietf-module-tags.yang, it effectively also pulls in the "container module-tags" into the schema for the package definition, that I don't think should be there.
>> 
>> If we keep package tags, then I think that there are two ways to fix this:
>> 
>> (1) Split ietf-module-tags into an ietf-module-tags-types.yang and a ietf-module-tags.yang.  But it would be very late to do this, and the packages draft isn't even a workgroup document at this stage.
> 
> I know it is late. But what will it take to split the tags-types module from the tags module?

I do not understand why this is important at all. What does "pulls in" exactly mean?

Thanks,
Chris.

> 
>> 
>> (2) Have the package draft define its own "package tag" typedef, and not have an import reference on module-tags at all.  Probably if we do keep package tags, then we should also consider a mechanism by which they can be updated on a device equivalently to module tags.
>> 
>> I'm currently thinking that the second choice might be a better approach at this time, but wanted to check whether you or the WG had an opinion.
>> 
>> Thanks,
>> Rob
>> 
>> 
>> 
>>> -----Original Message-----
>>> From: netmod <netmod-bounces@ietf.org>; On Behalf Of Christian Hopps
>>> Sent: 25 September 2019 17:19
>>> To: netmod@ietf.org
>>> Subject: Re: [netmod] I-D Action: draft-ietf-netmod-module-tags-09.txt
>>> 
>>> This adds the deprecated non-NMDA state module.
>>> 
>>> Thanks,
>>> Chris.
>>> 
>>>> On Sep 25, 2019, at 12:15 PM, internet-drafts@ietf.org wrote:
>>>> 
>>>> 
>>>> A New Internet-Draft is available from the on-line Internet-Drafts
>>> directories.
>>>> This draft is a work item of the Network Modeling WG of the IETF.
>>>> 
>>>>      Title           : YANG Module Tags
>>>>      Authors         : Christian Hopps
>>>>                        Lou Berger
>>>>                        Dean Bogdanovic
>>>> 	Filename        : draft-ietf-netmod-module-tags-09.txt
>>>> 	Pages           : 18
>>>> 	Date            : 2019-09-25
>>>> 
>>>> Abstract:
>>>> This document provides for the association of tags with YANG modules.
>>>> The expectation is for such tags to be used to help classify and
>>>> organize modules.  A method for defining, reading and writing a
>>>> modules tags is provided.  Tags may be registered and assigned during
>>>> module definition; assigned by implementations; or dynamically
>>>> defined and set by users.  This document also provides guidance to
>>>> future model writers; as such, this document updates RFC8407.
>>>> 
>>>> 
>>>> The IETF datatracker status page for this draft is:
>>>> https://datatracker.ietf.org/doc/draft-ietf-netmod-module-tags/
>>>> 
>>>> There are also htmlized versions available at:
>>>> https://tools.ietf.org/html/draft-ietf-netmod-module-tags-09
>>>> https://datatracker.ietf.org/doc/html/draft-ietf-netmod-module-tags-09
>>>> 
>>>> A diff from the previous version is available at:
>>>> https://www.ietf.org/rfcdiff?url2=draft-ietf-netmod-module-tags-09
>>>> 
>>>> 
>>>> Please note that it may take a couple of minutes from the time of
>>>> submission until the htmlized version and diff are available at
>>> tools.ietf.org.
>>>> 
>>>> Internet-Drafts are also available by anonymous FTP at:
>>>> ftp://ftp.ietf.org/internet-drafts/
>>>> 
>>>> _______________________________________________
>>>> netmod mailing list
>>>> netmod@ietf.org
>>>> https://www.ietf.org/mailman/listinfo/netmod
>>>> 
>> 
>> _______________________________________________
>> netmod mailing list
>> netmod@ietf.org
>> https://www.ietf.org/mailman/listinfo/netmod
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com