Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07

Vladimir Vassilev <vladimir@transpacket.com> Sat, 10 August 2019 14:23 UTC

Return-Path: <vladimir@transpacket.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1E254120089 for <netmod@ietfa.amsl.com>; Sat, 10 Aug 2019 07:23:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IDrMJ3Uj329S for <netmod@ietfa.amsl.com>; Sat, 10 Aug 2019 07:23:56 -0700 (PDT)
Received: from mail.transpacket.com (s91205186171.blix.com [91.205.186.171]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6103212001A for <netmod@ietf.org>; Sat, 10 Aug 2019 07:23:56 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.transpacket.com (Postfix) with ESMTP id 3DE3448035C4; Sat, 10 Aug 2019 16:23:54 +0200 (CEST)
Received: from mail.transpacket.com ([127.0.0.1]) by localhost (mail.transpacket.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7kbZVjgS8ysW; Sat, 10 Aug 2019 16:23:54 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1]) by mail.transpacket.com (Postfix) with ESMTP id 10F5248035C3; Sat, 10 Aug 2019 16:23:54 +0200 (CEST)
Received: from mail.transpacket.com ([127.0.0.1]) by localhost (mail.transpacket.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fPPMNJT55HST; Sat, 10 Aug 2019 16:23:53 +0200 (CEST)
Received: from [192.168.0.21] (cm-84.209.19.126.getinternet.no [84.209.19.126]) by mail.transpacket.com (Postfix) with ESMTPSA id A03194802AB0; Sat, 10 Aug 2019 16:23:53 +0200 (CEST)
To: "Rob Wilton (rwilton)" <rwilton@cisco.com>, "Acee Lindem (acee)" <acee@cisco.com>, Kent Watsen <kent+ietf@watsen.net>, "netmod@ietf.org" <netmod@ietf.org>, Lou Berger <lberger@labn.net>
References: <0100016bd93bfe12-b7c7407d-7c5f-4d61-a714-3aa38b0d1da7-000000@email.amazonses.com> <80F2E6D2-8F6A-4EF4-9838-45AC48BE84E5@cisco.com> <BYAPR11MB2631CAAA7837907190FF7786B5C90@BYAPR11MB2631.namprd11.prod.outlook.com> <897E77D0-5EB6-4C05-BED2-F1DB3D26948B@cisco.com> <BYAPR11MB2631371D0987EA2B11A18807B5D40@BYAPR11MB2631.namprd11.prod.outlook.com>
From: Vladimir Vassilev <vladimir@transpacket.com>
Message-ID: <f6d60abc-dc0f-8243-f006-a97fa958a495@transpacket.com>
Date: Sat, 10 Aug 2019 16:23:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <BYAPR11MB2631371D0987EA2B11A18807B5D40@BYAPR11MB2631.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/lIaXukITzUDU1d6c9tlDxM30vSw>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Aug 2019 14:23:59 -0000

On 07/08/2019 16.14, Rob Wilton (rwilton) wrote:
> Hi Acee,
>
> Thanks.  This was also discussed in the NETMOD WG meeting (I know that you had a conflict).
>
> My reading of the consensus in the room was that the histogram statistics should be deferred at this time.  In particular, it seems like it would take some time/effort to agree on exactly how these counters should be modelled.  I also said that I would contact the IEEE 802.3 WG chair to see if we could progress a histogram model within the IETF.  I have sent an email out, but not heard anything back yet.
>
> There was consensus in the room to add a sub-interface demux drop counter into the current module.
>
> Lou also proposed that I rename "l2-mtu" to something like "max-frame-size" for consistency (I need to check the recording).
I think avoiding the MTU confusion was the correct decision. The MTU 
definition from RFC791 is consistently used in all RFCs known to me.

In addition to renaming the leaf there is contradiction between the 
description and range statements in draft-ietf-netmod-intf-ext-yang-07:

<CODE BEGINS>

...

      leaf l2-mtu {
        if-feature "configurable-l2-mtu";
        type uint16 {
          range "64 .. 65535";
        }
        description
          "The maximum size of layer 2 frames that may be transmitted
           or received on the interface (excluding any FCS overhead).
           In the case of Ethernet interfaces it also excludes the
           4-8 byte overhead of any known (i.e. explicitly matched by
           a child sub-interface) 802.1Q VLAN tags.";
        reference "RFC XXX, Section 3.5 Layer 2 MTU";
      }

...

<CODE ENDS>

Obviously minimum Ethernet frame is 64 bytes when FCS bytes are 
included. I also do not think there is consensus that 4-8 bytes should 
be subtracted if there are sub-interfaces with VLAN encapsulation 
configured since this complicates the logic.

IMO There have been too few reviews of this work. I will go through the 
draft and the relevant mailing list threads during the weekend and post 
my review.

/Vladimir
>
> It also looks like I should generate and add -state trees to the appendix.
>
> Thanks,
> Rob
>
>
> -----Original Message-----
> From: Acee Lindem (acee)
> Sent: 05 August 2019 18:52
> To: Rob Wilton (rwilton) <rwilton@cisco.com>;; Kent Watsen <kent+ietf@watsen.net>;; netmod@ietf.org
> Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
>
> Hi Rob,
> It seems these counters have been considered at great length. I agree we should move forward with the model as it is today.
> Thanks,
> Acee
>
> On 7/17/19, 11:36 AM, "Rob Wilton (rwilton)" <rwilton@cisco.com>; wrote:
>
>      Hi Acee,
>      
>      Thanks for the review, and apologies for the delayed reply.
>      
>      Regarding your stats question, there was some effort to handle this as part of defining the Ethernet interface YANG (IEEE 802.3.2-2019) (https://github.com/YangModels/yang/tree/master/standard/ieee/published/802.3) that I was involved in the earlier parts of.  Please see the attached XLS that was my earlier effort to rationalize the different ethernet interfaces counters between RFC 7223, Ethernet YANG, Etherlike MIB, RMON MIBs, and the counters exposed in the 802.3 clause 30 management API.
>      
>      For physical Ethernet interfaces (and anything that looks very similar to a physical Ethernet interface) then I think that we should be well covered by the combination of what is in ietf-interfaces, and IEEE 802.3.2.
>      
>      There are also some counters that apply to all Ethernet-like interfaces (really anything using Ethernet framing, but not an Ethernet physical layer).  The only counter currently defined in this category is in-drop-unknown-dest-mac-pkts in ietf-interfaces-ethernet-like.  Arguably we could also add a drop counter for frames that could not be demuxed to a sub-interface because it didn't match any of the sub-interface match expressions.
>      
>      There was one set of counters that 802.3.2 didn't want to include in their YANG module which related to the histogram frame statistics.  E.g. counters like the following (taken from IOS XR):
>      
>          Input pkts 65-127 bytes     = 0
>          Input pkts 128-255 bytes    = 0
>          Input pkts 256-511 bytes    = 0
>          Input pkts 512-1023 bytes   = 0
>          Input pkts 1024-1518 bytes  = 0
>          Input pkts 1519-Max bytes   = 0
>      
>          Output pkts 65-127 bytes    = 0
>          Output pkts 128-255 bytes   = 0
>          Output pkts 256-511 bytes   = 0
>          Output pkts 512-1023 bytes  = 0
>          Output pkts 1024-1518 bytes = 0
>          Output pkts 1519-Max bytes  = 0
>      
>      The 802.3 YANG WG had two issues with including counters like these:
>      (1) They didn't really want to define histogram counter values for MTUs that are above the officially sanctioned MTU of 1514/1518 in the Ethernet specification, even though a lot of hardware supports up to 9K+.
>      (2) The bucket ranges, at least once you get past the "512-1023" bucket, seem to somewhat vary by ASIC vendor.
>      (3) IEEE 802.3 has a well defined internal management API (802.3 clause 30), and these histogram counters are not currently defined as part of that internal management API.  Extending the internal 802.3 management API seems tricky due to point (1) and (2) above.
>      
>      There was a suggestion in the 802.3 discussions that these counters could be defined in an IETF YANG module (skirting the IEEE concerns about maximum MTUs).  The proposal was to allow the operational data to return a list of bucket entries, where each entry defines the inclusive range of the bucket, and a count of the pkts that matched the bucket range (in either the ingress or egress direction).  This list would sit alongside a RECOMMENDATION of what bucket sizes to use, basically doubling each time up to the MTU, with some consideration around the 1514/1518/1522 boundary, but allowing freedom for a device to accurately return the histogram ranges actually supported by the hardware.
>      
>      However, I'm not sure it is worth delaying these drafts to add these counters in now, particularly because there are dependencies on them.  Possibly best done as future work?  Do you, or anyone else in the WG have an opinion on this?
>      
>      Thanks,
>      Rob
>      
>      
>      
>      -----Original Message-----
>      From: netmod <netmod-bounces@ietf.org>; On Behalf Of Acee Lindem (acee)
>      Sent: 10 July 2019 14:09
>      To: Kent Watsen <kent+ietf@watsen.net>;; netmod@ietf.org
>      Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-intf-ext-yang-07
>      
>      I have reviewed the subject document and support publication. I have the following comment:
>      
>        Perhaps ietf-interface-ethernet-like module ethlike:ethernet-like/ethlike:statistics could include a subset of the counters from RFC 3635. I say a subset since some of these counters are a bit archaic given the state of the technology and judgement should be applied on which to include.
>      
>        Thanks,
>      Acee
>      
>      On 7/9/19, 8:16 PM, "netmod on behalf of Kent Watsen" <netmod-bounces@ietf.org on behalf of kent+ietf@watsen.net>; wrote:
>      
>          All,
>          
>          This starts a twelve-day working group last call for draft-ietf-netmod-intf-ext-yang-07
>          
>          The working group last call ends on July 21 (the day before the NETMOD 105 sessions).  Please send your comments to the working group mailing list.
>          
>          Positive comments, e.g., "I've reviewed this document and believe it is ready for publication", are welcome!  This is useful and important, even from authors.
>          
>          Thank you,
>          NETMOD Chairs
>          _______________________________________________
>          netmod mailing list
>          netmod@ietf.org
>          https://www.ietf.org/mailman/listinfo/netmod
>          
>      
>      _______________________________________________
>      netmod mailing list
>      netmod@ietf.org
>      https://www.ietf.org/mailman/listinfo/netmod
>      
>
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod