Re: [netmod] Comments on NMDA-04

Robert Wilton <rwilton@cisco.com> Thu, 14 September 2017 17:02 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 462921326F6 for <netmod@ietfa.amsl.com>; Thu, 14 Sep 2017 10:02:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CgYyDmaDr1pK for <netmod@ietfa.amsl.com>; Thu, 14 Sep 2017 10:01:58 -0700 (PDT)
Received: from aer-iport-1.cisco.com (aer-iport-1.cisco.com [173.38.203.51]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39B001321AC for <netmod@ietf.org>; Thu, 14 Sep 2017 10:01:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=7392; q=dns/txt; s=iport; t=1505408518; x=1506618118; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to; bh=h9zs8bX73N6EgIvMqODoFCop0MdktlQPdP4tDkK0b1A=; b=LvupxnW08F3k3NCHnTlSR5yVIwbDBdJP67bRWkQVd/Rd39Vv68unRI5l TrqUouD2U3kH1MOAXzIKPMhiwbB8eBfHMz5o3mCXzj6PYObyoB8xnAiPI Ny3lv/gmJR35AUZ0X9Y1IsZlVJkTtrSDvBe0dXvT2VdPbTsVeiR4k+Kkl c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0COAQDJtLpZ/xbLJq1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBgm+CPYQeixSQRiuQaIVOggQKhTwChGYVAQIBAQEBAQEBayiFGAE?= =?us-ascii?q?BAQECASNWEAsYFRUCAlcGAQwIAQGKJgisKYInJ4sKAQEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBHYMrg1KBYyuCfYQzgQSCVIJgBZg9iEWUUotVhyGNXIdVgTk1IoENMiE?= =?us-ascii?q?IHBWHZz+GZCuCFAEBAQ?=
X-IronPort-AV: E=Sophos;i="5.42,394,1500940800"; d="scan'208,217";a="697190565"
Received: from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com) ([173.38.203.22]) by aer-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2017 17:01:53 +0000
Received: from [10.63.23.66] (dhcp-ensft1-uk-vla370-10-63-23-66.cisco.com [10.63.23.66]) by aer-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id v8EH1reD011340; Thu, 14 Sep 2017 17:01:53 GMT
To: Balazs Lengyel <balazs.lengyel@ericsson.com>, Martin Bjorklund <mbj@tail-f.com>
Cc: netmod@ietf.org
References: <9ec6b2e4-36a7-87e6-59fa-828855235835@ericsson.com> <20170914.163239.143365521945928900.mbj@tail-f.com> <0605fab0-f879-e02d-4858-52a247571cb8@ericsson.com>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <9892a9b1-139c-71d3-328e-ad91e0590f6b@cisco.com>
Date: Thu, 14 Sep 2017 18:01:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <0605fab0-f879-e02d-4858-52a247571cb8@ericsson.com>
Content-Type: multipart/alternative; boundary="------------B837B40E197B6DC0871E35E7"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/lPl0QqADgvr5a5ZE3thz7cZko2I>
Subject: Re: [netmod] Comments on NMDA-04
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Sep 2017 17:02:01 -0000

Hi Balazs,

Thanks for the review and comments.


On 14/09/2017 16:44, Balazs Lengyel wrote:
> See below !
>
>
> On 2017-09-14 16:32, Martin Bjorklund wrote:
>
>>> CH 4.4.)  "Validation is performed on the contents of <intended>."
>>> This to me means that default data is not considered at validation
>> Note that RFC 7950, section 6.4.1, says:
>>
>>     In the accessible tree, all leafs and leaf-lists with default values
>>     in use exist (see Sections 7.6.1 and 7.7.2).
>>
>> So defaults are taken into account when intended is validated.
> BALAZS: Yes the two seem to contradict each other. This can be 
> understood in your way, however the current text is not clear enough. 
> I would add:
> Validation is performed on the contents of <intended> (EXTENDED WITH 
> DEFAULT CONFIGURATION).
As an alternative suggestion, rather than saying contents of <intended>, 
we could instead say something like "<intended>must always be a valid 
configuration data tree.". Is that better?  I would rather not talk 
about "defaults for <intended> since that may imply that they are not 
applicable to other configuration datastores".  E.g. if <running> is 
validated then you would also expect defaults to be considered. Ditto 
for startup, candidate.

Thanks,
Rob


>>> which would be a backwards incompatible change. Also if validation
>>> does not consider system configured data that would allow cases like
>>> multiple interfaces named lo0. One from <intended> one from system
>>> configuration. IMHO while it is OK to violate uniqueness because of
>>> remnant data, the above violation of uniqueness seems a bad idea.
>> If your system adds data to <running>, or to <intended>, it will be
>> validated.
>>
>>> Ch. 4.7) Is it allowed to violate uniqueness of key values? IMHO it
>>> should not be.
>> Agreed.  Note that the draft explicitly lists the constraints that can
>> be violated, and uniqueness of keys is not listed.
> BALAZS: If that is the intent I would propose to explicitly state it. 
> For me it was non-trivial.
> Can a a choice statement be violated? Having to existing branches at 
> the same time? It seems a semantic constraint to me. IMHO yes.
> Can an if-feature be violated? If  support has just changed and we 
> have some remnant config, I can very well imagine it violated.
>
> Also here could you change
> If a node in  <operational> does not meet the syntactic constraints 
> then it cannot   be returned
> to
> If a node in  <operational> does not meet the syntactic constraints 
> then it MUST NOT be returned
>> /martin
>