Re: [netmod] WG Last Call: draft-ietf-netmod-rfc6087bis-14

"Eric Voit (evoit)" <evoit@cisco.com> Tue, 17 October 2017 23:06 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DE437132396; Tue, 17 Oct 2017 16:06:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.521
X-Spam-Level:
X-Spam-Status: No, score=-14.521 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EU05T9rrDiet; Tue, 17 Oct 2017 16:06:46 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ADEE112426E; Tue, 17 Oct 2017 16:06:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=834; q=dns/txt; s=iport; t=1508281606; x=1509491206; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2HcAHl/U+mzX0a9AP/aeNRcgRWe+xbOOt2vi6acz/I0=; b=gbJC6eQO3DmKbRSLJl5jVmE7xSleN5STa169IwFW1AZuzzd+4GB0D1G0 hIqZDuNLEDNXlFf2/WXRWwnwHFPyx1nPt6/zCN8QxoZ4ae6X+Eg3yFZAc gQm78CGCngkFUWeIXDHYZq7qL+gDG41s4bW6O+84E27QiSLxbn0GzYuMC 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CxAACZjOZZ/4QNJK1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1+BUi6OEo83mCuCFAqFOwKEbD8YAQIBAQEBAQEBax0LhR4GOj8?= =?us-ascii?q?QAgEINhAyJQIEDg2KFaxxizoBAQEBAQEBAQEBAQEBAQEBAQEBAQEdgy6CB4FRh?= =?us-ascii?q?RWKeQWhSwKUYJMhlUMCERkBgTgBHziBWXoVgy6EXokgLIEFgREBAQE?=
X-IronPort-AV: E=Sophos;i="5.43,392,1503360000"; d="scan'208";a="309052249"
Received: from alln-core-10.cisco.com ([173.36.13.132]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Oct 2017 23:06:45 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by alln-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id v9HN6jGG017380 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 17 Oct 2017 23:06:45 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 17 Oct 2017 19:06:44 -0400
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1320.000; Tue, 17 Oct 2017 19:06:44 -0400
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: "draft-ietf-netmod-rfc6087bis@ietf.org" <draft-ietf-netmod-rfc6087bis@ietf.org>
CC: "netmod-chairs@ietf.org" <netmod-chairs@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] WG Last Call: draft-ietf-netmod-rfc6087bis-14
Thread-Index: AQHTK/QAeOXxoJMMEUGe5/uottVNQaLoNIuAgADU1oD//56TYIAAL14w
Date: Tue, 17 Oct 2017 23:06:44 +0000
Message-ID: <4862029103bb46d7b56013331d9e2d3c@XCH-RTP-013.cisco.com>
References: <DE7DEC2E-F737-4020-8830-AF556A65EEF5@juniper.net> <001701d3470b$8f473fe0$add5bfa0$@clemm.org> <EA300017-CDE0-4006-95D5-D2E81CBBE9E3@juniper.net> <644DA50AFA8C314EA9BDDAC83BD38A2E0EAB6C8C@sjceml521-mbx.china.huawei.com>
In-Reply-To: <644DA50AFA8C314EA9BDDAC83BD38A2E0EAB6C8C@sjceml521-mbx.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.56.228]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/mOHyF8FD44UUm5Fgb1tODMwD3Wk>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-rfc6087bis-14
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Oct 2017 23:06:48 -0000

I was also encouraged to provide comments.  A couple (new?) minor ones...

Section 3.4:
- If a tree diagram is included for an augmented model, it SHOULD contain the integrated of the augmented model.  I.e., use the pyang -f command to generate the tree so that you can explicitly see the schema elements imported 

Side comment: if a YANG module contains extension structures (like YANG-Data) these should also be shown in the tree, but I understand why you might not want to make that a requirement of this document.

Section 3.10: There should be a normative set of YANG validation tools which are run on upload of an Internet draft.   Errors and warnings found later (and perhaps through tools a user doesn't have) should not result in a module being given an error designation.

Thanks,
Eric