[netmod] Review of draft-wwx-netmod-event-yang-09

Jonathan Hansford <jonathan@hansfords.net> Fri, 31 July 2020 11:29 UTC

Return-Path: <jonathan@hansfords.net>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 48E293A1300 for <netmod@ietfa.amsl.com>; Fri, 31 Jul 2020 04:29:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.919
X-Spam-Level:
X-Spam-Status: No, score=-1.919 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BN9m-HXoHk3a for <netmod@ietfa.amsl.com>; Fri, 31 Jul 2020 04:29:09 -0700 (PDT)
Received: from fennec.ash.relay.mailchannels.net (fennec.ash.relay.mailchannels.net [23.83.222.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A8CE93A12F5 for <netmod@ietf.org>; Fri, 31 Jul 2020 04:29:07 -0700 (PDT)
X-Sender-Id: dxszz3qpvg|x-authuser|jonathan@hansfords.net
Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7BAFF9218B2 for <netmod@ietf.org>; Fri, 31 Jul 2020 11:29:04 +0000 (UTC)
Received: from mail.myfast.site (100-96-5-127.trex.outbound.svc.cluster.local [100.96.5.127]) (Authenticated sender: dxszz3qpvg) by relay.mailchannels.net (Postfix) with ESMTPA id 4CA9F921825 for <netmod@ietf.org>; Fri, 31 Jul 2020 11:29:03 +0000 (UTC)
X-Sender-Id: dxszz3qpvg|x-authuser|jonathan@hansfords.net
Received: from mail.myfast.site (mail.myfast.site [81.19.215.14]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.8); Fri, 31 Jul 2020 11:29:04 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dxszz3qpvg|x-authuser|jonathan@hansfords.net
X-MailChannels-Auth-Id: dxszz3qpvg
X-Thoughtful-Exultant: 43c2607038ea736f_1596194944011_1266544389
X-MC-Loop-Signature: 1596194944011:259485168
X-MC-Ingress-Time: 1596194944011
Received: from 94.196.193.62.threembb.co.uk ([94.196.193.62]:64176 helo=[192.168.54.20]) by mail.myfast.site with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from <jonathan@hansfords.net>) id 1k1TDg-0006pw-1e for netmod@ietf.org; Fri, 31 Jul 2020 12:29:00 +0100
From: "Jonathan Hansford" <jonathan@hansfords.net>
To: "netmod@ietf.org" <netmod@ietf.org>
Date: Fri, 31 Jul 2020 11:29:00 +0000
Message-Id: <em2c50a677-100a-4d39-852b-15039c35b7b2@vanguard>
Reply-To: "Jonathan Hansford" <jonathan@hansfords.net>
User-Agent: eM_Client/8.0.2951.0
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="------=_MB95C3909A-F37C-43F1-A0DD-008636592B59"
X-AuthUser: jonathan@hansfords.net
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/mpKJyKHxGMjMFtV4qTYguOETwHM>
Subject: [netmod] Review of draft-wwx-netmod-event-yang-09
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jul 2020 11:29:12 -0000

Hi,

Most of my comments are editorial and to date only address up to the end 
of Section 2:

Page 1

    Could the Abstract be simplified to:
       This document defines a YANG data model for Event Condition Action
       (ECA) policy management.  The ECA policy YANG module provides the
       ability to delegate some network management functions to the 
server
       which can take simple and instant action when a trigger condition 
on
       the system state is met.

Page 3

    1. Introduction

    1st bullet should end in a semi-colon, not a period

    2nd bullet:
       s/large amount/large amounts

    3rd bullet:
       s/can not/cannot

       s/disconnected from/not connected to

    4th bullet:
       s/devices needs/devices need

       s/hundeds/hundreds

       I think a comma after "notifications" would make it easier to 
parse the sentence which should end in a period, not a semi-colon

    Either
       s/network management function/the network management function
    Or
       s/network management function/network management functions

    s/server monitor/server to monitor

    Is it a service or the server that is providing continuous 
performance monitoring?

    s/monitoring and detect defects and failures and/monitoring, detect 
defects and failures, and

    s/a ECA Policy/an ECA Policy

    The second sentence of the penultimate paragraph on page 3 is too 
long, confusing and unstructured. It needs re-writing.

Page 4

    2.1. Terminology

    Might it be worth including definitions from RFC3198 "Terminology for 
Policy-Based Management" as well, either to explain how this Internet 
Draft aligns or where it deviates? For example:

    o  Policy Decision Point (PDP)

    o  Policy Enforcement Point (PEP)

    o  provisioned policy

    It seems to me this Internet Draft provides support for provisioned 
policies where the server is both the PDP and the PEP.

    Neither "Implicit policy variable" nor "Explicit policy variable" are 
defined in RFC3460, though it does introduce (but not formally define) 
the following terms. Be good to properly align with the terms in the 
RFC:

    o  "Implicit PolicyVariable", "Implicitly bound policy variable" and 
"Implicitly defined policy variable"

    o  "Explicitly bound policy variable" and "Explicitly defined policy 
variable"

    Event: The definition of "Event" is a direct lift from RFC5277, so 
shouldn't it just be included it in the list of predefined terms? 
However, it appears the term that is actually used in the Internet Draft 
is "Notification" (in the definitions of Server Event and Datastore 
Event) and, since "Event" is such an overloaded term, it may be better 
to define "Notification".

    Event Stream is used in this Internet Draft, where "Stream" is 
defined in RFC5277.

    Condition: s/cause/causes

    Action: s/Updates or invocations/Update or invocation

    ECA Event:

       Is something missing in this definition, should there be a period 
after "processing", or should "Derived" not have a capital "D"?

       s/extensible list/an extensible list

    Datastore Event: s/for a/for which a

    Self Monitoring: I find it confusing that "Self Monitoring" 
encompasses both monitor and control.

    Self Healing:

       s/discovery, and correction/discovery and correction

       s/actions/Actions

       s/system/the system

    Policy Variable (PV): It is rather confusing that this Internet Draft 
both uses the definition of "policy variable" from RFC3460 and has its 
own definition. Should we just rely on capitalisation to determine which 
is meant?

Jonathan