[netmod] Few Comments //RE: Publication has been requested for draft-ietf-netmod-module-tags-04

Rohit R Ranade <rohitrranade@huawei.com> Wed, 13 February 2019 11:04 UTC

Return-Path: <rohitrranade@huawei.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D68D112894E; Wed, 13 Feb 2019 03:04:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YsAUm6zprC6F; Wed, 13 Feb 2019 03:04:43 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D1171274D0; Wed, 13 Feb 2019 03:04:43 -0800 (PST)
Received: from lhreml702-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id AC0C8AAC9CAE9C7CB149; Wed, 13 Feb 2019 11:04:40 +0000 (GMT)
Received: from lhreml708-chm.china.huawei.com (10.201.108.57) by lhreml702-cah.china.huawei.com (10.201.108.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 13 Feb 2019 11:04:40 +0000
Received: from lhreml708-chm.china.huawei.com (10.201.108.57) by lhreml708-chm.china.huawei.com (10.201.108.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 13 Feb 2019 11:04:40 +0000
Received: from DGGEML401-HUB.china.huawei.com (10.3.17.32) by lhreml708-chm.china.huawei.com (10.201.108.57) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256) id 15.1.1591.10 via Frontend Transport; Wed, 13 Feb 2019 11:04:39 +0000
Received: from DGGEML510-MBX.china.huawei.com ([169.254.2.6]) by DGGEML401-HUB.china.huawei.com ([fe80::89ed:853e:30a9:2a79%31]) with mapi id 14.03.0415.000; Wed, 13 Feb 2019 19:04:30 +0800
From: Rohit R Ranade <rohitrranade@huawei.com>
To: Joel Jaeggli <joelja@gmail.com>, "ibagdona@gmail.com" <ibagdona@gmail.com>
CC: "netmod-chairs@ietf.org" <netmod-chairs@ietf.org>, "iesg-secretary@ietf.org" <iesg-secretary@ietf.org>, "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: Few Comments //RE: [netmod] Publication has been requested for draft-ietf-netmod-module-tags-04
Thread-Index: AdTDhJb0gYn04JakSz6JOcuemg5oyg==
Date: Wed, 13 Feb 2019 11:04:29 +0000
Message-ID: <991B70D8B4112A4699D5C00DDBBF878A6BCF6258@dggeml510-mbx.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.18.150.121]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/nJEN6KWzHBoer_BCNRIhTTYbot8>
Subject: [netmod] Few Comments //RE: Publication has been requested for draft-ietf-netmod-module-tags-04
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 11:04:46 -0000

Editorial Comments:
1.  Section 1, refers to RFC6020 for Yang Module, but since this document uses Yang Version 1.1, I feel it should refer to RFC7950
2.  Section 4.3, " removed with using normal configuration", can use "removed by using normal configuration"
3.  Description of statement "leaf-list tag", in the Step 1), " System added tags are added" can be replaced with "tags of 'system' origin are added" as it associates System with "system" origin in a better way.
4.  Description of statement "leaf-list tag", " The operational view of this list", can be replaced with "The applied configuration of this list", as it uses is a well-known term from RFC 8342.  
5.  Description of statement "leaf-list tag", " User configured tags" can be replaced with "tags of 'intended' origin" as it uses a well-known NMDA term from RFC8342

Technical:
1. Section 4.2, "These tags may be standard or vendor specific tags".  Does this statement exclude other tags from being added by implementations ? If it does not exclude, I feel this statement can be removed.
2. In the description of Yang statement "leaf-list tag", is there any reason why System tags should be added first and then User configured tags ? Not clear.
3. Description of statement "leaf-list masked-tag", " This user can remove (mask) tags", I think we need to clarify that it will not "apply" the tags which have been configured as "masked-tags", because they are not "removed" from any configuration datastore.
The tags which have been masked will be present in <intended>, but will not be present in <operational>. 
Suggested description
" The list of tags that will not be applied to this
module. By adding tags to this list, the user can prevent 
such tags from being applied. It is not an error to add 
tags to this list that are not associated with the module."


With Regards,
Rohit R


-----Original Message-----
From: netmod [mailto:netmod-bounces@ietf.org] On Behalf Of Joel Jaeggli
Sent: 13 February 2019 05:20
To: ibagdona@gmail.com
Cc: netmod-chairs@ietf.org; Joel Jaeggli <joelja@gmail.com>; iesg-secretary@ietf.org; netmod@ietf.org
Subject: [netmod] Publication has been requested for draft-ietf-netmod-module-tags-04

Joel Jaeggli has requested publication of draft-ietf-netmod-module-tags-04 as Proposed Standard on behalf of the NETMOD working group.

Please verify the document's state at https://datatracker.ietf.org/doc/draft-ietf-netmod-module-tags/

_______________________________________________
netmod mailing list
netmod@ietf.org
https://www.ietf.org/mailman/listinfo/netmod