Re: [netmod] *one* week 2nd WG Last Call: draft-ietf-netmod-revised-datastores-07

Robert Wilton <rwilton@cisco.com> Wed, 20 December 2017 08:28 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0270F126DFF; Wed, 20 Dec 2017 00:28:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MC6dPowil7KE; Wed, 20 Dec 2017 00:28:44 -0800 (PST)
Received: from aer-iport-2.cisco.com (aer-iport-2.cisco.com [173.38.203.52]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CBF1E1200C1; Wed, 20 Dec 2017 00:28:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2552; q=dns/txt; s=iport; t=1513758524; x=1514968124; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=KCs9DpnojoDrzhFL/KqCHw/EFJ9ZcK3pyPyCjMregAY=; b=T5cFym3LsXL3HPXM0pySXzm2f8jv2YT/djLRBRMFKPd/mnizunkGClc4 zL6BW+gPB4RP9/g0U5IUsCNgkouosFfuzAxpKcYOBO0c0Q2vpgQB0atq6 YCYiZwfrq6TL/dyAI/ZrN9C5dZwmzVzkJWprKg+dC1KPz5kHHWq5R8dP+ g=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BzAQBZHjpa/xbLJq1bGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYUYJ4QGixWPaAwnmTkKhTsChVQUAQEBAQEBAQEBayiFJAEFIxV?= =?us-ascii?q?RCxgCAiYCAlcGAQwGAgEBiiekNYInhBcBhloBAQEBAQEBAQIBAQEBAQEigQ+CX?= =?us-ascii?q?4NogWkpC4J4gzCBWIMsgmMBBKNDlS6CFooBJIc7jnWIBIE7NiKBTzIaCBsVPII?= =?us-ascii?q?pglMdGYETATpBN4o3AQEB?=
X-IronPort-AV: E=Sophos;i="5.45,431,1508803200"; d="scan'208";a="1041976"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2017 08:28:41 +0000
Received: from [10.63.23.84] (dhcp-ensft1-uk-vla370-10-63-23-84.cisco.com [10.63.23.84]) by aer-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id vBK8SfQ1006612; Wed, 20 Dec 2017 08:28:41 GMT
To: Andy Bierman <andy@yumaworks.com>, Martin Bjorklund <mbj@tail-f.com>, Berger Lou <lberger@labn.net>, NetMod WG Chairs <netmod-chairs@ietf.org>, draft-ietf-netmod-revised-datastores@ietf.org, NetMod WG <netmod@ietf.org>
References: <80a900b3-716a-b11f-3472-7cae57662ba4@labn.net> <198a88e4-9b8b-945b-09a1-49fa9f57cbb0@labn.net> <20171219.213101.692193824403742919.mbj@tail-f.com> <CABCOCHSsYugYe0dgZ_SV6rdt3AGoNx5HknLAkhiDzpPcuGgS+w@mail.gmail.com> <20171219205422.okuxkyj7egpoqo6t@elstar.local>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <d7ac4204-809a-5864-a4d9-8229ae3fae86@cisco.com>
Date: Wed, 20 Dec 2017 08:28:41 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171219205422.okuxkyj7egpoqo6t@elstar.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/p7kyRR1tgz-iGKiPVW_gZUyffC0>
Subject: Re: [netmod] *one* week 2nd WG Last Call: draft-ietf-netmod-revised-datastores-07
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Dec 2017 08:28:46 -0000


On 19/12/2017 20:54, Juergen Schoenwaelder wrote:
> On Tue, Dec 19, 2017 at 12:41:28PM -0800, Andy Bierman wrote:
>> On Tue, Dec 19, 2017 at 12:31 PM, Martin Bjorklund <mbj@tail-f.com> wrote:
>>
>>> Hi Lou,
>>>
>>> Lou Berger <lberger@labn.net> wrote:
>>>> Hi,
>>>>        These comments are based on my Shepherd review of this document and
>>>> should be addressed as part of addressing any LC comments:
>>>>
>>>> 1) Considering the recent discussion on Library made me consider the
>>>> general case of a module that is composed entirely of operational state.
>>>>   I think this case is subject to interpretation and therefore needs to
>>>> be explicitly covered.  For example section 5.3 states:
>>>>
>>>>     The datastore schema for <operational> MUST be a superset of the
>>>>     combined datastore schema used in all configuration datastores except
>>>>     that YANG nodes supported in a configuration datastore MAY be omitted
>>>>     from <operational> if a server is not able to accurately report them.
>>>>
>>>> This could be read that a module that an operational state MUST be
>>>> present (but presumably empty>?) in some other DS to be present in
>>>> operational.  I don't believe this is your intent, but it should be
>>>> explicitly covered for the benefit of future readers.
>>> Ok.  How about we add to the paragraph above a sentence:
>>>
>>>      If a module does not contain any configuration data then it MAY be
>>>      omitted from the schema for the configuration datastores.
>> I liked the old YANG library better.
>> It allows a client to create of a list of all the
>> modules/revisions/features/deviations
>> that will be needed to match the schema tree used by the server.
>> The compiler does not care if it is looking for a typedef vs. a data node.
>> The YANG library details help the compiler find the correct definitions.
>>
>> Consider iana-crypt-hash that has only typedefs and features.
>> Leaving this module out of the library can cause problems for a client.
>>
> I think this is not the intention. If a module is needed to satisfy
> imports, it has to be listed as part of the schema. So perhaps this is
> better?
>
>      If a module does not contain any configuration data and it is not
>      needed to satisfy any imports, then it MAY be omitted from the
>      schema for the configuration datastores.
One minor tweak, I think that "configuration" would be better than 
"configuration data" for consistency reasons.

Thanks,
Rob


>
> /js
>