Re: [netmod] Adam Roach's No Objection on draft-ietf-netmod-rfc6087bis-18: (with COMMENT)

Robert Wilton <rwilton@cisco.com> Fri, 09 March 2018 14:58 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26DFB128896; Fri, 9 Mar 2018 06:58:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.509
X-Spam-Level:
X-Spam-Status: No, score=-14.509 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id at067Ijl8Tnr; Fri, 9 Mar 2018 06:58:36 -0800 (PST)
Received: from aer-iport-1.cisco.com (aer-iport-1.cisco.com [173.38.203.51]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E4F2126B7E; Fri, 9 Mar 2018 06:58:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5069; q=dns/txt; s=iport; t=1520607515; x=1521817115; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to; bh=ShRK2Ylz/WKDWD5pSES/8GT0oH6ggf05Bf1bT/P9v68=; b=XCJdprSQTilJCdy6qm+XAM9Ilobc7IQEmRZdJhbvhvtVTcxpUBjlTzLq GUQLWEUJRoz7MfiEIUvhWmlGr2JQ4nU15gSqlSCilKEOsyp8UYjePYtVL Jh7TBWNlwaKRdb1vYv08xjrd/RrkAE9sq5ZkXBnu4zitWCPk1+0oFawgK s=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0B7AQD4n6Ja/xbLJq1eGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYMjgRNvKINQixGOVDSBFo8ShzcKGAEKhDNPAoMyNxUBAgEBAQE?= =?us-ascii?q?BAQJrJ4UkAQEEAQEhSwsQCwQUKgICJzAGAQwGAgEBhRUPrH2CJiaES4N0ghUFh?= =?us-ascii?q?TeEBIIPgk82gy4BAYFLgy+CYgSaVQmQYweJCoVXi0WGAoEsNCKBUjMaCBsVOoJ?= =?us-ascii?q?DgmNuAQhuQDeIQgElB4IaAQEB?=
X-IronPort-AV: E=Sophos;i="5.47,446,1515456000"; d="scan'208,217";a="2523706"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2018 14:58:31 +0000
Received: from [10.63.23.110] (dhcp-ensft1-uk-vla370-10-63-23-110.cisco.com [10.63.23.110]) by aer-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id w29EwVMw006412; Fri, 9 Mar 2018 14:58:31 GMT
To: Adam Roach <adam@nostrum.com>, Andy Bierman <andy@yumaworks.com>
Cc: NetMod WG Chairs <netmod-chairs@ietf.org>, NetMod WG <netmod@ietf.org>, The IESG <iesg@ietf.org>, draft-ietf-netmod-rfc6087bis@ietf.org
References: <152050158005.21412.3389388204390015375.idtracker@ietfa.amsl.com> <CABCOCHSmCioJPNM5b9J-5WCsXe_J2jMzKKCD8fw02uh-D5nNdA@mail.gmail.com> <e627d122-a709-c41c-b58a-b5890b8d2103@nostrum.com>
From: Robert Wilton <rwilton@cisco.com>
Message-ID: <72ff2814-611e-929d-0e8f-298e26a0da32@cisco.com>
Date: Fri, 9 Mar 2018 14:58:31 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <e627d122-a709-c41c-b58a-b5890b8d2103@nostrum.com>
Content-Type: multipart/alternative; boundary="------------CBEA39B9126455EF451F3439"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/ptpeLpe0TvK-Xkxh1BOzd2V2Ogk>
Subject: Re: [netmod] Adam Roach's No Objection on draft-ietf-netmod-rfc6087bis-18: (with COMMENT)
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Mar 2018 14:58:38 -0000

Hi Adam,


On 08/03/2018 23:55, Adam Roach wrote:
> Thanks for your quick response! I have some additional comments inline.
>
<snip>
>
> Clearly, the items that have already been published can't be changed, 
> but it seems like there is room for guidance about whether to optimize 
> for simple regexes, or for more rigorous ones.
I agree with your general sentiment.  In fact I had a long protracted 
discussion on this point on the Netmod WG alias.

Sometimes pattern statements can be both correct and also concise and 
readable.  This is the easy case.

But for other regular expressions (e.g. route-target in rfc8294) there 
is a clear choice whether to make the regex as precise as possible 
(minimizing false values), or to make it concise and hopefully 
readable/verifiable but allowing for more false values.

My personal preference is for a simpler, but less precise regex over a 
more precise, but hard to visually verify, regex.  E.g. I'm not a fan of 
using regular expressions to limit the range of numerical values.  I 
know that validating regular expression matches is computationally 
expensive, so I wonder if implementations will end up replacing these 
larger regular expressions with custom written verification code that is 
more performant.  But, as I recall, I was in the rough on this issue.

If the consensus is that they should be as accurate as is feasible then 
I think that it would be helpful if the guidelines state this as a 
goal.  This would seem to ensure consistency in the YANG models that are 
being standardized.

Thanks,
Rob

>
> /a
>
>
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod