Re: [netmod] I-D Action: draft-chopps-netmod-geo-location-00.txt

Hi,

Just some quick comments on the YANG:

The pattern

        '[-0-9a-z #x22#x23#x5B#x5D' +
        '!$%&()*+,\./:;<=>?@\\^_`{|}~]+';

doesn't seem to be correct.  I think it should be:

        '[-0-9a-z "#[\]' +
        '!$%&()*+,./:;<=>?@\\^_`{|}~]+';

i.e., don't use hex codes (the regex dialect we use
don't support them, and besides, the normal syntax is \x22 etc.), and
don't escape characters that don't need escapes.

However, it seems libxml2's regexp engine requires both "[" and "^" to
be escaped:

        '[-0-9a-z "#\[\]' +
        '!$%&()*+,./:;<=>?@\\\^_`{|}~]+';

This expression isn't wrong, but it seems to me that these characters
should not have to be escaped.

The pattern allows double quote (") but not single quote (').  Is
that intentional?

[a simple way to test the patterns is to have a "default" statement
and a YANG complier that verifies defaults]

I recommend that you rename the example module in section to
"example-uses-geo-location" (and change the namespace to
urn:example:uses-geo-location).   We should not use the "ietf"
namespace for examples.

/martin

Christian Hopps <chopps@chopps.org> wrote:
> FYI.
> 
> > Begin forwarded message:
> > 
> > From: internet-drafts@ietf.org
> > Subject: I-D Action: draft-chopps-netmod-geo-location-00.txt
> > Date: February 26, 2019 at 3:59:23 PM EST
> > To: <i-d-announce@ietf.org>
> > Reply-To: internet-drafts@ietf.org
> > 
> > 
> > A New Internet-Draft is available from the on-line Internet-Drafts directories.
> > 
> > 
> >        Title           : YANG Geo Location
> >        Author          : Christian Hopps
> > 	Filename        : draft-chopps-netmod-geo-location-00.txt
> > 	Pages           : 17
> > 	Date            : 2019-02-26
> > 
> > Abstract:
> >   This document defines a generic geographical location object YANG
> >   grouping.  The geographical location grouping is intended to be used
> >   in YANG models for specifying a location on or in reference to the
> >   Earth or any other astronomical object.
> > 
> > 
> > The IETF datatracker status page for this draft is:
> > https://datatracker.ietf.org/doc/draft-chopps-netmod-geo-location/
> > 
> > There are also htmlized versions available at:
> > https://tools.ietf.org/html/draft-chopps-netmod-geo-location-00
> > https://datatracker.ietf.org/doc/html/draft-chopps-netmod-geo-location-00
> > 
> > 
> > Please note that it may take a couple of minutes from the time of submission
> > until the htmlized version and diff are available at tools.ietf.org.
> > 
> > Internet-Drafts are also available by anonymous FTP at:
> > ftp://ftp.ietf.org/internet-drafts/
> > 
> > _______________________________________________
> > I-D-Announce mailing list
> > I-D-Announce@ietf.org
> > https://www.ietf.org/mailman/listinfo/i-d-announce
> > Internet-Draft directories: http://www.ietf.org/shadow.html
> > or ftp://ftp.ietf.org/ietf/1shadow-sites.txt
> > 
> 