Re: [netmod] I-D Action: draft-chopps-netmod-geo-location-00.txt

Martin Bjorklund <mbj@tail-f.com> Mon, 04 March 2019 11:59 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CDE0412D4E6 for <netmod@ietfa.amsl.com>; Mon, 4 Mar 2019 03:59:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RGeOLmOIMp1I for <netmod@ietfa.amsl.com>; Mon, 4 Mar 2019 03:59:55 -0800 (PST)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 5B2CD130F3E for <netmod@ietf.org>; Mon, 4 Mar 2019 03:59:55 -0800 (PST)
Received: from localhost (unknown [173.38.220.61]) by mail.tail-f.com (Postfix) with ESMTPSA id 39ED81AE0118; Mon, 4 Mar 2019 12:59:53 +0100 (CET)
Date: Mon, 04 Mar 2019 12:59:54 +0100 (CET)
Message-Id: <20190304.125954.2202467396264498027.mbj@tail-f.com>
To: chopps@chopps.org
Cc: netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <20190304.105940.312797647046250578.mbj@tail-f.com>
References: <155121476305.848.1143308532121819978@ietfa.amsl.com> <51C97F98-F877-49D4-9250-5213A31B442D@chopps.org> <20190304.105940.312797647046250578.mbj@tail-f.com>
X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/u_kt_eNyvHuLT5QiGAIo2xGfouo>
Subject: Re: [netmod] I-D Action: draft-chopps-netmod-geo-location-00.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2019 11:59:58 -0000

Martin Bjorklund <mbj@tail-f.com> wrote:
> Hi,
> 
> Just some quick comments on the YANG:
> 
> The pattern
> 
>         '[-0-9a-z #x22#x23#x5B#x5D' +
>         '!$%&()*+,\./:;<=>?@\\^_`{|}~]+';
> 
> doesn't seem to be correct.  I think it should be:
> 
>         '[-0-9a-z "#[\]' +
>         '!$%&()*+,./:;<=>?@\\^_`{|}~]+';
> 
> i.e., don't use hex codes (the regex dialect we use
> don't support them, and besides, the normal syntax is \x22 etc.), and
> don't escape characters that don't need escapes.
> 
> However, it seems libxml2's regexp engine requires both "[" and "^" to
> be escaped:
> 
>         '[-0-9a-z "#\[\]' +
>         '!$%&()*+,./:;<=>?@\\\^_`{|}~]+';
> 
> This expression isn't wrong, but it seems to me that these characters
> should not have to be escaped.


It turns out that "[" actually must be escaped, but the handling of
"^" is a bug in libxml2:

https://bugzilla.gnome.org/show_bug.cgi?id=779751
https://bugzilla.gnome.org/show_bug.cgi?id=674411



/martin


> 
> 
> The pattern allows double quote (") but not single quote (').  Is
> that intentional?
> 
> [a simple way to test the patterns is to have a "default" statement
> and a YANG complier that verifies defaults]
> 
> 
> 
> I recommend that you rename the example module in section to
> "example-uses-geo-location" (and change the namespace to
> urn:example:uses-geo-location).   We should not use the "ietf"
> namespace for examples.
> 
> 
> 
> /martin
> 
> 
> 
> 
> 
> 
> Christian Hopps <chopps@chopps.org> wrote:
> > FYI.
> > 
> > > Begin forwarded message:
> > > 
> > > From: internet-drafts@ietf.org
> > > Subject: I-D Action: draft-chopps-netmod-geo-location-00.txt
> > > Date: February 26, 2019 at 3:59:23 PM EST
> > > To: <i-d-announce@ietf.org>
> > > Reply-To: internet-drafts@ietf.org
> > > 
> > > 
> > > A New Internet-Draft is available from the on-line Internet-Drafts directories.
> > > 
> > > 
> > >        Title           : YANG Geo Location
> > >        Author          : Christian Hopps
> > > 	Filename        : draft-chopps-netmod-geo-location-00.txt
> > > 	Pages           : 17
> > > 	Date            : 2019-02-26
> > > 
> > > Abstract:
> > >   This document defines a generic geographical location object YANG
> > >   grouping.  The geographical location grouping is intended to be used
> > >   in YANG models for specifying a location on or in reference to the
> > >   Earth or any other astronomical object.
> > > 
> > > 
> > > The IETF datatracker status page for this draft is:
> > > https://datatracker.ietf.org/doc/draft-chopps-netmod-geo-location/
> > > 
> > > There are also htmlized versions available at:
> > > https://tools.ietf.org/html/draft-chopps-netmod-geo-location-00
> > > https://datatracker.ietf.org/doc/html/draft-chopps-netmod-geo-location-00
> > > 
> > > 
> > > Please note that it may take a couple of minutes from the time of submission
> > > until the htmlized version and diff are available at tools.ietf.org.
> > > 
> > > Internet-Drafts are also available by anonymous FTP at:
> > > ftp://ftp.ietf.org/internet-drafts/
> > > 
> > > _______________________________________________
> > > I-D-Announce mailing list
> > > I-D-Announce@ietf.org
> > > https://www.ietf.org/mailman/listinfo/i-d-announce
> > > Internet-Draft directories: http://www.ietf.org/shadow.html
> > > or ftp://ftp.ietf.org/ietf/1shadow-sites.txt
> > > 
> > 
> 
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod
>