[netmod] LL review of draft-ietf-netmod-intf-ext-yang-03
Ladislav Lhotka <lhotka@nic.cz> Wed, 21 December 2016 13:08 UTC
Return-Path: <lhotka@nic.cz>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 714B1129D91 for <netmod@ietfa.amsl.com>; Wed, 21 Dec 2016 05:08:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z62nMm9fdnGQ for <netmod@ietfa.amsl.com>; Wed, 21 Dec 2016 05:08:12 -0800 (PST)
Received: from trail.lhotka.name (trail.lhotka.name [77.48.224.143]) by ietfa.amsl.com (Postfix) with ESMTP id C9FD0129D88 for <netmod@ietf.org>; Wed, 21 Dec 2016 05:08:11 -0800 (PST)
Received: from localhost (unknown [195.113.220.110]) by trail.lhotka.name (Postfix) with ESMTPSA id 9F57D1CC0317 for <netmod@ietf.org>; Wed, 21 Dec 2016 14:08:10 +0100 (CET)
From: Ladislav Lhotka <lhotka@nic.cz>
To: netmod@ietf.org
Date: Wed, 21 Dec 2016 14:08:09 +0100
Message-ID: <m2h95xxwee.fsf@birdie.labs.nic.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/ud2OeZMave0AaoWNhf9O1qefnAg>
Subject: [netmod] LL review of draft-ietf-netmod-intf-ext-yang-03
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Dec 2016 13:08:13 -0000
Hi, I think this is a very useful addition to ietf-interfaces. In general, the document is clearly written and YANG modules nicely designed. Here are my comments: *** Sec. 1 - "This document defines two YANG RFC 7950 [RFC7950] modules …" looks weird. I'd suggest "… YANG 1.1 [RFC7950] …" instead. *** Sec. 2 - first line: s/of of/of/ *** Sec. 3.1 - If the "bandwidth" parameter is only used for tuning routing algorithms and has nothing to do with real bandwidth on the interface, I would suggest to use a different name (metric?). Perhaps it may indeed be better to leave this to routing protocol modules because they can also specify how exactly such a parameter is used. *** Sec. 3.6 - The "l3-mtu" parameter is probably the same as "mtu" defined in ietf-ip. Again, I would suggest to leave the definition of MTU to each L3 protocol because there may be specific aspects and constraints. *** Sec. 3.8 - I think that "transport-layer" is not a good name because in the ISO OSI model it denotes a particular layer (L4). How about "iso-osi-layer"? - The type of "transport-layer" has three enums, namely "layer-[123]". I would suggest to use descriptive names ("physical-layer" etc.), include the remaining layers of the ISO OSI model, and maybe also define it as a typedef - or does this belong to ietf-inet-types? - Is a leaf sufficient? I think some interfaces can be in multiple layers at the same time (e.g. an ATM interface is L3 but can also be L2 for Classical IP over ATM). Or is the idea that such an interface will be split into two entries of the "interface" list? *** YANG modules - Descriptions are not consistently formatted. I think that the current BCP is to start description text on the same line as the "description" keyword only if it all fits on one line. - I don't have a strong opinion on this but it might increase readability if the number of augments is reduced. Perhaps at least augments that contain only one node could be made into one (and the "feature" and "when" statements moved to the nodes' definitions. Lada -- Ladislav Lhotka, CZ.NIC Labs PGP Key ID: 0xB8F92B08A9F76C67
- [netmod] LL review of draft-ietf-netmod-intf-ext-… Ladislav Lhotka
- Re: [netmod] LL review of draft-ietf-netmod-intf-… Martin Bjorklund
- Re: [netmod] LL review of draft-ietf-netmod-intf-… Robert Wilton
- Re: [netmod] LL review of draft-ietf-netmod-intf-… Ladislav Lhotka
- Re: [netmod] LL review of draft-ietf-netmod-intf-… Robert Wilton
- Re: [netmod] LL review of draft-ietf-netmod-intf-… Ladislav Lhotka
- Re: [netmod] LL review of draft-ietf-netmod-intf-… Robert Wilton
- Re: [netmod] LL review of draft-ietf-netmod-intf-… Acee Lindem (acee)
- Re: [netmod] LL review of draft-ietf-netmod-intf-… Robert Wilton