Re: [netmod] New Version Notification for draft-ietf-netmod-factory-default-04.txt

Qin Wu <bill.wu@huawei.com> Tue, 29 October 2019 02:56 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 41751120047 for <netmod@ietfa.amsl.com>; Mon, 28 Oct 2019 19:56:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EKr2nFOSv96H for <netmod@ietfa.amsl.com>; Mon, 28 Oct 2019 19:56:30 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB420120046 for <netmod@ietf.org>; Mon, 28 Oct 2019 19:56:29 -0700 (PDT)
Received: from lhreml701-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id B64A480239FB9F5011A4 for <netmod@ietf.org>; Tue, 29 Oct 2019 02:56:27 +0000 (GMT)
Received: from DGGEML406-HUB.china.huawei.com (10.3.17.50) by lhreml701-cah.china.huawei.com (10.201.108.42) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 29 Oct 2019 02:56:27 +0000
Received: from DGGEML511-MBX.china.huawei.com ([169.254.1.72]) by dggeml406-hub.china.huawei.com ([10.3.17.50]) with mapi id 14.03.0439.000; Tue, 29 Oct 2019 10:56:23 +0800
From: Qin Wu <bill.wu@huawei.com>
To: "Joe Clarke (jclarke)" <jclarke@cisco.com>
CC: "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] New Version Notification for draft-ietf-netmod-factory-default-04.txt
Thread-Index: AdWOAz5S0PTnUSaLTlWNb0HPnt4vDA==
Date: Tue, 29 Oct 2019 02:56:23 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABAA93B5885@dggeml511-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.134.31.203]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/vMxmxSsOxWDdPfNsWvNsHQ2qxio>
Subject: Re: [netmod] New Version Notification for draft-ietf-netmod-factory-default-04.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 02:56:32 -0000

Hi, Joe:
Thanks for your valuable comments, see reply inline below.
-----邮件原件-----
发件人: Joe Clarke (jclarke) [mailto:jclarke@cisco.com] 
发送时间: 2019年10月28日 22:13
收件人: Qin Wu <bill.wu@huawei.com>
抄送: netmod@ietf.org
主题: Re: [netmod] New Version Notification for draft-ietf-netmod-factory-default-04.txt



> On Oct 27, 2019, at 23:37, Qin Wu <bill.wu@huawei.com> wrote:
> 
> v-04 is posted
> https://tools.ietf.org/html/draft-ietf-netmod-factory-default-04
> additional text to clarify rpc usage.

Thanks, Qin.  I re-read this latest draft, and albeit there were only a few changes, I have some broader comments.

First, I remember we talked about a reboot operation I think at the last IETF(?).  It was said that perhaps a reboot would happen as part of this RPC because once the <running> datastore is reset to factory-default, the device would not be reachable.  I don’t know where we landed on that.  However, I think some attention should be paid to things like zero-touch provisioning.  If I reset to factory-default, I would expect the device to undergo any out-of-the-box bootstrapping.  Perhaps adding some text that after the RPC is executed, the device SHOULD perform any initial bootstrapping processes?

[Qin]:Yes, initial bootstrapping processes should be covered, I will propose text in the separate email for this.

===

In Section 2, perhaps for clarity say that, “Factory-default content SHALL be specified by one of the following means in descending order of precedence”?  I’m nit-picking on this one, though.

[Qin]: okay, fixed.
===

In Section 2, you mention Instance Data is second in the list.  What is really meant by this?  Does that mean the factory-default config is defined by an instance data file specified by the vendor in some offline location?  If so, perhaps it’s worth clarifying that.
[Qin]: How about the following proposed changes:
OLD TEXT
"
YANG Instance Data [I-D.ietf-netmod-yang-instance-file-format]
"
NEW TEXT:
"
  by vendors using YANG Instance Data [I-D.ietf-netmod-yang-instance-file-format] file format in
  vendor's website or other places where off-line document is kept;
"

===

In Section 2 and in the YANG module description for the RPC your tenses don’t match.  You should say:

Upon receiving the RPC the server resets the contents of all read-write configuration datastore (e.g., <running> and <startup>) to their factory-default contents.

[Qin]:Good catch, fixed.
===

In Section 2, you say, “some of the SW processes”.  I think you mean software.  You should expand SW.
[Qin]:Fixed.

Joe

> 
> -Qin
> -----邮件原件-----
> 发件人: internet-drafts@ietf.org [mailto:internet-drafts@ietf.org] 
> 发送时间: 2019年10月28日 11:36
> 收件人: Niuye <niuye@huawei.com>; Qin Wu <bill.wu@huawei.com>; Qin Wu <bill.wu@huawei.com>; Balazs Lengyel <balazs.lengyel@ericsson.com>
> 主题: New Version Notification for draft-ietf-netmod-factory-default-04.txt
> 
> 
> A new version of I-D, draft-ietf-netmod-factory-default-04.txt
> has been successfully submitted by Qin Wu and posted to the IETF repository.
> 
> Name:		draft-ietf-netmod-factory-default
> Revision:	04
> Title:		Factory Default Setting
> Document date:	2019-10-26
> Group:		netmod
> Pages:		11
> URL:            https://www.ietf.org/internet-drafts/draft-ietf-netmod-factory-default-04.txt
> Status:         https://datatracker.ietf.org/doc/draft-ietf-netmod-factory-default/
> Htmlized:       https://tools.ietf.org/html/draft-ietf-netmod-factory-default-04
> Htmlized:       https://datatracker.ietf.org/doc/html/draft-ietf-netmod-factory-default
> Diff:           https://www.ietf.org/rfcdiff?url2=draft-ietf-netmod-factory-default-04
> 
> Abstract:
>   This document defines a method to reset a server to its factory-
>   default content.  The reset operation may be used e.g. during initial
>   zero-touch configuration or when the existing configuration has major
>   errors, so re-starting the configuration process from scratch is the
>   best option.
> 
>   A new factory-reset RPC is defined.  Several methods of documenting
>   the factory-default content are specified.
> 
>   Optionally a new "factory-default" read-only datastore is defined,
>   that contains the data that will be copied over to the running
>   datastore at reset.
> 
> 
> 
> 
> Please note that it may take a couple of minutes from the time of submission until the htmlized version and diff are available at tools.ietf.org.
> 
> The IETF Secretariat
> 
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod