IETF Logo Mail Archive

Re: [netmod] WGLC for draft-ietf-tictoc-1588v2-yang

Alex Campbell <Alex.Campbell@Aviatnet.com> Fri, 15 September 2017 05:27 UTC

Return-Path: <Alex.Campbell@Aviatnet.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B277132403; Thu, 14 Sep 2017 22:27:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XMTEuPoI6GBM; Thu, 14 Sep 2017 22:27:25 -0700 (PDT)
Received: from mail-send.aviatnet.com (mail-send.aviatnet.com [192.147.115.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD5A1132335; Thu, 14 Sep 2017 22:27:25 -0700 (PDT)
From: Alex Campbell <Alex.Campbell@Aviatnet.com>
To: Jiangyuanlong <jiangyuanlong@huawei.com>, "netmod@ietf.org" <netmod@ietf.org>
CC: "tictoc@ietf.org" <tictoc@ietf.org>
Thread-Topic: WGLC for draft-ietf-tictoc-1588v2-yang
Thread-Index: AQHTLMS9I02w6VlOokuuR++M6yrZg6K1JzgQgAA51/0=
Date: Fri, 15 Sep 2017 05:27:23 +0000
Message-ID: <1505453243090.91370@Aviatnet.com>
References: <3B0A1BED22CAD649A1B3E97BE5DDD68BBB5A2CBD@dggeml507-mbx.china.huawei.com>
In-Reply-To: <3B0A1BED22CAD649A1B3E97BE5DDD68BBB5A2CBD@dggeml507-mbx.china.huawei.com>
Accept-Language: en-NZ, en-US
Content-Language: en-NZ
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.15.6.10]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/wR6eBybj7bdWArW1OiEnyCp-iXc>
Subject: Re: [netmod] WGLC for draft-ietf-tictoc-1588v2-yang
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Sep 2017 05:27:27 -0000

Hi,
I've reviewed the draft and found the following issues.

* YANG enumeration values are conventionally lowercase, but the delay-mechanism-enumeration and port-state-enumeration types in the draft have uppercase values.
* Similarly, hyphens should be used rather than underscores (pre-master instead of PRE_MASTER)
* number-ports doesn't read naturally in English; I suggest renaming it to number-of-ports.
* The description of port-ds-list contains a typo - "memer" instead of "member".
* There's no need to have groupings that are only used once (such as parent-ds-entry, current-ds-entry, default-ds-entry, transparent-clock-default-ds-entry, port-ds-entry, transparent-clock-default-ds-entry, and so on) unless this is for futureproofing or some other reason I'm not aware of.
* Is it necessary to include -ds in the name of every leaf, container and grouping?

Note I'm not familiar with IEEE 1588, apart from a brief look through it just now.

Alex


________________________________________
From: netmod <netmod-bounces@ietf.org> on behalf of Jiangyuanlong <jiangyuanlong@huawei.com>
Sent: Friday, 15 September 2017 1:42 p.m.
To: netmod@ietf.org
Cc: tictoc@ietf.org
Subject: [netmod] FW: WGLC for draft-ietf-tictoc-1588v2-yang

Hi netmoders,

This draft does not tackle the general YANG problem, but provide a generic time synchronization module of 1588.
Some of you may have interests in time synchronization, some definitely not. But as experts in YANG, could you please have a review of this YANG module and give an expert opinion?

Thanks,
Yuanlong

-----Original Message-----
From: TICTOC [mailto:tictoc-bounces@ietf.org] On Behalf Of Karen O'Donoghue
Sent: Thursday, September 14, 2017 3:16 AM
To: tictoc@ietf.org
Cc: ntp@ietf.org
Subject: [TICTOC] WGLC for draft-ietf-tictoc-1588v2-yang

Folks,

This message begins a 2 week working group last call (WGLC) for the following document:

YANG Data Model for IEEE 1588v2
https://datatracker.ietf.org/doc/draft-ietf-tictoc-1588v2-yang/

Please review the referenced document and send any comments to the mailing list including your assessment of whether this document is mature enough to proceed to the IESG. Please note that these messages of support for progression to the mailing list are important and will be used to determine WG consensus to proceed.

Please send all comments in by Thursday 28 September 2017.

Thank you!
Karen
_______________________________________________
TICTOC mailing list
TICTOC@ietf.org
https://www.ietf.org/mailman/listinfo/tictoc

_______________________________________________
netmod mailing list
netmod@ietf.org
https://www.ietf.org/mailman/listinfo/netmod

v2.23.0 | Report a Bug | By Email