Re: [nfsv4] Proposed updates to draft-ietf-nfsv4-rpcrdma-cm-pvt-data

David Noveck <davenoveck@gmail.com> Mon, 16 December 2019 10:24 UTC

Return-Path: <davenoveck@gmail.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B220812018D for <nfsv4@ietfa.amsl.com>; Mon, 16 Dec 2019 02:24:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BJu9jfzuKQWJ for <nfsv4@ietfa.amsl.com>; Mon, 16 Dec 2019 02:24:57 -0800 (PST)
Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1FDFD12016E for <nfsv4@ietf.org>; Mon, 16 Dec 2019 02:24:57 -0800 (PST)
Received: by mail-ot1-x32e.google.com with SMTP id g18so8543899otj.13 for <nfsv4@ietf.org>; Mon, 16 Dec 2019 02:24:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tO9O73LrUebsHqc6/RSsdMX4INZWHZJBrNdonlmJxQU=; b=A1uvpX6Sk0dHmLIKOM8WFiC/SpYjLNg+F27Z1njxx5BqDvz7w2o/j1q23rOUWJwx3U zk/svWkBWFQmFeR+b8hDC+BUyBbYr1nV+S++9HnNxYuFNCLKplJKUFp0O5wnoHHvdG1B MSmwFWv1AFz+utFWBSvlP3qp/ZcNfZIoQQ4IuRycG3hERxMH76oQXuv0jQZvcvacdiPe a9avJ2I+2/5Pec7Pg+desd0rScqlr5IpAwGq3mF3kWSOMTqunmcgRXShjRgJyiGmfhF5 6b/jqe97USjXR2eCQkjQOBwIsjXdGSO5QWDuE8w2A1R3nBclGihX0vLAdR3JCzmidZOf ph9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tO9O73LrUebsHqc6/RSsdMX4INZWHZJBrNdonlmJxQU=; b=tunOUX5dpW2id2V9kjP3BR7WVfdCdsbBGIgSr94fIV4WsRjcvIwd3QrrXLSAdvWwVW 6q+SlF6jbA6u/E2GvYUcHTNI3zu0T/kn1QXBCKCZCmovT8IjWeS57ntm/FF2X/LRiZst VrkFj1WSHcpeTQg9LMfG63Y6uD+Mtj57JjrVO43/6WE6BlGhpr2zjPIX7NkJUdRSKhgL TuD5afkw18/b2ubcs5TtPP9MKLTIu9zqa6CKZRGwuGvjonEGJtw0A55gF8PDW5+P8Bwg TSxWj1H0o1wXF/X7M9nBdygcoHiXQ2FsDv3UCpTSz5X4F/l2dWW/5lyYZoN1U3fmwYsH fK8A==
X-Gm-Message-State: APjAAAUeBa5EZimbXi1zIDj9yjadVDvQdUg3/Ln85QpEpbEQEcnoBBc5 tMiJ7jIloT1ZqAjAanQESpsVU4iW/rEwfjJgjMY=
X-Google-Smtp-Source: APXvYqyPOJyXq3e282XU/hiWt7mXJ+TZVDB6e4B6AVAtG0RTkYSvrevFoD+hhzlgAzs+50QhXYxUCLP+/l7mm21eNl0=
X-Received: by 2002:a05:6830:1047:: with SMTP id b7mr32229298otp.77.1576491896277; Mon, 16 Dec 2019 02:24:56 -0800 (PST)
MIME-Version: 1.0
References: <863D1C52-3FCB-47EF-9DEA-4BE8CEF51D6C@oracle.com>
In-Reply-To: <863D1C52-3FCB-47EF-9DEA-4BE8CEF51D6C@oracle.com>
From: David Noveck <davenoveck@gmail.com>
Date: Mon, 16 Dec 2019 05:24:45 -0500
Message-ID: <CADaq8jetCKVnvL9Ci1teVev4oSAzcjoftXxQOfFqzSYSKF5=jA@mail.gmail.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: NFSv4 <nfsv4@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000007810620599cf9f87"
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/1NYCGnrG3mCYBcogdxrSROTbeec>
Subject: Re: [nfsv4] Proposed updates to draft-ietf-nfsv4-rpcrdma-cm-pvt-data
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Dec 2019 10:25:00 -0000

Ship it.

On Sun, Dec 15, 2019, 3:48 PM Chuck Lever <chuck.lever@oracle.com> wrote:

> As a result of expert review, changes are needed to Section 4.1.2
> to clarify the purpose and implementation guidance of the Format
> Identifier field.
>
> I propose that the new Section read (in its entirety):
>
>
> 4.1.2.  Amongst Implementations of Other Upper-Layer Protocols
>
>    The Format Identifier field in the message format defined in this
>    document is provided to enable implementations to distinguish RPC-
>    over-RDMA version 1 Private Data from private data inserted at layers
>    below RPC-over-RDMA version 1.  An example of a layer below RPC-over-
>    RDMA version 1 that makes use of CM Private Data is iWARP, via the
>    MPA enhancement described in [RFC6581].
>
>    During connection establishment, an implementation of the extension
>    described in this document checks the Format Identifier field before
>    decoding subsequent fields.  If the RPC-over-RDMA version 1 CM
>    Private Data Format Identifier is not present as the first 4 octets,
>    an RPC-over-RDMA version 1 receiver MUST ignore the CM Private Data,
>    behaving as if no RPC-over-RDMA version 1 Private Data has been
>    provided (see above).
>
>    Because the Format Identifier field is newer than some other
>    potential users of private data (such as iWARP), there is a risk that
>    a lower layer might inject its own private data with a payload
>    somehow containing the identifier of RPC-over-RDMA version 1.  It is
>    recommended that RPC-over-RDMA version 1 implementations perform
>    additional checks on the content of received CM private data before
>    making use of it.
>
>
> --
> Chuck Lever
>
>
>
> _______________________________________________
> nfsv4 mailing list
> nfsv4@ietf.org
> https://www.ietf.org/mailman/listinfo/nfsv4
>