Re: [nfsv4] comparison of seqid

<david.noveck@emc.com> Mon, 22 November 2010 15:28 UTC

Return-Path: <david.noveck@emc.com>
X-Original-To: nfsv4@core3.amsl.com
Delivered-To: nfsv4@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 63A8A3A6A97 for <nfsv4@core3.amsl.com>; Mon, 22 Nov 2010 07:28:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.599
X-Spam-Level:
X-Spam-Status: No, score=-6.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EdSAuxWVxIYj for <nfsv4@core3.amsl.com>; Mon, 22 Nov 2010 07:28:50 -0800 (PST)
Received: from mexforward.lss.emc.com (mexforward.lss.emc.com [128.222.32.20]) by core3.amsl.com (Postfix) with ESMTP id 5B22C28B56A for <nfsv4@ietf.org>; Mon, 22 Nov 2010 07:28:50 -0800 (PST)
Received: from hop04-l1d11-si04.isus.emc.com (HOP04-L1D11-SI04.isus.emc.com [10.254.111.24]) by mexforward.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id oAMFTYi7010467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Nov 2010 10:29:35 -0500
Received: from mailhub.lss.emc.com (mailhub.lss.emc.com [10.254.222.226]) by hop04-l1d11-si04.isus.emc.com (RSA Interceptor); Mon, 22 Nov 2010 10:29:26 -0500
Received: from corpussmtp3.corp.emc.com (corpussmtp3.corp.emc.com [10.254.169.196]) by mailhub.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id oAMFSbE1003673; Mon, 22 Nov 2010 10:28:38 -0500
Received: from CORPUSMX50A.corp.emc.com ([128.221.62.43]) by corpussmtp3.corp.emc.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 22 Nov 2010 10:28:37 -0500
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 22 Nov 2010 10:28:35 -0500
Message-ID: <BF3BB6D12298F54B89C8DCC1E4073D8002A5EECC@CORPUSMX50A.corp.emc.com>
In-Reply-To: <AANLkTim1L_q1iyTvDugKmwhb2XwZMnZbrJmgGtbzS8LN@mail.gmail.com>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: [nfsv4] comparison of seqid
Thread-Index: AcuKVOS4/4DmDffYSGCpzkcWSd68xgAA5D2g
References: <EA7FBAA54489FB41B1DF6741FBD98B4101FBF0FE32@MX09A.corp.emc.com><BF3BB6D12298F54B89C8DCC1E4073D8002A5EEAB@CORPUSMX50A.corp.emc.com> <AANLkTim1L_q1iyTvDugKmwhb2XwZMnZbrJmgGtbzS8LN@mail.gmail.com>
From: david.noveck@emc.com
To: iisaman@citi.umich.edu
X-OriginalArrivalTime: 22 Nov 2010 15:28:37.0303 (UTC) FILETIME=[EEC87C70:01CB8A59]
X-EMM-MHVC: 1
X-EMM-MFVC: 1
Cc: nfsv4@ietf.org
Subject: Re: [nfsv4] comparison of seqid
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/nfsv4>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Nov 2010 15:28:51 -0000

Trond wrote:
> I assume that it is just trying to say that comparisons need 
> to take into account the fact that seqids are defined modulo 
> NFS4_UINT32_MAX and so you need to beware when the wrap 
> around occurs. 

The point is that the sender is the only one who truly knows when wraparound occurs.  I was looking for some standard to define, from the receiver's point of view, when he should and should not presume that wraparound has occurred.  The fact that I made a mess of doing that doesn't mean that it isn't needed. 

Fred wrote:
> For seqid comparisons I've just been using a fixed window 
> size of 2**31.

Makes sense.  I'll draft a revised paragraph and send it to the working group, with the intention of dealing with this via the errata mechanism.



-----Original Message-----
From: faisaman4@gmail.com [mailto:faisaman4@gmail.com] On Behalf Of Fred Isaman
Sent: Monday, November 22, 2010 9:50 AM
To: Noveck, David
Cc: Guo, Albert; nfsv4@ietf.org
Subject: Re: [nfsv4] comparison of seqid

Note as Trond hints at, the paragraph also assumes that the sequence
id window is somehow related to the number of slots (max number of
outstanding RPCs).  This is not true at all.  Take the simple case of
two slots.  The reply in slot 1 gets delayed on the wire for a bit,
while we process 2 or 3 RPCs on slot 2.  When we finally see the reply
on slot 1, it will be out of the seqid window described, despite there
only being two outstanding RPCs at a time.  For seqid comparisons I've
just been using a fixed window size of 2**31.

Fred

On Mon, Nov 22, 2010 at 9:28 AM,  <david.noveck@emc.com> wrote:
> Bug.  Simplest fix is to swap "former" and "latter".
>
> Thanks.
> ________________________________
> From: nfsv4-bounces@ietf.org [mailto:nfsv4-bounces@ietf.org] On Behalf Of
> albert.guo@emc.com
> Sent: Monday, November 22, 2010 8:05 AM
> To: nfsv4@ietf.org
> Subject: [nfsv4] comparison of seqid
>
> Hi, all
>
> On page 161 of RFC 5661, I found the following description about comparison
> of seqid:
>
> "In making comparisons between seqids, both by the client in
>
> determining the order of operations and by the server in determining
>
> whether the NFS4ERR_OLD_STATEID is to be returned, the possibility of
>
> the seqid being swapped around past the NFS4_UINT32_MAX value needs
>
> to be taken into account. When two seqid values are being compared,
>
> the total count of slots for all sessions associated with the current
>
> client is used to do this. When one seqid value is less than this
>
> total slot count and another seqid value is greater than
>
> NFS4_UINT32_MAX minus the total slot count, the former is to be
>
> treated as lower than the latter, despite the fact that it is
>
> numerically greater."
>
> It looks to me the last sentence expresses a contrary meaning.
>
> the "lower than" should be "higher than"
>
> the "greater" should be "smaller"
>
>
>
> Is it my misunderstanding or a bug in the spec?
>
>
>
>
>
> --
>
> Albert
>
>
>
> _______________________________________________
> nfsv4 mailing list
> nfsv4@ietf.org
> https://www.ietf.org/mailman/listinfo/nfsv4
>
>