From nobody Thu Apr 6 11:21:35 2023 Return-Path: X-Original-To: nfsv4@ietfa.amsl.com Delivered-To: nfsv4@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6BD99C152A34 for ; Thu, 6 Apr 2023 11:21:34 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -2.097 X-Spam-Level: X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dBXvMtL_inXh for ; Thu, 6 Apr 2023 11:21:29 -0700 (PDT) Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12753C152A11 for ; Thu, 6 Apr 2023 11:21:29 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id nh20-20020a17090b365400b0024496d637e1so2453861pjb.5 for ; Thu, 06 Apr 2023 11:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680805288; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=4SdWjPunJ4o5FtKx6mGGWnWZzqjYcsaKQ6SfE6d8Kdk=; b=iNK9qO8MDb7+2W0OZ2gZf/UK/4lkaS8a0JDPaO0yMs93VWr856UvjnPQxvcuEEckKz G9Ogt+VnRCaIkd0JFEHJxzcEBXOrevvss+LRNCUWUdH1zf1hLvWLx+tl67N6D+3pQ8nc YM71SGa860ng/nDQca/1p/bisz3J0u1EbijzszNLn8y+gX6eOmhyCLZ9u8agCwEgJxku JmxI6P9J+rRp9pfdiYAtUXx0TrkDjnF567E1TzstAR+BkCaCh4Xeyjh6phAON4N1qxZw aNcL+BAZXjaC0GlUFkBXbKU4TQqyc3V9GIzdHEy/g6oW4hCqDX0rzcUZLJ1IYL3QzNRI JveQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680805288; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4SdWjPunJ4o5FtKx6mGGWnWZzqjYcsaKQ6SfE6d8Kdk=; b=tKYDuhNnp9zTasrDMDGzz881m/CBjg3wEjYPPtENk5j5fVjppgtICFpoSLeQE1Eh0E meIpHX74EDgBLe+f4VkNNURrlxeUBwcukog6xXNk0wXQA4gKZYx++m1pjh1dFJvrwmmD 3LCfx2QYII2vaR7uCH+wm9Gqpcoz0IWDwbIVj33s14Yk1yc7sqKhbGZ65xfS7X5Q8Dz8 4pqvHp55WDQylciUIDNEmdOQ/Varj+CAk2CYWbiYBlg4JFgHUKlr8uUEry+h2dWAdHbT oGI5k22FmGGFK0VamUipmnWSJWarn0OU3AAPcKdKm9TGDBjoWTaK4yn/NjvE2iXjMysS ftyg== X-Gm-Message-State: AAQBX9cOetvoVzk5eszmvbbOujl+1e2xjR9C3VdjS797k+nW7BlMF/tZ eFSAhGfXzB1/hXnOXrN9c+cinFP14Qo= X-Google-Smtp-Source: AKy350aDOmEFGaN47nD5oxVoh9Tacob982viUnaN20CtmkxkcaLI9KTH1amfkOsOSSf4YyMojtTj7w== X-Received: by 2002:a17:90a:fd94:b0:237:c52f:a54d with SMTP id cx20-20020a17090afd9400b00237c52fa54dmr7214938pjb.21.1680805288324; Thu, 06 Apr 2023 11:21:28 -0700 (PDT) Received: from smtpclient.apple (c-69-181-124-201.hsd1.ca.comcast.net. [69.181.124.201]) by smtp.gmail.com with ESMTPSA id u4-20020a17090a518400b00244921f2bebsm1601912pjh.23.2023.04.06.11.21.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2023 11:21:27 -0700 (PDT) From: Thomas Haynes Message-Id: <1AB95055-FF3B-44FA-9765-04F46104950E@gmail.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_FCBC9EE5-E715-4E85-A753-23D276A6B797" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Date: Thu, 6 Apr 2023 11:21:15 -0700 In-Reply-To: <1865e73c249a4a048b3c189420e7aa22@huawei.com> Cc: "nfsv4@ietf.org" To: "yangjing (U)" References: <1865e73c249a4a048b3c189420e7aa22@huawei.com> X-Mailer: Apple Mail (2.3731.400.51.1.1) Archived-At: Subject: Re: [nfsv4] draft-mzhang-nfsv4-sequence-id-calibration-01 X-BeenThere: nfsv4@ietf.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: NFSv4 Working Group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2023 18:21:34 -0000 --Apple-Mail=_FCBC9EE5-E715-4E85-A753-23D276A6B797 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Some nits on draft-mzhang-nfsv4-sequence-id-calibration-01: 1) Please mark the Operation numbers as needing assignment before = publication. BTW: You can look at https://github.com/loghyr/nfsv42_xdr for an = unofficial copy of the current XDR. 2) In the ARGUMENTS sections, when you have things like: struct SEQUENCE_QUERY4args { sessionid4 sqa_sessionid; slotid4 sqa_slotid; }; Please fix these up like this example from my delstid: Please follow the convention of allowing the XDR to be stripped out by = parsing the =E2=80=98///=E2=80=98 3) For the Requirements Language, please use the bcp14 tag =E2=80=9CMUST=E2=80=9D -> "MUST=E2=80=9D Note: You need to use this tag every place you use the keywords. --Apple-Mail=_FCBC9EE5-E715-4E85-A753-23D276A6B797 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8


Some nits = on draft-mzhang-nfsv4-sequence-id-calibration-01:

1) Please mark the Operation numbers as needing assignment before = publication.

BTW: You can look at https://github.com/loghyr/nf= sv42_xdr for an unofficial copy of the current = XDR.


2) In the ARGUMENTS = sections, when you have things like:

struct SEQUENCE_QUERY4args {

   sessionid4 sqa_sessionid;

   slotid4 sqa_slotid;

   };

Please fix = these up like this example from my = delstid:

    <sourcecode = name=3D"" type=3D"" = markers=3D"true"><![CDATA[
///
/// = /*
///  * attributes for the delegation times = being
///  * cached and served by the = "client"
///  */
/// typedef nfstime4   =      fattr4_time_deleg_access;
/// typedef = nfstime4       =  fattr4_time_deleg_modify;
///
 ]]>
=
    </sourcecode>

Please = follow the convention of allowing the XDR to be stripped out by parsing = the =E2=80=98///=E2=80=98


3)= For the Requirements Language, please use the bcp14 = tag

=E2=80=9CMUST=E2=80=9D = -> "<bcp14>MUST</bcp14>=E2=80=9D

<= div>Note: You need to use this tag every place you use the = keywords.





= --Apple-Mail=_FCBC9EE5-E715-4E85-A753-23D276A6B797--