Re: [nfsv4] Suresh Krishnan's No Objection on draft-ietf-nfsv4-rpcrdma-cm-pvt-data-07: (with COMMENT)

Chuck Lever <chuck.lever@oracle.com> Thu, 20 February 2020 14:01 UTC

Return-Path: <chuck.lever@oracle.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 683A1120890; Thu, 20 Feb 2020 06:01:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.3
X-Spam-Level:
X-Spam-Status: No, score=-4.3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=oracle.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GX611o0_8mdx; Thu, 20 Feb 2020 06:01:11 -0800 (PST)
Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 151AA1208BB; Thu, 20 Feb 2020 06:01:11 -0800 (PST)
Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01KDxbZ2141268; Thu, 20 Feb 2020 14:01:10 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=QP2QTt9EEc+CSSXUtwQQxoKN7o6ZqzpCPDZ1DuO5SRQ=; b=t32grJ53rRwhHT/+kr1Uz5p+glLK4sGhyiONm29BIDYJrQeQOaXfo7qKw59ZGrdYwxjH 8wNKLosFIX33Jr4J15VogpTymFnI+YYCCeZ1p5MP+zxRD0BUR7j57ODGYieqq5CSnr7M 9+DllHM8Yt9ljfrplGELULnlvVKcubv6fdfALeIabg15Pu554bApaabIg9FGdPbdmcDz 4FC/aAYx6kEgFxRDzc6CMSG5C50mgs2uL1W5reserfNNjs/PZbZ7wCzMkMuVBGfX07nt +ybREUSRrNH6OXPtXYjekGPPhlSB2jvJClKCsQQchJDlvHhWKkqjGP2a0MERrA5MEo4w AA==
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2y8udkhvt4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Feb 2020 14:01:10 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01KDvwrD192510; Thu, 20 Feb 2020 13:59:09 GMT
Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2y8ud61ueq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 20 Feb 2020 13:59:09 +0000
Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 01KDx7uD028866; Thu, 20 Feb 2020 13:59:07 GMT
Received: from anon-dhcp-153.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 20 Feb 2020 05:59:07 -0800
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <0EDBFDE0-95BC-41D1-B032-D271EDF62492@kaloom.com>
Date: Thu, 20 Feb 2020 08:59:06 -0500
Cc: Benjamin Kaduk <kaduk@mit.edu>, "nfsv4@ietf.org" <nfsv4@ietf.org>, "nfsv4-chairs@ietf.org" <nfsv4-chairs@ietf.org>, "draft-ietf-nfsv4-rpcrdma-cm-pvt-data@ietf.org" <draft-ietf-nfsv4-rpcrdma-cm-pvt-data@ietf.org>, The IESG <iesg@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7BC7C652-3205-4D56-9AE2-469D314870AB@oracle.com>
References: <158216848908.17754.6609131313720933956.idtracker@ietfa.amsl.com> <20200220040540.GA97652@kduck.mit.edu> <0EDBFDE0-95BC-41D1-B032-D271EDF62492@kaloom.com>
To: Suresh Krishnan <Suresh@kaloom.com>
X-Mailer: Apple Mail (2.3445.104.11)
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9536 signatures=668685
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002200106
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9536 signatures=668685
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 mlxscore=0 clxscore=1011 malwarescore=0 mlxlogscore=999 phishscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002200106
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/2eZ2kAvxE4bqGh6EruKrlF1z7p4>
Subject: Re: [nfsv4] Suresh Krishnan's No Objection on draft-ietf-nfsv4-rpcrdma-cm-pvt-data-07: (with COMMENT)
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Feb 2020 14:01:18 -0000


> On Feb 19, 2020, at 11:42 PM, Suresh Krishnan <Suresh@kaloom.com> wrote:
> 
> Hi Ben,
> 
>> On Feb 19, 2020, at 11:05 PM, Benjamin Kaduk <kaduk@mit.edu> wrote:
>> 
>> On Wed, Feb 19, 2020 at 07:14:49PM -0800, Suresh Krishnan via Datatracker wrote:
>>> Suresh Krishnan has entered the following ballot position for
>>> draft-ietf-nfsv4-rpcrdma-cm-pvt-data-07: No Objection
>>> 
>>> When responding, please keep the subject line intact and reply to all
>>> email addresses included in the To and CC lines. (Feel free to cut this
>>> introductory paragraph, however.)
>>> 
>>> 
>>> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
>>> for more information about IESG DISCUSS and COMMENT positions.
>>> 
>>> 
>>> The document, along with other ballot positions, can be found here:
>>> https://datatracker.ietf.org/doc/draft-ietf-nfsv4-rpcrdma-cm-pvt-data/
>>> 
>>> 
>>> 
>>> ----------------------------------------------------------------------
>>> COMMENT:
>>> ----------------------------------------------------------------------
>>> 
>>> I would like to see a resolution of Barry's DISCUSS as well. In addition if you
>>> are using division by 1024, I think the appropriate range needs to be
>>> 1KiB-256KiB instead of 1KB-256KB as defined in the draft.
>> 
>> I'm not sure there's really much of an issue there; the stated procedure
>> (round-tripping through the encoding and decoding processes) seems to have
>> the effect of rounding down to the next multiple of 1024 bytes, which might
>> waste a little space but should produce safe operation.  Furthermore, it
>> can't reduce the buffer size below the current default value.
> 
>> 
>> (That said, I don't object to the diff that was proposed in response to
>> Barry.)
> 
> The range of possible values is still off in the -07 draft but I checked the -latest diff posted by Chuck and it seems to have updated the range to read "1024 to 262144 octets” which matches my suggestion for 1KiB-256KiB. So consider me satisfied :-).

Suresh, thanks for having a look at the Editor's copy, and thanks for your
comment! I was uncertain about exactly how to spell out the size range.


--
Chuck Lever