Re: [nfsv4] draft-ietf-nfsv4-umask

spencer shepler <spencer.shepler@gmail.com> Wed, 23 August 2017 23:24 UTC

Return-Path: <spencer.shepler@gmail.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 70D7E1326A0 for <nfsv4@ietfa.amsl.com>; Wed, 23 Aug 2017 16:24:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hYXV0g-27b2E for <nfsv4@ietfa.amsl.com>; Wed, 23 Aug 2017 16:24:48 -0700 (PDT)
Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 172B4132959 for <nfsv4@ietf.org>; Wed, 23 Aug 2017 16:24:47 -0700 (PDT)
Received: by mail-oi0-x231.google.com with SMTP id j144so15855937oib.1 for <nfsv4@ietf.org>; Wed, 23 Aug 2017 16:24:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=z2+kULW35UyHaxaHbVLt37lqGP4SCdsLhPVuLy/KuWE=; b=jcgcvj7czuOFobWlsu83eKBleEFvpSrLzvuuEBfjfAY83q88x3txfu0H8d+wBv43kV eiRT1Ql6cq5TtNbaKVPtKH9uE0Wh2gKE41mp83oxIb5bjdMKSyhncxmpmNh3E0X5NXbW dkKWPDqdwUB2hLliCisDGa6oSrQLZnTbLPeTxhjorju9i3t0U4jrpnWSjbJ65vYEJ4dy n9ErDLNLYOEnNu/VH9tyuhrHeJA2AtIDHt1St91WHdKYAimP0Yn/gfoAMDHQIrxOM7kX 9SsSQU6iOymKF8n5mhmxf4CEtuX4VbdPKCFkNvjE9sUgIu9W3SI/RlggEAAsGVuxTaNt 40IA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=z2+kULW35UyHaxaHbVLt37lqGP4SCdsLhPVuLy/KuWE=; b=kLpJdbpBm50PEOIZbRprWNXCHfQOPztIw8/4FTfIU1kl9O5lc6TRgJZbp1YFUCXySC 6EzMCSAtEVgsPa7ohvoZXy5VWsCCUNI1XWhby16No2mhqm153nNHAdAlHFcipSWfclfU zjM5dGH0SRmtB98VVLQtuQGkAGpe3MogwXDsbVcjeyai/OLOUo6NUrcWUThBQzPhj/1S Sl/QGo6Z2C5dOpc1FHMV04gPqjkCf3swPdcFLod1AcCGaKkI3cG/hVjMPe/qa0l/eYZj B4OzaCVa2QtqAGpgL7MZBL1nD86iEqXLFFpfgNr/4yQdiCJBDMtATo7nq1YshEmX/i9H RX0A==
X-Gm-Message-State: AHYfb5ggHRjWIjeqRvv944lM6ya2FzaiCxxSCrBDmFSuODxylB00UY1P hVOn5E9cCBsIYvtfT0Ypaj2KjSb0kw==
X-Received: by 10.202.214.141 with SMTP id n135mr5526126oig.214.1503530686524; Wed, 23 Aug 2017 16:24:46 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.74.137.213 with HTTP; Wed, 23 Aug 2017 16:24:46 -0700 (PDT)
In-Reply-To: <20170823155536.GA10035@fieldses.org>
References: <CCE6471D-5252-4313-BDED-5EAA468E3FAA@primarydata.com> <20170823155536.GA10035@fieldses.org>
From: spencer shepler <spencer.shepler@gmail.com>
Date: Wed, 23 Aug 2017 16:24:46 -0700
Message-ID: <CAFt6Ba=Ab=TLURRJ9ULdmU_8FydkeijfoHpgzd1bBTtx6YcBHQ@mail.gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Thomas Haynes <loghyr@primarydata.com>, "nfsv4@ietf.org" <nfsv4@ietf.org>
Content-Type: multipart/alternative; boundary="001a113b02827ab3ed05577404c6"
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/3cGjw3QAy5byo-dyhHCe4_7dlgs>
Subject: Re: [nfsv4] draft-ietf-nfsv4-umask
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Aug 2017 23:24:50 -0000

We need to close on this (if there is going to be a change or not).. This
document is technically in AUTH48 period - we can make the changes but need
to know what they are and hear any objections (as has been queried for
Manoj's changes).

Tom?

Spencer

On Wed, Aug 23, 2017 at 8:55 AM, J. Bruce Fields <bfields@fieldses.org>
wrote:

> On Tue, Aug 22, 2017 at 08:36:38PM +0000, Thomas Haynes wrote:
> > Hi Bruce,
> >
> > Can you modify your draft such that it generates xdr?
>
> I considered that but it seemed like a lot of boilerplate for little
> return.  The code to extract the xdr might almost be longer than the xdr
> you're extracting.  I dunno.
>
> >
> > I.e., I went to add a new const for your new attribute, and unlike the
> xattr document, I had to guess:
>
> You didn't have to guess the number, just the constant name, right?  I'm
> not sure how much that matters.
>
> --b.
>
> > %/*
> > % * New For UMASK
> > % */
> > const FATTR4_MODE_UMASK         = 81;
> >
> > Iā€™d recommend that you add the ā€˜///ā€˜.
> >
> > Also, you should use the <CODE BEGINS> and <CODE ENDS> at the very least
> here:
> >
> > 4.  mode_umask Attribute
> >
> >
> >          struct mode_umask4 {
> >            mode4  mu_mode;
> >            mode4  mu_umask;
> >          };
>
> _______________________________________________
> nfsv4 mailing list
> nfsv4@ietf.org
> https://www.ietf.org/mailman/listinfo/nfsv4
>