Re: [nfsv4] More layout stuff: layout return on close
Trond Myklebust <Trond.Myklebust@netapp.com> Sun, 28 November 2010 18:26 UTC
Return-Path: <Trond.Myklebust@netapp.com>
X-Original-To: nfsv4@core3.amsl.com
Delivered-To: nfsv4@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id A0BD728C0DE for <nfsv4@core3.amsl.com>; Sun, 28 Nov 2010 10:26:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qLYHxTCWF9HE for <nfsv4@core3.amsl.com>; Sun, 28 Nov 2010 10:26:23 -0800 (PST)
Received: from mx2.netapp.com (mx2.netapp.com [216.240.18.37]) by core3.amsl.com (Postfix) with ESMTP id 2CEBE28C0CF for <nfsv4@ietf.org>; Sun, 28 Nov 2010 10:26:23 -0800 (PST)
X-IronPort-AV: E=Sophos;i="4.59,271,1288594800"; d="scan'208";a="488159325"
Received: from smtp1.corp.netapp.com ([10.57.156.124]) by mx2-out.netapp.com with ESMTP; 28 Nov 2010 10:27:29 -0800
Received: from svlrsexc1-prd.hq.netapp.com (svlrsexc1-prd.hq.netapp.com [10.57.115.30]) by smtp1.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id oASIRTPi009016; Sun, 28 Nov 2010 10:27:29 -0800 (PST)
Received: from SACMVEXC2-PRD.hq.netapp.com ([10.99.115.17]) by svlrsexc1-prd.hq.netapp.com with Microsoft SMTPSVC(6.0.3790.3959); Sun, 28 Nov 2010 10:27:29 -0800
Received: from 10.58.56.230 ([10.58.56.230]) by SACMVEXC2-PRD.hq.netapp.com ([10.99.115.16]) with Microsoft Exchange Server HTTP-DAV ; Sun, 28 Nov 2010 18:27:28 +0000
Received: from heimdal.trondhjem.org by SACMVEXC2-PRD.hq.netapp.com; 28 Nov 2010 13:27:28 -0500
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Benny Halevy <bhalevy@panasas.com>
In-Reply-To: <4CF25270.5050609@panasas.com>
References: <1290552459.30508.4.camel@heimdal.trondhjem.org> <4CECC382.5020207@panasas.com> <4CECE104.5080009@desy.de> <1290610592.3234.20.camel@heimdal.trondhjem.org><4CEE283D.5040903@desy.de> <1290692948.2911.7.camel@heimdal.trondhjem.org> <4CEE8AA9.1030109@desy.de> <BF3BB6D12298F54B89C8DCC1E4073D8002A5F2B6@CORPUSMX50A.corp.emc.com> <4CF25270.5050609@panasas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Organization: NetApp Inc
Date: Sun, 28 Nov 2010 13:27:27 -0500
Message-ID: <1290968847.12027.6.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 (2.32.1-1.fc14)
X-OriginalArrivalTime: 28 Nov 2010 18:27:29.0128 (UTC) FILETIME=[E9ED8680:01CB8F29]
Cc: nfsv4@ietf.org
Subject: Re: [nfsv4] More layout stuff: layout return on close
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/nfsv4>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Nov 2010 18:26:28 -0000
On Sun, 2010-11-28 at 15:00 +0200, Benny Halevy wrote: > Re-thinking the resolution of this implicit return of the layout > and its interaction with other layout state-changing operations; > since CLOSE does not return a layout stateid, like LAYOUTRETURN, > it would be useful only to return the whole file layout, and not just > the segments marked with return_on_close. Otherwise, what would be > the layout stateid post CLOSE, and how will the client order this > state change with other in-flight LAYOUTGETs and/or LAYOUTRETURNs. Err.... In what way does this differ from the client returning NFS4ERR_NOMATCHING_LAYOUT to CB_LAYOUTRECALL? The spec allows the client to do so in the case where it holds no layout segments that overlap with the layout recall argument. In that case the server just updates its idea of what the layout looks like without changing the stateid. > So I suggest we make the implicit layout return an equivalent of: > > lora_reclaim == false (let's say that during the grace period the > client must used LAYOUTRETURN with lora_reclaim == true) > lora_layout_type == good question. I'm inclined towards defining it > as a wildcard, i.e. all layout_types from which the client got a layout > for this file. > lora_iomode == LAYOUTIOMODE4_ANY > lr_returntype == LAYOUTRETURN4_FILE > lrf_offset == 0 > lrf_length == NFS4_MAXFILELEN > lrf_stateid == the most recent layout stateid provided by the server > empty lrf_body > > The implicit successful result is equivalent to > lrs_present == false > and any outstanding LAYOUTGETs and LAYOUTRETURNs, sent before CLOSE > MUST be drained and ignored by the client. > Any new layout operation MUST be issued after re-opening the file > and obtaining a new open, lock, or delegation stateid. > > In addition, the following error codes that are currently applicable > for LAYOUTRETURN and not for CLOSE need to be added to CLOSE: > NFS4ERR_DELEG_REVOKED > NFS4ERR_GRACE That seems unnecessary. If your client cares about updating the stateid (why would it?) then send the LAYOUTRETURN before the CLOSE, if not, dont, and just forget the segments that were marked as return-on-close. Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com
- [nfsv4] More layout stuff: layout return on close Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Tigran Mkrtchyan
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Tigran Mkrtchyan
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Tigran Mkrtchyan
- Re: [nfsv4] More layout stuff: layout return on c… david.noveck
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Sorin Faibish
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Sorin Faibish
- Re: [nfsv4] More layout stuff: layout return on c… david.noveck
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… david.noveck
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… david.noveck
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… david.noveck
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… david.noveck
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Fred Isaman
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… david.noveck
- Re: [nfsv4] More layout stuff: layout return on c… Spencer Shepler
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust
- Re: [nfsv4] More layout stuff: layout return on c… Benny Halevy
- Re: [nfsv4] More layout stuff: layout return on c… Trond Myklebust