Re: [nfsv4] [Gen-art] Genart last call review of draft-ietf-nfsv4-flex-files-15

Alissa Cooper <alissa@cooperw.in> Wed, 24 January 2018 15:35 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8C2D126C22; Wed, 24 Jan 2018 07:35:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.721
X-Spam-Level:
X-Spam-Status: No, score=-2.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=OPVY+l2T; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=glxTzg6w
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4KaeifkW33D8; Wed, 24 Jan 2018 07:35:21 -0800 (PST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E9CD126C26; Wed, 24 Jan 2018 07:35:21 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E0CEA223C5; Wed, 24 Jan 2018 10:35:20 -0500 (EST)
Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Wed, 24 Jan 2018 10:35:20 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=cComYHfkAsCXZfNzwo099qVZFnVyG R7pcs4H+er9beE=; b=OPVY+l2T0SSgceNYI5GXiAUDfxmsxssI2OVuzEBf6ynlq sTX3gFyagZMaeVD79PDGrqLj1aFVQ4M/0C0VW9FXmMInMz8TETbMXc8EYwErUZ/A XVsHMzGZ0fN2bNuNKKYy1p+HNkNcvT2xOpYYLiaBVI4yO7duFoxVBqxpeTcJtDe2 NfGzRb9hHkC0Y2bjXo6E73HWWx2QBMdkyWUdmPW97CMAuTeVYQYcDAFWU88TFqzQ l64I73pph0BAewvqNVKS62ShX2f+acHgESIv9K6K0NzdStYmUKAmRg1inIOGU5jL 8gbmuAInJyB7EobBY8lN9X1pDwV8etPNP/upcQM6Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cComYH fkAsCXZfNzwo099qVZFnVyGR7pcs4H+er9beE=; b=glxTzg6wfQLXfETPT/eZ30 dlZFtfvraYAt25zyZY/lZRLn/GX9jq7T8AYK6LyuQSRI58rhwFIuDqCqsKwOHy5n nx76vPXM5ymsw/lCXP4GghvYxe9R3+E5FfAn0QvWWLrf5Hcs5IXYjuS22mwl5sdq mN2k4Rq2ZAV0zqFUCtBWupulo8Zt2R2lFIvaGjmmotCLeyCpUb20KRAr7y5pum08 zk45ESdZHNbX0GTGJpKj1IfCZqkjtDkw1VrU8vk+C7b0IzK3R20ZCwmleSh6+/0G ICWWx4UH4Zy6337YRVNxSabqG+Xub44KDAanH0WuFh3VTpiG76/oTGN3wpHFDG9Q ==
X-ME-Sender: <xms:uKdoWuTUX3F2oYwu9wbZIbpO4UTFEQRx9sHV_uvgFgJPpNzp_nJ-pQ>
Received: from [10.19.234.245] (unknown [128.107.241.186]) by mail.messagingengine.com (Postfix) with ESMTPA id C6E40240F8; Wed, 24 Jan 2018 10:35:19 -0500 (EST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <151385190310.12830.12244028318485947459@ietfa.amsl.com>
Date: Wed, 24 Jan 2018 10:35:18 -0500
Cc: gen-art <gen-art@ietf.org>, draft-ietf-nfsv4-flex-files.all@ietf.org, nfsv4@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <B7AA2C27-E52F-4AC6-BECD-C8515EB76F30@cooperw.in>
References: <151385190310.12830.12244028318485947459@ietfa.amsl.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/KCNljAlMSsZ7g7LlHCXWScFLdm8>
Subject: Re: [nfsv4] [Gen-art] Genart last call review of draft-ietf-nfsv4-flex-files-15
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jan 2018 15:35:24 -0000

Christer, thanks for your review. Authors, thanks for your responses. I have entered a No Objection ballot.

Alissa


> On Dec 21, 2017, at 5:25 AM, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
> 
> Reviewer: Christer Holmberg
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-nfsv4-flex-files-15
> Reviewer: Christer Holmberg
> Review Date: 2017-12-21
> IETF LC End Date: 2018-01-16
> IESG Telechat date: 2018-01-25
> 
> Summary: The document is well written, and almost ready for publication.
> However, I think some additional text is needed, as described below.
> 
> Major issues: None.
> 
> Minor issues: None:
> 
> Nits/editorial comments:
> 
> Q1:
> 
> The Abstract says:
> 
>   "The flexible file layout type is defined in this
>   document as an extension to pNFS which allows the use of storage
>   devices in a fashion such that they require only a quite limited
>   degree of interaction with the metadata server, using already
>   existing protocols."
> 
> …and the Introduction says:
> 
>   "There are different layout types for different storage
>   systems and methods of arranging data on storage devices.  This
>   document defines the flexible file layout type used with file-based
>   data servers that are accessed using the Network File System (NFS)
>   protocols: NFSv3 [RFC1813], NFSv4.0 [RFC7530], NFSv4.1 [RFC5661], and
>   NFSv4.2 [RFC7862].”
> 
> But, there is no text about the existing file layout type, and how this file
> layout types will improve things. The Abstract mentions impacts on the
> interactions with the metadata server, but there is no text about that in the
> Introduction. I think a few sentences in the Introduction, describing the
> high-level advantages and changes that the flexible file layout type brings,
> would be good.
> 
> Also, the Abstract mentions client mirroring, but there is nothing about that
> in the Introduction.
> 
> Q2:
> 
> Is section 2 specific to the flexible file layout type, or is it about pNFS in
> general? I think it would good to have a sentence describing the scope of the
> section.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art