IETF Logo Mail Archive

[nfsv4] Re: question about delegated timestamps (delstid draft)

Thomas Haynes <loghyr@gmail.com> Wed, 28 August 2024 22:34 UTC

Return-Path: <loghyr@gmail.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A7881C151063; Wed, 28 Aug 2024 15:34:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.109
X-Spam-Level:
X-Spam-Status: No, score=-2.109 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id opMbhlEJPZvO; Wed, 28 Aug 2024 15:34:53 -0700 (PDT)
Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4886BC14F700; Wed, 28 Aug 2024 15:34:53 -0700 (PDT)
Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-714262f1bb4so35385b3a.3; Wed, 28 Aug 2024 15:34:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724884492; x=1725489292; darn=ietf.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FgdYGtU/u6uA4C9o2PUFgJqTqEn/izvqsTDXuJVLRVY=; b=EahMDGVYjS2UpVX6x+C+ADVlqUin+uCQ6oV0ou4WjgqeXgpfZOE905QUQmsvrzGbFq d2+Dq9CPA1rE1XosxM/9WhFCHZQV51Iy+DPUxZB/QulTFClLIIvneZ5GO+oLxBfWdl1y GWNwQOY1vi8oeZ+jBysN/WrYNJzZybbWQjKfvKH7hRErCx+pxkb9KUjHpWs03DTiFfJf w/XleA7ba0JU8o//y2ZlKlmLfPYxJAX1E2C2R/HkBeAwUpK4FFMP/lO/NHwMfzFSrxt/ Ky27aPwNV4eI+AvOUVUygoysPnHvrhQm4xaqaTBuiTr6XmNE53x+wqFEQsWR/oALiZOF tDBA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724884492; x=1725489292; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FgdYGtU/u6uA4C9o2PUFgJqTqEn/izvqsTDXuJVLRVY=; b=DMQtpC5+ve9wSYRZQjyMQt8NqMAazCshjM0aDdE/aFxo022fJaiez7F4tTQFBQ22jG +ZuZoalLg3trKtTKY4HUD6RGv4Me4i9wFWeTaurSaqAZENN+r+1SKYPK4y3mI/S1zrt1 o7KL3wgZfbuy8eFr3CU0C5pMQZ6mjw4WpqgEmwwL256+MKFwCnqTa2zntfjfgBlC4XN6 oJQ7DhaNc4PSB0QtfQ1htf9N+eD2ZOsHEvlVGjDakmhgbpp2eHIckAXX73nhAuA/mIet K1Mnj2NiA2ZTV//sMq+wxLlk90FnYrokrAiw9up9zRgUmpWF2U+AZYfJ8BCcOfhZGsYx Qecg==
X-Forwarded-Encrypted: i=1; AJvYcCUMi7fqcf7ACy7xQrkfEJ6AClm+R3hBD22MNyt77pSylYRYd000Tpl/Ex3c4r6sZdyw+tH91Q==@ietf.org
X-Gm-Message-State: AOJu0YyWuKFiP2rEpDY4sm79RTZOsB4u7ohtAAGwPIwnuxd9Mu2tkmSU tqJXDA2JOkMYIeHiF7OTE541FuRJtP4otyhKNw5TPR3C54+wED+ci4xGCw==
X-Google-Smtp-Source: AGHT+IGiy336QontMXH2RdN+b2L3orbDK3IAQzm6m/B+BM5FkkYnqIILNC1v6ILv1ZuN/cV3ouQX5w==
X-Received: by 2002:a05:6a00:85aa:b0:714:37ca:ed72 with SMTP id d2e1a72fcca58-715dfbb6f5fmr1046175b3a.10.1724884492262; Wed, 28 Aug 2024 15:34:52 -0700 (PDT)
Received: from smtpclient.apple ([2601:647:4500:91:f8e4:fd02:3bb0:f4f9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-714342e0a28sm10586353b3a.116.2024.08.28.15.34.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Aug 2024 15:34:51 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\))
From: Thomas Haynes <loghyr@gmail.com>
In-Reply-To: <0fc24e8a75423febc31cf373db995deb99b47a7b.camel@poochiereds.net>
Date: Wed, 28 Aug 2024 15:34:39 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <F784F7B7-AECE-40BE-97EE-17D5F8BB22CC@gmail.com>
References: <0fc24e8a75423febc31cf373db995deb99b47a7b.camel@poochiereds.net>
To: Jeff Layton <jlayton@poochiereds.net>
X-Mailer: Apple Mail (2.3776.700.51)
Message-ID-Hash: SP2PNKQXO3UN2WCEQPHEU4UCJV2TJ6AJ
X-Message-ID-Hash: SP2PNKQXO3UN2WCEQPHEU4UCJV2TJ6AJ
X-MailFrom: loghyr@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-nfsv4.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-nfsv4-delstid.all@ietf.org, NFSv4 <nfsv4@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [nfsv4] Re: question about delegated timestamps (delstid draft)
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/KSGxv4g7ZBHU4xLjRddCEaVNU8Y>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Owner: <mailto:nfsv4-owner@ietf.org>
List-Post: <mailto:nfsv4@ietf.org>
List-Subscribe: <mailto:nfsv4-join@ietf.org>
List-Unsubscribe: <mailto:nfsv4-leave@ietf.org>


> On Aug 28, 2024, at 10:13 AM, Jeff Layton <jlayton@poochiereds.net> wrote:
> 
> The draft says mentions this:
> 
>   Further, when it gets a SETATTR in the same compound as the
>   DELEGRETURN, then it MUST accept those fattr4_time_deleg_access
>   attribute and fattr4_time_deleg_modify attribute changes and derive
>   the change time or reject the changes with NFS4ERR_DELAY (see
>   Section 15.1.1.3 of [RFC8881]).
> 
> Presumably, the SETATTR will precede the DELEGRETURN in the compound,
> in which case (at least under Linux kernel server) we will not have
> vetted the DELEGRETURN stateid yet.
> 
> The simplest fix might be to just have it accept SETATTR for the
> delegated atime and mtime iff the client is the owner of the write
> delegation.
> -- 
> Jeff Layton <jlayton@poochiereds.net>


Looking at the HS implementation, we do just that, we accept it if the client is the owner of the WRITE delegation.

I.e., we do not insist that there is a DELEGRETURN.

v2.35.0 | Report a Bug | By Email | System Status