Re: [nfsv4] draft-ietf-nfsv4-umask

Thomas Haynes <loghyr@primarydata.com> Wed, 23 August 2017 23:46 UTC

Return-Path: <loghyr@primarydata.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA563132377 for <nfsv4@ietfa.amsl.com>; Wed, 23 Aug 2017 16:46:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=primarydata.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bOOhmIpIYUvY for <nfsv4@ietfa.amsl.com>; Wed, 23 Aug 2017 16:46:50 -0700 (PDT)
Received: from us-smtp-delivery-194.mimecast.com (us-smtp-delivery-194.mimecast.com [216.205.24.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 89C0F132A87 for <nfsv4@ietf.org>; Wed, 23 Aug 2017 16:46:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=primarydata.com; s=mimecast20170802; t=1503532009; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references; bh=Qyy9S0Rlrht9k9cpAtVJKQJVeyoT7gb9I9w4Gg2uY20=; b=Bprwa/ngY7iHB39rquxzIWZfwGGSbigi4D+LbgaOzQZTd0v1rzYPRD9H9BDq18bCMrzHedlzOZXC1SqPx065v8TTSMFf24ir5DWqHaoxSnOJDhXvNIFY3qwwUOEsunob04DtptYXokWHAVZ5DcyFOomy4xXY/UxxXzvj9GhCnqo=
Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01lp0182.outbound.protection.outlook.com [216.32.181.182]) (Using TLS) by us-smtp-1.mimecast.com with ESMTP id us-mta-189-HMNcW2yENz2a9nM9fnyZVw-1; Wed, 23 Aug 2017 19:46:47 -0400
Received: from BY2PR1101MB1093.namprd11.prod.outlook.com (10.164.166.21) by BY2PR1101MB1173.namprd11.prod.outlook.com (10.164.166.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Wed, 23 Aug 2017 23:46:44 +0000
Received: from BY2PR1101MB1093.namprd11.prod.outlook.com ([10.164.166.21]) by BY2PR1101MB1093.namprd11.prod.outlook.com ([10.164.166.21]) with mapi id 15.01.1362.019; Wed, 23 Aug 2017 23:46:44 +0000
From: Thomas Haynes <loghyr@primarydata.com>
To: Spencer Shepler <spencer.shepler@gmail.com>
CC: "J. Bruce Fields" <bfields@fieldses.org>, "nfsv4@ietf.org" <nfsv4@ietf.org>
Thread-Topic: [nfsv4] draft-ietf-nfsv4-umask
Thread-Index: AQHTG4Zb83Gzg43990+ATwJTE7ReQaKSGXcAgAB9fwCAAAYigA==
Date: Wed, 23 Aug 2017 23:46:44 +0000
Message-ID: <7824C7CB-FA68-4BC8-BF92-F93B37521B91@primarydata.com>
References: <CCE6471D-5252-4313-BDED-5EAA468E3FAA@primarydata.com> <20170823155536.GA10035@fieldses.org> <CAFt6Ba=Ab=TLURRJ9ULdmU_8FydkeijfoHpgzd1bBTtx6YcBHQ@mail.gmail.com>
In-Reply-To: <CAFt6Ba=Ab=TLURRJ9ULdmU_8FydkeijfoHpgzd1bBTtx6YcBHQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [63.157.6.18]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BY2PR1101MB1173; 20:BDvdrthp4o0yr1SMDDy1EV0bfEHZfxR/P4nkdxU3Nz/DRWwRfKwwyIlUA+M6my9sTVL3JfdFOGk4zySi1vq5CY2BmwQ553X6XBFolFNskjf/LYDuCNND5aBVWkhy3Do2o6B1ehMRsgy5E2t+J7CsIuLc7Quv3IPCfr05tPm6VsY=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: a9b5cc40-b283-41f1-0886-08d4ea8135ea
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(2017052603191)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR1101MB1173;
x-ms-traffictypediagnostic: BY2PR1101MB1173:
x-exchange-antispam-report-test: UriScan:;
x-microsoft-antispam-prvs: <BY2PR1101MB11731B1A2A43F07B56A95AFFCE850@BY2PR1101MB1173.namprd11.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6041248)(20161123560025)(2016111802025)(20161123558100)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR1101MB1173; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR1101MB1173;
x-forefront-prvs: 040866B734
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(199003)(377454003)(24454002)(189002)(966005)(189998001)(83716003)(2950100002)(106356001)(6246003)(6916009)(229853002)(97736004)(105586002)(36756003)(6506006)(6486002)(81156014)(6436002)(5660300001)(8936002)(8676002)(77096006)(7736002)(81166006)(25786009)(3660700001)(66066001)(3846002)(68736007)(6116002)(50986999)(33656002)(478600001)(86362001)(2900100001)(82746002)(110136004)(53936002)(14454004)(39060400002)(102836003)(606006)(76176999)(54356999)(6306002)(2906002)(53546010)(101416001)(6512007)(230783001)(3280700002)(99286003)(236005)(54906002)(4326008)(54896002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR1101MB1173; H:BY2PR1101MB1093.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
MIME-Version: 1.0
X-OriginatorOrg: primarydata.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2017 23:46:44.1043 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR1101MB1173
X-MC-Unique: HMNcW2yENz2a9nM9fnyZVw-1
Content-Type: multipart/alternative; boundary="_000_7824C7CBFA684BC8BF92F93B37521B91primarydatacom_"
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/KvqxJ3o7WHoBcvd4OksoArxlXVo>
Subject: Re: [nfsv4] draft-ietf-nfsv4-umask
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Aug 2017 23:46:53 -0000

On Aug 23, 2017, at 4:24 PM, spencer shepler <spencer.shepler@gmail.com<mailto:spencer.shepler@gmail.com>> wrote:


We need to close on this (if there is going to be a change or not).. This document is technically in AUTH48 period - we can make the changes but need to know what they are and hear any objections (as has been queried for Manoj's changes).

Tom?

While I would like it cleaner, I am fine without making a change.



Spencer

On Wed, Aug 23, 2017 at 8:55 AM, J. Bruce Fields <bfields@fieldses.org<mailto:bfields@fieldses.org>> wrote:
On Tue, Aug 22, 2017 at 08:36:38PM +0000, Thomas Haynes wrote:
> Hi Bruce,
>
> Can you modify your draft such that it generates xdr?

I considered that but it seemed like a lot of boilerplate for little
return.  The code to extract the xdr might almost be longer than the xdr
you're extracting.  I dunno.

>
> I.e., I went to add a new const for your new attribute, and unlike the xattr document, I had to guess:

You didn't have to guess the number, just the constant name, right?  I'm
not sure how much that matters.

--b.

> %/*
> % * New For UMASK
> % */
> const FATTR4_MODE_UMASK         = 81;
>
> Iā€™d recommend that you add the ā€˜///ā€˜.
>
> Also, you should use the <CODE BEGINS> and <CODE ENDS> at the very least here:
>
> 4.  mode_umask Attribute
>
>
>          struct mode_umask4 {
>            mode4  mu_mode;
>            mode4  mu_umask;
>          };

_______________________________________________
nfsv4 mailing list
nfsv4@ietf.org<mailto:nfsv4@ietf.org>
https://www.ietf.org/mailman/listinfo/nfsv4