Re: [nfsv4] More layout stuff: layout return on close

Trond Myklebust <Trond.Myklebust@netapp.com> Tue, 30 November 2010 15:19 UTC

Return-Path: <Trond.Myklebust@netapp.com>
X-Original-To: nfsv4@core3.amsl.com
Delivered-To: nfsv4@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 116483A6C7F for <nfsv4@core3.amsl.com>; Tue, 30 Nov 2010 07:19:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XgDqJRkpFquU for <nfsv4@core3.amsl.com>; Tue, 30 Nov 2010 07:19:09 -0800 (PST)
Received: from mx2.netapp.com (mx2.netapp.com [216.240.18.37]) by core3.amsl.com (Postfix) with ESMTP id 811813A6C17 for <nfsv4@ietf.org>; Tue, 30 Nov 2010 07:19:09 -0800 (PST)
X-IronPort-AV: E=Sophos;i="4.59,280,1288594800"; d="scan'208";a="488974141"
Received: from smtp1.corp.netapp.com ([10.57.156.124]) by mx2-out.netapp.com with ESMTP; 30 Nov 2010 07:20:20 -0800
Received: from sacrsexc2-prd.hq.netapp.com (sacrsexc2-prd.hq.netapp.com [10.99.115.28]) by smtp1.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id oAUFKKwZ015356; Tue, 30 Nov 2010 07:20:20 -0800 (PST)
Received: from SACMVEXC2-PRD.hq.netapp.com ([10.99.115.17]) by sacrsexc2-prd.hq.netapp.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 30 Nov 2010 07:20:20 -0800
Received: from 10.58.57.140 ([10.58.57.140]) by SACMVEXC2-PRD.hq.netapp.com ([10.99.115.16]) with Microsoft Exchange Server HTTP-DAV ; Tue, 30 Nov 2010 15:20:19 +0000
Received: from heimdal.trondhjem.org by SACMVEXC2-PRD.hq.netapp.com; 30 Nov 2010 10:20:18 -0500
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Benny Halevy <bhalevy@panasas.com>
In-Reply-To: <4CF514BA.50901@panasas.com>
References: <1290552459.30508.4.camel@heimdal.trondhjem.org> <4CECC382.5020207@panasas.com> <4CECE104.5080009@desy.de> <1290610592.3234.20.camel@heimdal.trondhjem.org><4CEE283D.5040903@desy.de> <1290692948.2911.7.camel@heimdal.trondhjem.org> <4CEE8AA9.1030109@desy.de> <BF3BB6D12298F54B89C8DCC1E4073D8002A5F2B6@CORPUSMX50A.corp.emc.com> <4CF25270.5050609@panasas.com> <1290968847.12027.6.camel@heimdal.trondhjem.org> <BF3BB6D12298F54B89C8DCC1E4073D8002A5F323@CORPUSMX50A.corp.emc.com> <4CF514BA.50901@panasas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Organization: NetApp Inc
Date: Tue, 30 Nov 2010 10:20:18 -0500
Message-ID: <1291130418.5123.8.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 (2.32.1-1.fc14)
X-OriginalArrivalTime: 30 Nov 2010 15:20:20.0404 (UTC) FILETIME=[19E9B740:01CB90A2]
Cc: nfsv4@ietf.org
Subject: Re: [nfsv4] More layout stuff: layout return on close
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/nfsv4>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Nov 2010 15:19:19 -0000

On Tue, 2010-11-30 at 17:14 +0200, Benny Halevy wrote:
> On 2010-11-29 01:23, david.noveck@emc.com wrote:
> > I think these two case are different.
> > 
> > I think the CB_LAYOUTRECALL case does have sequencing issues but they
> > are dealt with, at least in the case of LAYOUTRECALL4_FILE, by the fact
> > that that the seqid in lor_stateid tells the client what revision of
> > layout state is being referred to, and thus implicitly tells the server
> > what layout changes in flight are or are not covered by the
> > NFS4ERR_NOMATCHING_LAYOUT.
> > 
> > As Benny points out, the CLOSE doesn't have that, but I don't see an
> > ordering problem.  The seqid ordering mechanism is to make sure that the
> > client and the server agree on the corpus of layout-segments with
> > return-on-close best thought of as attribute for each segment part of
> > that layout segment corpus.  The close doesn't change that corpus in a
> > way that interferes with ongoing LAYOUT operations.  It merely
> > eliminates from active use those bearing the return-on-close attribute
> > and that shift can be done independently on the client and the server.
> > 
> > Let's get more concrete here.  I don't see how there should be ordering
> > issues between close and LAYOUTRETURNs.  If the segment is returned
> > before the close or after the close, it is still gone.  I don't see any
> > perceivable difference.  Now let's take the case of LAYOUTGET and close.
> > Suppose you get a LAYOUTGET response, and it overlaps (for simplicity
> > let use say it is identical but I don't think the overlap case is really
> > any different).  What determines whether the client should treat this as
> > a segment he still has (post-close), is whether it has the
> > return-on-close flag set.  If it does, he should assume it is gone (and
> > it must have been sent before the close was processed).  If it doesn't
> > have that set he should assume it still exists, apart from ordering.  If
> > it was sent before the close, then the layout segment was upgraded to
> > non-open-specific, so it doesn't go away at close.  OTOH, if it was sent
> > after the close, then the segment went away at the close and was added
> > afterwards.  However, in either case, he (the client) should assume he
> > has still has it and the that server matches in that regard.
> 
> How about the resulting layout stateid?
> What should the client use on the next layout operation?

The same layout stateid he would have used if the server had recalled
that particular layout segment and he'd replied NOMATCHING_LAYOUT.

IOW: the most recent stateid returned by LAYOUTGET, unless the client
has forgotten all layout segments for that file (i.e. the whole layout),
in which case it needs to use the open stateid.

Trond

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com