[nfsv4] Fwd: Re: New version of sparse draft (draft-hildebrand-nfsv4-read-sparse-01.txt)

Benny Halevy <bhalevy@panasas.com> Fri, 01 October 2010 16:09 UTC

Return-Path: <bhalevy.lists@gmail.com>
X-Original-To: nfsv4@core3.amsl.com
Delivered-To: nfsv4@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 505923A6C19 for <nfsv4@core3.amsl.com>; Fri, 1 Oct 2010 09:09:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.599
X-Spam-Level:
X-Spam-Status: No, score=-4.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, GB_I_LETTER=-2]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z0IfPyXGDxjn for <nfsv4@core3.amsl.com>; Fri, 1 Oct 2010 09:09:13 -0700 (PDT)
Received: from mail-fx0-f44.google.com (mail-fx0-f44.google.com [209.85.161.44]) by core3.amsl.com (Postfix) with ESMTP id 6A1B83A6ABB for <nfsv4@ietf.org>; Fri, 1 Oct 2010 09:09:08 -0700 (PDT)
Received: by fxm6 with SMTP id 6so2557201fxm.31 for <nfsv4@ietf.org>; Fri, 01 Oct 2010 09:09:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=eYtGd+xjkSiw8bf/g3HGTTz0S/V9XjA9gys6vWdoWx8=; b=pw0cyIbzpNHMc9PQwnZwLuBqZ0kVtZNYAXUaIIx+2MX2XtAqqOt9KbCPeK9jsR1iKf 4Bs6asP30Dt/Xhqp5J4S/Ji3M1J6dxiW1ZKtXUHa171ZbqVesMZb0kIy4jSAqXruDuc9 bu/F6VXbCuWegZl0s41mZ8+M3kR5zrWejqnBI=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=LmN8Tf5ve28US6rDUIPZSh9rCJ1Qpws9bkRzCrPCQJr0f8BqJyOfcX6mkMlhpMcK8B WZu5TQezdBToHe4G4PEND/L5lMVa+ZvltXqfWADBpw585orzvrK4RbqRTztNZqx+x3Ag 9EUO3UD60SgeKIMrw5EKKhmRHOHwL3R5n/xjA=
Received: by 10.223.101.18 with SMTP id a18mr5713396fao.19.1285949395496; Fri, 01 Oct 2010 09:09:55 -0700 (PDT)
Received: from fs1.bhalevy.com (87.68.41.126.cable.012.net.il [87.68.41.126]) by mx.google.com with ESMTPS id 10sm690908fax.18.2010.10.01.09.09.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 01 Oct 2010 09:09:53 -0700 (PDT)
Sender: Benny Halevy <bhalevy.lists@gmail.com>
Message-ID: <4CA607CE.5060703@panasas.com>
Date: Fri, 01 Oct 2010 18:09:50 +0200
From: Benny Halevy <bhalevy@panasas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Thunderbird/3.1.4
MIME-Version: 1.0
To: NFSv4 <nfsv4@ietf.org>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: [nfsv4] Fwd: Re: New version of sparse draft (draft-hildebrand-nfsv4-read-sparse-01.txt)
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/nfsv4>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Oct 2010 16:09:14 -0000

sorry, nfsv4@ietf.org list fu again :-/

-------- Original Message --------
Subject: Re: [nfsv4] New version of sparse draft (draft-hildebrand-nfsv4-read-sparse-01.txt)
Date: Fri, 01 Oct 2010 18:01:43 +0200
From: Benny Halevy <bhalevy@panasas.com>
To: Marc Eshel <eshel@almaden.ibm.com>
CC: J. Bruce Fields <bfields@fieldses.org>,  nfsv4@ietf.org <nfsv4@ietf.org>

On 2010-10-01 17:49, Marc Eshel wrote:
>   We don't need a new operation but it is mandatory that the client will 
> recognize this new NFS4ERR_HOLE return code, just for that we don't need 
> another operation. Clearly the server don't have to support it and the 
> client doesn't need to use the server advice.

The main problem is that you return an error for a non-error case.
No only this short-circuits COMPOUND handling, it complicates
the client's error handling code.

Returning this information as part of READ[XYZ]4resok will be a
much cleaner solution.

Benny

> Marc.
> 
> 
> On 10/1/2010 8:39 AM, J. Bruce Fields wrote:
>> On Fri, Oct 01, 2010 at 05:23:18PM +0200, Benny Halevy wrote:
>>> On 2010-10-01 16:36, J. Bruce Fields wrote:
>>>> On Wed, Sep 29, 2010 at 04:41:09PM -0700, Dean Hildebrand wrote:
>>>>>   Hello,
>>>>>
>>>>> I uploaded a new version of our internet draft "Simple and Efficient
>>>>> Read Support for Sparse Files".
>>>>>
>>>>> http://www.ietf.org/id/draft-hildebrand-nfsv4-read-sparse-01.txt
>>>> A couple other points:
>>>>
>>>> 	- By returning an error in a situation that isn't really an
>>>> 	  error, we abort processing the compound when we don't really
>>>> 	  need to.  I suppose we could make a special exceptions for
>>>> 	  NFS4ERR_HOLE, but, yuch.
>>>> 	- The server can't return NFS4ERR_HOLE unless it knows the
>>>> 	  client is prepared to handle it.  One solution would be to
>>>> 	  make client support for NFS4ERR_HOLE mandatory in whichever
>>>> 	  minor version we add sparse-read support.  Whether that works
>>>> 	  well may depend on the eventual size of the minor version.
>>>> 	  It's easier if people can increment new features
>>>> 	  incrementally.
>>> As I said in the meeting I'd be happier with a revised READ operation
>>> that officially support holes rather than hacking the existing op.
>> I'd be for that.
>>
>> As long as the name of the new operation includes the letter "Z".
>>
>>> While at that, I'd add an optional prefetch value to the args to
>>> help client-directed readahead.
>> I think it would be amusing to have a version of READ that implements
>> the rsync protocol.  (Here's my checksum of the data in the range; tell
>> me I'm right, or give the real data if not.)READ4resok
>>
>> (Maybe that one would need a "Y" in the name.)
>>
>> --b.
>> _______________________________________________
>> nfsv4 mailing list
>> nfsv4@ietf.org
>> https://www.ietf.org/mailman/listinfo/nfsv4
>>
>>
> 
>