Re: [nfsv4] Genart last call review of draft-ietf-nfsv4-rpcrdma-cm-pvt-data-06

Chuck Lever <chuck.lever@oracle.com> Wed, 29 January 2020 15:44 UTC

Return-Path: <chuck.lever@oracle.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B585812009C; Wed, 29 Jan 2020 07:44:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.3
X-Spam-Level:
X-Spam-Status: No, score=-4.3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=oracle.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yDDYhh1_dG1Y; Wed, 29 Jan 2020 07:44:37 -0800 (PST)
Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 371DB120020; Wed, 29 Jan 2020 07:44:37 -0800 (PST)
Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00TFhjDP018058; Wed, 29 Jan 2020 15:44:35 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2019-08-05; bh=KpyYDuAH5B5FTrTp68j3TZYVPZCwJ7pImgtWqgCqjZc=; b=azZiyihoZVvJouXYgCZfNgmgMipQMCpDGblohEnmWlrFjy2hwVITF4+DIrDUxLqAxhMb 9WIM+WDimbmzh/Zl/wusapozIglcDiiIMmbMGzbDkfpLZpvadcoC+qxy5IDQF5XCKVrC 92SNOj/GKzJqL0E/u/lNlFnTi/Sq3hTYbaozLTFmwkTm+gKC8w4Dj7swoIs1S47zjYjY STtC6kN099+vk98vIoi/GA0lfjR4Kn7UyT+wT7oYf9Ayk8aO0Q8kxl7LPTjG4uTBTrfN ZVBObu+quUx50OLN8Ieg5/IzzotL40liDZeQPvjG2f0sQ2C9TY245RtF23o/LzjQKbin Ag==
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2xrd3ue99b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jan 2020 15:44:35 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00TFiD4m069235; Wed, 29 Jan 2020 15:44:34 GMT
Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2xtmr9wttv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jan 2020 15:44:34 +0000
Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00TFhSEd029746; Wed, 29 Jan 2020 15:43:28 GMT
Received: from anon-dhcp-152.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Jan 2020 07:43:27 -0800
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <CAMRcRGSD2JFSf+6T8+F+HqQi6NEjhqfGNDb16R=LS74PBh4i_g@mail.gmail.com>
Date: Wed, 29 Jan 2020 10:43:26 -0500
Cc: draft-ietf-nfsv4-rpcrdma-cm-pvt-data.all@ietf.org, gen-art@ietf.org, last-call@ietf.org, nfsv4@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <EF797264-71CD-49AA-9A96-AB8B68188F1E@oracle.com>
References: <158015386640.23917.3626035422388212873@ietfa.amsl.com> <301328AC-ECCC-41FA-A8E5-F81A9A7FDAF9@oracle.com> <CAMRcRGR2XkudwuWczgHbF23=E6tAgrzMrUNDNTjJbVR=bmhung@mail.gmail.com> <96353CFE-9CA9-4146-83D7-310E48AD4907@oracle.com> <CAMRcRGSD2JFSf+6T8+F+HqQi6NEjhqfGNDb16R=LS74PBh4i_g@mail.gmail.com>
To: Suhas Nandakumar <suhasietf@gmail.com>
X-Mailer: Apple Mail (2.3445.104.11)
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9514 signatures=668685
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001290130
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9514 signatures=668685
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001290130
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/XekSMzvvFrDzsL6eZ7-Vex7t4IQ>
Subject: Re: [nfsv4] Genart last call review of draft-ietf-nfsv4-rpcrdma-cm-pvt-data-06
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jan 2020 15:44:40 -0000

OK. The next submitted revision will include changes resulting from
the Gen-ART review. I'm waiting for resolution of SecDir comments
before submitting a fresh revision.

Meanwhile, the changes so far are available to view as a diff with -06:

https://chucklever.github.io/i-d-rpcrdma-cm-pvt-data/#go.draft-ietf-nfsv4-rpcrdma-cm-pvt-data.diff


> On Jan 29, 2020, at 10:35 AM, Suhas Nandakumar <suhasietf@gmail.com> wrote:
> 
> Thanks Chuck for the additional clarification. That helped me to understand better.
>  Sorry that I missed it in my reading. 
> 
> Yes the suggested changes look great.
> 
> Cheers
> Suhas
> 
> On Wed, Jan 29, 2020 at 7:23 AM Chuck Lever <chuck.lever@oracle.com> wrote:
> 
> > On Jan 29, 2020, at 12:03 AM, Suhas Nandakumar <suhasietf@gmail.com> wrote:
> > 
> > Thanks Chuck for the response. Please see inline
> > 
> >> On Tue, Jan 28, 2020 at 7:52 AM Chuck Lever <chuck.lever@oracle.com> wrote:
> >> 
> >> Zero is a permitted value for the size fields. Section 5.2 explains how
> >> to compute the actual buffer size. If those fields contain zero, the
> >> actual send and receive buffer sizes would be 1024 octets.
> > 
> > 
> > [Suhas] I am not sure if i am reading it right here. Section 5.2 would result in the
> > value of -1 if the min of the values is Zero (0/1024 - 1). Isn't it so ?
> 
> Section 5.2 says:
> 
>    Inline threshold sizes from 1KB to 256KB can be represented in the
>    Send Size and Receive Size fields.  A sender computes the encoded
>    value by dividing the actual value by 1024 and subtracting one from
>    the result.  A receiver decodes this value by performing a
>    complementary set of operations.
> 
> Here, "actual value" means the real size of the buffer. A 1024-octet
> buffer would result in (1024 / 1024) - 1 = 0.
> 
> The computation done by the receiver is the inverse:
> 
>    (0 + 1) * 1024 = 1024
> 
> I could replace "actual value" by "buffer size, in octets". Would it
> help if the text also spelled out the inverse computation?
> 
> 
> --
> Chuck Lever
> 
> 
> 

--
Chuck Lever