Re: [nfsv4] Review comments for WGLC of draft-ietf-nfsv4-flex-files

Thomas Haynes <loghyr@primarydata.com> Fri, 04 August 2017 20:28 UTC

Return-Path: <loghyr@primarydata.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61B65131EB6 for <nfsv4@ietfa.amsl.com>; Fri, 4 Aug 2017 13:28:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=primarydata.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cLlWH6kCYhfP for <nfsv4@ietfa.amsl.com>; Fri, 4 Aug 2017 13:28:21 -0700 (PDT)
Received: from us-smtp-delivery-194.mimecast.com (us-smtp-delivery-194.mimecast.com [216.205.24.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D9AC0131EB1 for <nfsv4@ietf.org>; Fri, 4 Aug 2017 13:28:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=primarydata.com; s=mimecast20170802; t=1501878499; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references; bh=xY0BkYDiNhgPULMEZLdrqzj2ze/5N3jX+P1bii+KG7M=; b=dG2oQCq0VTfVa6qYqfK9yn9UuVOTyI9FPWnNbxKH0v+w44ILT//z4noQWHPuTDVjY8248KzdAxqTmdDLgxwX4EdqXes1Zrk5PWTJdxaJ2WGEHzusznBsO+hTlHs5kqC1w4F1WbtQSP1hMoeKhBkE4bOXRVoMar3JDOfqrrtPEt8=
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02lp0024.outbound.protection.outlook.com [216.32.180.24]) (Using TLS) by us-smtp-1.mimecast.com with ESMTP id us-mta-23-9T5uD7b9Mz2UFQ55tFvslQ-1; Fri, 04 Aug 2017 16:28:18 -0400
Received: from BY2PR1101MB1093.namprd11.prod.outlook.com (10.164.166.21) by BY2PR1101MB1093.namprd11.prod.outlook.com (10.164.166.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22; Fri, 4 Aug 2017 20:28:15 +0000
Received: from BY2PR1101MB1093.namprd11.prod.outlook.com ([10.164.166.21]) by BY2PR1101MB1093.namprd11.prod.outlook.com ([10.164.166.21]) with mapi id 15.01.1304.025; Fri, 4 Aug 2017 20:28:15 +0000
From: Thomas Haynes <loghyr@primarydata.com>
To: Chuck Lever <chuck.lever@oracle.com>
CC: "nfsv4@ietf.org" <nfsv4@ietf.org>
Thread-Topic: [nfsv4] Review comments for WGLC of draft-ietf-nfsv4-flex-files
Thread-Index: AQHTDVJ1CItYbyLEFUOrNQsbsMHSJaJ0pb6A
Date: Fri, 04 Aug 2017 20:28:15 +0000
Message-ID: <6D2078DD-9C4D-448C-9B63-D2A69E646230@primarydata.com>
References: <700DA6C9-7D9C-45C3-9D13-547B6244EF75@oracle.com>
In-Reply-To: <700DA6C9-7D9C-45C3-9D13-547B6244EF75@oracle.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [63.157.6.18]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BY2PR1101MB1093; 20:JIFZ0aVblDbBWQJiGtZb0DKPiGxqFck1SEWtmJnPQsgAtEaPNUSHZYNowOc013FPbqxxD+6zWTBQotV+7/1pMXoQZLoYGHlpak3HSw9A+Gpgf9aVz4g7iPm+5L+aaQ/DIC2Ptup1N0A842/mv2ALLq4RmlZ2Hqkyt85IUPTKWyc=
x-ms-office365-filtering-correlation-id: 72fda781-f254-4c2b-34b6-08d4db7755bc
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR1101MB1093;
x-ms-traffictypediagnostic: BY2PR1101MB1093:
x-exchange-antispam-report-test: UriScan:(146099531331640);
x-microsoft-antispam-prvs: <BY2PR1101MB10937D8C2DE73174BB042205CEB60@BY2PR1101MB1093.namprd11.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(2016111802025)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(6072148)(6043046)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR1101MB1093; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR1101MB1093;
x-forefront-prvs: 0389EDA07F
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39410400002)(39400400002)(39830400002)(39450400003)(24454002)(189002)(199003)(377454003)(51914003)(86362001)(4326008)(25786009)(36756003)(102836003)(3846002)(6116002)(229853002)(97736004)(305945005)(66066001)(77096006)(6486002)(966005)(7736002)(14454004)(478600001)(6506006)(6436002)(53546010)(83716003)(68736007)(8676002)(33656002)(82746002)(54356999)(2900100001)(76176999)(50986999)(38730400002)(3660700001)(6306002)(3280700002)(81166006)(81156014)(6246003)(6512007)(53936002)(110136004)(106356001)(101416001)(189998001)(99286003)(2950100002)(5660300001)(6916009)(8936002)(105586002)(230783001)(2906002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR1101MB1093; H:BY2PR1101MB1093.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-ID: <66B5C6B80BD4A14D8060E458BEB36DB8@namprd11.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: primarydata.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2017 20:28:15.0196 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR1101MB1093
X-MC-Unique: 9T5uD7b9Mz2UFQ55tFvslQ-1
Content-Type: text/plain; charset="WINDOWS-1252"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/enAUQ_WdXNLs6EFFzIGJNksaXPk>
Subject: Re: [nfsv4] Review comments for WGLC of draft-ietf-nfsv4-flex-files
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Aug 2017 20:28:23 -0000

Thanks for the review Chuck!

> On Aug 4, 2017, at 11:49 AM, Chuck Lever <chuck.lever@oracle.com> wrote:
> 
> This document appears to be mature and ready for publication.
> Just a handful of housekeeping observations:
> 
> The material in sections 1.1 and 1.2 appears to be the same or
> nearly the same as the material in Section 2 in
> draft-ietf-nfsv4-pnfs-layout. It would be nice if flex-files
> could reference that document instead of including the repeated
> material.

Agreed, I just did not know which was going to pop first and did not
want to create a normative chain. I can hack it down.


> 
> Section 3.1: the code copyright is 2012. Should it be updated
> to 2017, or perhaps 2012-2017 ?

I never know about that part. :-)


> 
> Has it been confirmed that the XDR code contained in the most
> recent revision of this document compiles with rpcgen?


Except for the last change for the new flag, yes.


> 
> 
> --
> Chuck Lever
> 
> 
> 
> _______________________________________________
> nfsv4 mailing list
> nfsv4@ietf.org
> https://www.ietf.org/mailman/listinfo/nfsv4
>