Re: [nfsv4] More layout stuff: layout return on close

[Trond Myklebust <[e-mail]>]

On Wed, 2010-11-24 at 10:55 +0100, Tigran Mkrtchyan wrote:
>  
> We are in a quite weird situation here. From one side servers asks  a
> client to return
> layout on close, but from other side you have to keep track of the
> layout and recall it to
> ensure that the client will not use it any more.  I would love to see
> this part of the spec to
> be more deterministic. But it we change it not to be a more strong
> requirements, then
> some of the current clients will become not complaint with the spec. Are
> we ok with that?

I fail to see your point. Which clients would become spec incompliant if
we relax the requirement that they must send a layoutreturn before close
when the server sets the logr_return_on_close flag? Relaxing a
requirement is not equivalent to prohibiting the behaviour.

> And of course I have to change layout handling in our server we rely on
> layoutreturn. Which
> is not a big change (I think). BTW, is there any other server uses
> return_on_close ?

You don't have to change the server, but if you don't then it will
perform less than optimally with forgetful clients.


Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
[e-mail]
www.netapp.com