Re: [nfsv4] [Gen-art] Genart last call review of draft-ietf-nfsv4-rfc5661sesqui-msns-03

Vijay Gurbani <vijay.gurbani@gmail.com> Wed, 18 December 2019 22:53 UTC

Return-Path: <vijay.gurbani@gmail.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A3B89120A7D; Wed, 18 Dec 2019 14:53:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JCqLLBS510DG; Wed, 18 Dec 2019 14:53:51 -0800 (PST)
Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 20438120013; Wed, 18 Dec 2019 14:53:48 -0800 (PST)
Received: by mail-ed1-x532.google.com with SMTP id j17so3038225edp.3; Wed, 18 Dec 2019 14:53:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+XEMJ2+udGDRhXXsqu4SsCsm40H3QW4x0tIHv5hUaP8=; b=UOMj3PX9S3VNvNTYVn2lQJ4IHPGvOgJzW3czbkTbePBbTbG1fMtL1hR3rAE10bwtB+ oBo2gviDJpVPPaKbKxG6s7Nmp4uhPS01R2TgUx9fLvX+KIC9mVdE+Gp+CE72qwQJA2lE uF8xRSghvd9WCGWzHY6rB+5yHnKzUcWRb8mwlOwVDnWgkfX4VoaNy2MrKjENFvugWLJV mMZD/DOKS5hBNMt1MRwv4aka/maswiezwYyEhyxNvS6hfx8fyAdmslxmNqVVR8N+LQNU K/r1M2zPC//AICVZzwTBdIVrbi5LbLrL6oOFOu6ZK9Iv9kfPAYQTR8Dxl89w/wRYPXZi 12uw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+XEMJ2+udGDRhXXsqu4SsCsm40H3QW4x0tIHv5hUaP8=; b=RlWdX5WquRFKf+u2yQeAdc9k9RcETDCToQlxyEG1NBYpWAn8TlQYK85LFP9MrWAZKm lGtdC6h9b0KSsgwOLJarFjkxbvHg/3KjoWfW+IqVVYvecnbemlp+NV0R3oqe7bfrfHfP lIPr+caEOP47G1kUaf6L5RZ9ABUgaOdluCxhqvov/wYQisVQ+dlwsTwpS5DeyP2uu/Sb IJM+H9avwUajPMCf8sfcy2N/7B+PSqYaATUoWRB4odc774nKStT2dIH/Es68z8BYor50 Z31WXUTmkF3aDPPoQyqwEjYCdIAXKFRQDH997hUtNXKBZb7ry5u6qtoAc8y1ZCyVRszd x3ow==
X-Gm-Message-State: APjAAAXh6lTTZpH4yutakmYeus26hJNISsI2oPJ4iQLMknOv2opgBqA1 baTox0wImwQP3ShNqozo8RqG8Oi/T9mBlCCRtlMytw==
X-Google-Smtp-Source: APXvYqz3CWjyXLa9/DF5HC4dUFtFljxQ7qWkQwrnv0Mb3IdVRuqXkACCZCwWrBvwnxztMegkSwTRTHADqpLXV4rRqa4=
X-Received: by 2002:a17:906:a14:: with SMTP id w20mr5677559ejf.274.1576709626527; Wed, 18 Dec 2019 14:53:46 -0800 (PST)
MIME-Version: 1.0
References: <157662824941.4998.12199831329321073078@ietfa.amsl.com>
In-Reply-To: <157662824941.4998.12199831329321073078@ietfa.amsl.com>
From: Vijay Gurbani <vijay.gurbani@gmail.com>
Date: Wed, 18 Dec 2019 16:54:41 -0600
Message-ID: <CAMMTW_J8Yfy=Bss_5NqYN5dF+dZ2PPk-wHswtXy0yG4szMw6Bg@mail.gmail.com>
To: Vijay Gurbani <vijay.gurbani@gmail.com>
Cc: gen-art@ietf.org, last-call@ietf.org, nfsv4@ietf.org, draft-ietf-nfsv4-rfc5661sesqui-msns.all@ietf.org
Content-Type: multipart/alternative; boundary="00000000000034049b059a025110"
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/mVoAwnH261r7YMtcqlffQ7Kpud0>
Subject: Re: [nfsv4] [Gen-art] Genart last call review of draft-ietf-nfsv4-rfc5661sesqui-msns-03
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Dec 2019 22:53:54 -0000

All: This email serves as the second half of the review of
draft-ietf-nsfv4-rfc5661sesqui-msns-03.

I reviewed pages 297 to the end of the document, mostly for editorial and
similar comments from a generalist point of view.

The disposition remains the same as before ("Ready with Nits").  In
addition to the nits I outlined in my previous email (reproduced below),
here is one additional one:

1/ S18.51.1: What is the value of bracketing the code with <CODE BEGINS>
... <CODE ENDS> in this, and the next section?  Clearly, you have code in
the previous section, and later sections, without such bracketing.
Uniformity dictates that the code in these two sections be given the same
treatment as the code in previous sections.  If, on the other hand, there
is some significance to such bracketing, it may be good to comment on such
a significance in S 18.51.1.

Thanks,

- vijay

On Tue, Dec 17, 2019 at 6:17 PM Vijay Gurbani via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Vijay Gurbani
> Review result: Ready with Nits
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-nfsv4-rfc5661sesqui-msns-??
> Reviewer: Vijay K. Gurbani
> Review Date: 2019-12-17
> IETF LC End Date: 2019-11-25
> IESG Telechat date: 2019-12-19
>
> I have reviewed about 1/2 of the I-D, up to Section 12 (page 297).  I will
> review the remaining 1/2 before the telchat, but I suspect that given my
> very
> high level overview of the draft, my disposition will not change.
>
> Summary:  This draft is ready for publication as a Proposed Standard.  In
> the
> portion of the draft I reviewed, there are some minor nits that can easily
> be
> fixed.
>
> Major issues: 0
>
> Minor issues: 0
>
> Nits/editorial comments: 4 ("Sn" means Section n):
> 1/ Appendix A: s/No correesponding explanation/No corresponding
> explanation/
> 2/ S1: s/authoritative complete/authoritatively complete/
> 3/ S1.7 (page 12): "associable" or "associated to"
> 4/ There are many long lines that go beyond 80 characters, see S1.9, the
> bullet
> that starts with “o  Open files can be …”,   Table 1, S4.2.1, etc.
>
> Thanks,
>
> - vijay
>
>
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art
>