[nfsv4] Genart last call review of draft-ietf-nfsv4-rpcrdma-cm-pvt-data-06

Suhas Nandakumar via Datatracker <noreply@ietf.org> Mon, 27 January 2020 19:37 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: nfsv4@ietf.org
Delivered-To: nfsv4@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 846CC3A0A98; Mon, 27 Jan 2020 11:37:46 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Suhas Nandakumar via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: draft-ietf-nfsv4-rpcrdma-cm-pvt-data.all@ietf.org, nfsv4@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.116.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <158015386640.23917.3626035422388212873@ietfa.amsl.com>
Reply-To: Suhas Nandakumar <suhasietf@gmail.com>
Date: Mon, 27 Jan 2020 11:37:46 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/n2fbg9X3mEhld32rat8pXDS8RaE>
Subject: [nfsv4] Genart last call review of draft-ietf-nfsv4-rpcrdma-cm-pvt-data-06
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jan 2020 19:37:47 -0000

Reviewer: Suhas Nandakumar
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-nfsv4-rpcrdma-cm-pvt-data-??
Reviewer: Suhas Nandakumar
Review Date: 2020-01-27
IETF LC End Date: 2020-01-27
IESG Telechat date: Not scheduled for a telechat

Summary: Thanks for the work. This document is clear in the problem to be
solved . This document is ready to be published as it-is, however I do have few
clarification questions for my own understanding

Major issues:

Minor issues:

Nits/editorial comments:
1. The draft doesn't specify normative procedures on sender/receiver behavior
when certain fields are missing (say size of all zeroes). Should the draft say
recommended procedures for handling these scenarios ?

2. Also i didn't see fallback procedures to be followed when the server
reported size isn't of much use to the sender of the data . In such case the
sender might decide to go with existing explicit RDMA data transfer operations
instead of failing the connection ?