Re: [nfsv4] draft-ietf-nfsv4-umask

["J. Bruce Fields" <[e-mail]>]

On Tue, Aug 22, 2017 at 08:36:38PM +0000, Thomas Haynes wrote:
> Hi Bruce,
> 
> Can you modify your draft such that it generates xdr?

I considered that but it seemed like a lot of boilerplate for little
return.  The code to extract the xdr might almost be longer than the xdr
you're extracting.  I dunno.

> 
> I.e., I went to add a new const for your new attribute, and unlike the xattr document, I had to guess:

You didn't have to guess the number, just the constant name, right?  I'm
not sure how much that matters.

--b.

> %/*
> % * New For UMASK
> % */
> const FATTR4_MODE_UMASK         = 81;
> 
> I’d recommend that you add the ‘///‘.
> 
> Also, you should use the <CODE BEGINS> and <CODE ENDS> at the very least here:
> 
> 4.  mode_umask Attribute
> 
> 
>          struct mode_umask4 {
>            mode4  mu_mode;
>            mode4  mu_umask;
>          };