Re: [nfsv4] draft-ietf-nfsv4-umask

"J. Bruce Fields" <bfields@fieldses.org> Wed, 23 August 2017 15:56 UTC

Return-Path: <bfields@fieldses.org>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C67341329CC for <nfsv4@ietfa.amsl.com>; Wed, 23 Aug 2017 08:56:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mJ267aRm6I8M for <nfsv4@ietfa.amsl.com>; Wed, 23 Aug 2017 08:56:08 -0700 (PDT)
Received: from fieldses.org (fieldses.org [173.255.197.46]) by ietfa.amsl.com (Postfix) with ESMTP id 1E54D126BF0 for <nfsv4@ietf.org>; Wed, 23 Aug 2017 08:56:07 -0700 (PDT)
Received: by fieldses.org (Postfix, from userid 2815) id 658703EB; Wed, 23 Aug 2017 11:55:36 -0400 (EDT)
Date: Wed, 23 Aug 2017 11:55:36 -0400
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Thomas Haynes <loghyr@primarydata.com>
Cc: "nfsv4@ietf.org" <nfsv4@ietf.org>
Message-ID: <20170823155536.GA10035@fieldses.org>
References: <CCE6471D-5252-4313-BDED-5EAA468E3FAA@primarydata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CCE6471D-5252-4313-BDED-5EAA468E3FAA@primarydata.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/nCKSSgDdbYNJWmFFlakJKOYfDsc>
Subject: Re: [nfsv4] draft-ietf-nfsv4-umask
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Aug 2017 15:56:10 -0000

On Tue, Aug 22, 2017 at 08:36:38PM +0000, Thomas Haynes wrote:
> Hi Bruce,
> 
> Can you modify your draft such that it generates xdr?

I considered that but it seemed like a lot of boilerplate for little
return.  The code to extract the xdr might almost be longer than the xdr
you're extracting.  I dunno.

> 
> I.e., I went to add a new const for your new attribute, and unlike the xattr document, I had to guess:

You didn't have to guess the number, just the constant name, right?  I'm
not sure how much that matters.

--b.

> %/*
> % * New For UMASK
> % */
> const FATTR4_MODE_UMASK         = 81;
> 
> Iā€™d recommend that you add the ā€˜///ā€˜.
> 
> Also, you should use the <CODE BEGINS> and <CODE ENDS> at the very least here:
> 
> 4.  mode_umask Attribute
> 
> 
>          struct mode_umask4 {
>            mode4  mu_mode;
>            mode4  mu_umask;
>          };