[nfsv4] Re: Artart last call review of draft-ietf-nfsv4-layrec-01

Thomas Haynes <loghyr@hammerspace.com> Mon, 14 October 2024 17:03 UTC

Return-Path: <loghyr@hammerspace.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 57A9DC16940C; Mon, 14 Oct 2024 10:03:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=hammerspace.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P5kPhqvnp0og; Mon, 14 Oct 2024 10:03:11 -0700 (PDT)
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2115.outbound.protection.outlook.com [40.107.223.115]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9E6A5C14F6FD; Mon, 14 Oct 2024 10:03:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ryCinbfDcGHQFZevprPSFaBR4Txb7GIWxVpe2c8GDXKvw+W/2KqiaA9QBOj+2RgzrwJ28d/VLcQvMvps+iPh8Flky+4oEMXSrwDAlcPqXdjKMsQJYTjwQLjZkSTo3b0vd5XKrkJmJDl93eDOsIl7YhvQ3fyFhEqUN03QoQJzAhfUgb+pzX30RLx/R8NSNoTImgYcERC35c6T5FX0B8+Ar5YJd1pqHK+PfbwzPysmPZQzPnh0hk1kNRTZKNI6r2wfPMNV+f36OeoycnYHHQ7MeSMBVo1gOtAaF5C5Mjp4B3YSmIr4UXX0d3jPtCndS5639vvkkPN5tfZSTBOzE/Wwug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n21NzQc541DQDarq2AU9neT0k2rzzpOeGGnVOEs0lpw=; b=snO7Ny8RlXMiN6yuflXLBoGqsOfclAg1YpjiZglHNJ5eAuR22Lt99MpbOXaZXvv53Crv3lmVFa7T9xd2i7ltKGOvRq1zIaNT248rlrk271Bnv7zpiVScVwqb/AA8WKbHuDK0I3eqmWnt2d8KbxkRPyfeMxbAunWj5KsbDSTYOvKzC96wSaym0eLDvBar6BqTV/BoEpcxPTnyzvihUwb9JlmceWZrPzdzLGAc8s+Nky8fZThWBm6NjEnBtGw1G1C7Miy/wTWrSf5qwOBJ0IlZklqbPbUWsuazGJz7YTwGZS/hrlUyYNT6yf6Yrt5K24+g/hD2cWnCPz0ry2gV0wbYiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hammerspace.com; dmarc=pass action=none header.from=hammerspace.com; dkim=pass header.d=hammerspace.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammerspace.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n21NzQc541DQDarq2AU9neT0k2rzzpOeGGnVOEs0lpw=; b=glNJ7mGlc+/yi8EQQWl3FfuZf3ijtf6CY2mmVMIyIk9zROdzo8SgUIaJQ4EUvObvqfL82tOjQ3fmm5mQtapIh4qxx8bm2cJZPA/aV9PJs4KNByjN3gOwIzv09NkD+h+PwdUOGrHkkd9wlg86xu5mm5iZSxvHMGbq50nVFNZRnG8=
Received: from LV8PR13MB6682.namprd13.prod.outlook.com (2603:10b6:408:220::12) by MN6PR13MB7188.namprd13.prod.outlook.com (2603:10b6:208:4f3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.25; Mon, 14 Oct 2024 17:03:04 +0000
Received: from LV8PR13MB6682.namprd13.prod.outlook.com ([fe80::3f2e:78c:d8e9:19b2]) by LV8PR13MB6682.namprd13.prod.outlook.com ([fe80::3f2e:78c:d8e9:19b2%6]) with mapi id 15.20.8048.020; Mon, 14 Oct 2024 17:03:04 +0000
From: Thomas Haynes <loghyr@hammerspace.com>
To: Shuping Peng <pengshuping@huawei.com>
Thread-Topic: Artart last call review of draft-ietf-nfsv4-layrec-01
Thread-Index: AQHa9GrjWTwIjgh71Euje3zAHmg/67KGzPiA
Date: Mon, 14 Oct 2024 17:03:04 +0000
Message-ID: <0D124FFA-F566-4B51-A7B8-EA372A0EA77F@hammerspace.com>
References: <172431427928.2528543.17950906430538024372@dt-datatracker-6df4c9dcf5-t2x2k>
In-Reply-To: <172431427928.2528543.17950906430538024372@dt-datatracker-6df4c9dcf5-t2x2k>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3818.100.11.1.3)
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hammerspace.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: LV8PR13MB6682:EE_|MN6PR13MB7188:EE_
x-ms-office365-filtering-correlation-id: 9ffd80b0-e20b-42ff-dde9-08dcec72116a
x-ms-exchange-atpmessageproperties: SA
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230040|10070799003|366016|376014|1800799024|38070700018;
x-microsoft-antispam-message-info: jArxV4hHX7NGke+K/oNA5uxty3QhxjbRJIWRylRPDquAajGF2NONTytPE4wKyVvDv6ZHBcWi5nWzXUjvoQxJtqzkUlDgEeb6y7uebHxzAqvkcJnnogjw2aK9hzzaVKdY7lAC2SRYAIzwOZCCL6bteCIeUC6XITst/k1djudp4hkQxR0QNOQhKJyqo9V8Y4QApVLoBHrQ/KmDHiYZpJH1RQc77vr0T9zcNPFKLl6/Cfo1BCOFJQh8HqV1n9kjTCujAeYLNG4/VTPUS7A/uB0LQQzQPTf0mQZyrTcLCQVaWSOf6F2Yw3g1lMQoCGn22aGLeEzEMfZ9mhUPEWGgy6sQ6pHa/b962Ssdudk4xYsA7WBkdCwPzk8EgkKU2MkhqRLAA9+kIuX3eS9w8So+JXsudJuPwx9pPmk6bpfnji3r7EOO0L8z6eBzu4kFyJnlhy0bZH0p+1oTusozz1r5LPK+sE65Yi3rsupBNvo0IFMESv1SUDwZBZuk9Y/5b9em1+vXLPdKNW0rz6Kas1vt/Nujbjm4MmMTWNPJ2lTpKSy0oU5ZHn6+dSjLwVK2e77pJ6/QHEBpFh+CtpCVwibMNP00Ak8Fv5wNNcDEVUIHz3t/4qws2qLEpQh98MFNsY1I46mTKEJFQxMOz6VVyFKn+5tuOdCsU+83tsNGwMV9l+bGLhRVFstHxDgndUOohpD+WdtEvIf8521cSDpPvmCP8vb7N9uZvtWZrtHw4ezyJplYx2xaEs1cXoH+HsgAXPYwnr0OG6T9uZxrfVF2aIUV+foLRHCVzG+bhwGrb9/0ZJjosxHGa0xjWDAkgZe3/5WKIZVmXZ9l+pGD8vFkLfWH8l+Xo/8i0tvAmCQz9aaQN4bKmaPRXbx1vVoSfz8qTkthf1bm5/7FxstCU7c2QO5CLPDI5OZc6WJOnnYA+wrS3Nxd8Q0VuzcxNOleY0YcFEwWgUywayIqdQ6TNhv4BJ+MM8yawS0WnZnRoHQ7WZp2FBMbWuGq3f8XNz9BZNk3LWql3bYAWfwr3aUQbplJUSHE5cNtsmsc+LLNHmnXOhVnBbvcAHiE6C8QilOaa7E63vffXv7czUxuqeoffXac+KtmKxy7sUwJX6dLp47C5jVWWJRkv8kMb2VDSBx8J3tDBKAPb6v9iNgHwI1pZuCZxQVKDVa/6KIC3BQkxxt9PyNVG6+7M9v+Zw9exVrqPyqkMWxXDsMNxwv7XEb+PtA7SwsxVhCpAQtuz4OWPMIosjRp2R7yCItLDHzkub5KIPRKiT3v8zBjbGreBZ0R0hFPlRKsEMtzDcsyeEcayOEtUoDB8NUY2WNYBfWN8/ErV5Wv0AsbixsrQ5WFRNWZEHgq2ywe8IYhUQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR13MB6682.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(376014)(1800799024)(38070700018);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: l7HmhF/9iEquMQFb/oTqIkSZWzHyNtPhYSblSgKmb17r+crCKOJ0gXQ3VlGz4U5AdAa0HhEz7MQgscYq4Rd1xihWtIypv8FJbWrzC/ShjIj2DlID/1hLeFYyKFNG+8cOl2UaoE5TCI47MIrLTxPNfBhtdprGtCIYZZFyAeBGl9CemcXj5gQ0sl4Eirpri07hI0UaKKI+Wb+B19x8UdAMISQkGtEqCaE7fRLrt2M1GwGkKr2H85DYmmT11rhoHzoiBjDNZZexNagmEjcFrC0P+JWJzBnzK5xBQcJzOkYCz55qJDI3HnaPzfp8Su0uyduFWEigcXqBm32ISF50vLVKEoQzHgZppFAcc79yRR9HnT5FwctwpT3sysx1K61Xx6Z7nbrLUcLuxzKQFaRJUU5KSbzHAr8PkKdFAQJEWqiuE6DNOFqLm517NMLWhL+ylDdT1mExINWYFP50sDMC8fBOYJsyCGD6mfeNOAYf8QiHSGb7bGuszx4NtFJQTlEfsacEJG+VSeELPjc7jc8TQFRocvqyyGC+aGHSvJTzzSo61SOmaPBbuosdJdgtavp/pZYU4cKIMu4IaP+XoWZGlmAGZqSiFkaD82O5jkD/u5E5ldaN02WY1Kw4ErlepnPVYUA0GQF0yEu/dhk6kOxUsA2MFSX8i6YiIufVRgCGUjemcCDXrOwW2P250kOhJoCwFwxeLF6yB/RGfyJHQ7d9BYw+vzi8qR+VsqPAe+W3xUNo0cq6xuJ9yG/AcLHXi4oqYsK3OFF8gyztLf90C8mJ7EHghVZ9v83v1ZLM89dlYUNTkSJKU6YKDi1tcUon1y2y7iPeG9yXQIs67gfGubbjYIiKU9pdYE4IcOClwWR1AwQXNzssWpkEYOk/WZY+NFFdx+1ymmGrf2Nd7NO6Su3m+c3p8Iz5YV1LzOVw4haYnwv0LqiftGHvsrplp3JdKKO6EMOzod+Ye8kZHXDUzRChDIxbFm5hP7O6OtlW0+hbawnw5T8LgN9mshqigQN2SWBAwKkCpdgT4K3+NdzY0Sz3/U5Vpp4LRR40/18VhGi1rbTb4f934hwTlvhME7zZan8F6EW1cnUuBozwQloQLejhv+xSTGWeCUcNCW6PB/SDxO+SW7SQrWig62PyuL+gkuj0ULzyqro12eddx4FpKfZyGNt5j/4IipkCptXPSb2VtvZnRwiBCKHpEIidyDU1WOupet+0kbEeaamtGL/Qbcrozq288aelb3QhMF5lkiWIJ/i+N+9+OdxX5q//w9EsEHlrYlPDP3MHPD1ls4hIvzAsGGgiZjpuPfRh7GQhzUzQ/ckaoXagTkf0dY7xmHf09a5GcjpCAoBmQTnsQpb2PGP+pTI8lld0DNY43g+KY2UXpZO7FAAuk8qOYT5VzFqkW7yW0QjpOSIOmZTpkvRfXx/QRi9oPQmQ/KJiyBoNwOlXzHwjPtW1QTfYISSOCVdP4bSNrkCt/s2jcqM9huvBgmuwqrXwF2Guo5pQnLifWFR3cpGJ0qcvfqVlIVDPYO+TEzM2+IyLVF5r8pUjJYOOBO23QpnL88WIyXVLaDwAjb0hPIskGNEwqPtUATU09Eqby0gyK45uF8DxqfWYsGd69K2gJB31p5qD4Ek4HzYkb9NgQ2JfOYU1Gi441HVI/9LBmbZc/wjn
Content-Type: text/plain; charset="utf-8"
Content-ID: <5092CB82AF7D3F449B7A6FD0E7D96138@namprd13.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: hammerspace.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: LV8PR13MB6682.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ffd80b0-e20b-42ff-dde9-08dcec72116a
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2024 17:03:04.2044 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0d4fed5c-3a70-46fe-9430-ece41741f59e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9y2iuMCbh9GQ/+T9YNYLIMkxQttF6hX+IU6z4V4hpQhupk78+ByHRbxF0ox0PZ+kc+rX7IVSeWiBB/+hGtdlEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR13MB7188
Message-ID-Hash: NT4EHPLC7QYYBXYPZPSQQFR36SGO54X6
X-Message-ID-Hash: NT4EHPLC7QYYBXYPZPSQQFR36SGO54X6
X-MailFrom: loghyr@hammerspace.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-nfsv4.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "art@ietf.org" <art@ietf.org>, "draft-ietf-nfsv4-layrec.all@ietf.org" <draft-ietf-nfsv4-layrec.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "nfsv4@ietf.org" <nfsv4@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [nfsv4] Re: Artart last call review of draft-ietf-nfsv4-layrec-01
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/nDCWAs8rOv1NBf5S3xInMJ8Ai6k>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Owner: <mailto:nfsv4-owner@ietf.org>
List-Post: <mailto:nfsv4@ietf.org>
List-Subscribe: <mailto:nfsv4-join@ietf.org>
List-Unsubscribe: <mailto:nfsv4-leave@ietf.org>

Hi Shuping,

Thanks for the review, I’m sorry I lost it in a storm of reviews over 3 documents.

Comments inline

> On Aug 22, 2024, at 1:11 AM, Shuping Peng via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Shuping Peng
> Review result: Ready with Issues
> 
> I am the assigned ART-ART reviewer for this draft.
> 
> Summary:
> 
> I have some minor concerns about this document that I think should be resolved
> before publication.
> 
> Comments:
> 
> Major Issues:
> "No major issues found."
> 
> Minor Issues:
> 
> 1.1 Definitions
> I found that the terms listed here are exactly the same as those defined in
> RFC8435. So I wonder whether it would make sense to simply refer to RFC8435
> instead of repeating them.
> 

I’m fine with that.


> 2. Layout State Recovery
> "After the grace period:
> If the client were to send any lrf_stateid in the LAYOUTRETURN with the
> anonymous stateid of all zeros, then the metadata server would respond with an
> error of NFS4ERR_NO_GRACE (see Section 15.1.9.3 of [RFC8881])."
> 
> I am not sure whether there is an mistake in this sentence: "to send any
> lrf_stateid in the LAYOUTRETURN with the anonymous stateid of all zeros"?
> Should "with" be "other than"?
> 

No, it is correct.

A  lrf_stateid of all zeros means to report errors from a previous boot instance.

It is only valid before grace ends and not valid after grace ends.

The flip is that a regular lrf_stateid is not valid before grace ends and valid after grace ends.



> 4. IANA Considerations
> "IANA should use the current document (RFC-TBD) as the reference for the new
> entries."


I guess I need to reword this. But basically it means if I use RFC-TDB anywhere in the document, replace it with the new document ID.

This is boiler plate for me and it seems to confuse everyone.

Would it be better to just say “There are no IANA considerations.” ?

Or remove the section altogether?

> 
> What are the "new entries" mentioned in this sentence? Would it be clearer to
> list them here?
> 
> Nits:
> 
> None
> 
>