Re: [nfsv4] [Gen-art] Genart last call review of draft-ietf-nfsv4-rpcrdma-cm-pvt-data-06

Alissa Cooper <alissa@cooperw.in> Wed, 19 February 2020 20:57 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CFD7D120810; Wed, 19 Feb 2020 12:57:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=pnfbPtCJ; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=WsgUel1j
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id szn35Rja-nG3; Wed, 19 Feb 2020 12:57:03 -0800 (PST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D53DE12084E; Wed, 19 Feb 2020 12:57:03 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C9ADF6EC; Wed, 19 Feb 2020 15:57:02 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 19 Feb 2020 15:57:03 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm2; bh=BvmNYTVON9BZH1g9GuFJ9A6 Jy24UjRtsVBCiO9faoKo=; b=pnfbPtCJnJ5f8838R4kayhwjqjFXSM88W5MVk7k OttmwIxK/k5/VPkf6nPZhYj9SU6ET6FzqjFTez3vyYZSs89iuKJMs64FNYONQxy+ HQC4VPTxeZf8EESncSeknwLCduoYsHSH+1zcwoxSI/IUgCcTaHknP3sRYAE9zFRG 1W4K2fu5Rs0Hi5dHE4kRHzbgzeUJFMboR3LwBG9OGwjM9jGF2TDQp6BfBu+FLIAr uBnZOmPZOqDTHAT9DOAH7TOnRCv6LL8V+zQp6oR/BnU6J39us31+kfTdjG8aYcVd 3YiNL3itkUCKIzWrG4nnS/bMam8uv9By3YUf3eXQ3zDie1A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=BvmNYT VON9BZH1g9GuFJ9A6Jy24UjRtsVBCiO9faoKo=; b=WsgUel1jpo2WnjDsU4gbr4 LCatK9vnpJkOqb1rNNmJr5HTW1oq27OGY10muDq92qHAhyuMjmBt3PK2/Xm0xWBn CzEbd5FDQEBLeg+C3VmH9TMcgcWvnfu+PyOW9lseWeKOuDREL6i8/8HLMHMBQR6F vnCbLrV94qv52kvhWQabxXwj3XBVlBYODnJ7H6uxYUfdtAazJmfEn4DgfoItUrEA d2Ov8GuMrdvVOXn5iHC8E+pTmJtOx84HutatOERz0zx0QtxOCFB4YJR8NmEfce9a aJPiR3mVPyTVSWHGqp3CO4T7KHY6ylmlbZWe+Oz6ED/dpkLEiM6I2nY+TgUqmUeg ==
X-ME-Sender: <xms:HqFNXo80xlIE-RBcYyv2wGKB1NcO14N8Uw8Pbf_p8Eue8rzhhKzDJg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkedtgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne goufhushhpvggtthffohhmrghinhculdegledmnecujfgurhephffktgggufffjgfvfhfo segrtdhmrehhtddvnecuhfhrohhmpeetlhhishhsrgcuvehoohhpvghruceorghlihhssh grsegtohhophgvrhifrdhinheqnecuffhomhgrihhnpehgihhthhhusgdrihhopdhivght fhdrohhrghenucfkphepuddtkedrhedurddutddurdelkeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfidr ihhn
X-ME-Proxy: <xmx:HqFNXhGPf5EC7jJKqX8eMqnEdCTNL_oqjMuprC1b50K6gHMpZiuGyw> <xmx:HqFNXvI9P66xk1m2U8FIT5XrmRFq5Fv2AwSflR4c_cvSy4mm9xYlvw> <xmx:HqFNXkd9fpdgMNgC413_Gv4TuiqPIsCmuT60ukaKhl3TAUgW2D4ovg> <xmx:HqFNXiAqne4BvxBfAkMwlLo7kamG94T11RUozc0AtrSBLa3Xz8m3XQ>
Received: from alcoop-m-c46z.fios-router.home (pool-108-51-101-98.washdc.fios.verizon.net [108.51.101.98]) by mail.messagingengine.com (Postfix) with ESMTPA id 26EAC3060EF2; Wed, 19 Feb 2020 15:57:01 -0500 (EST)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <553418E6-10C2-4EBA-80A9-F180E81C0152@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_CED297FC-5948-48F4-90FF-665E91EF76F8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Wed, 19 Feb 2020 15:57:01 -0500
In-Reply-To: <EF797264-71CD-49AA-9A96-AB8B68188F1E@oracle.com>
Cc: draft-ietf-nfsv4-rpcrdma-cm-pvt-data.all@ietf.org, General Area Review Team <gen-art@ietf.org>, nfsv4@ietf.org, last-call@ietf.org
To: Chuck Lever <chuck.lever@oracle.com>, Suhas Nandakumar <suhasietf@gmail.com>
References: <158015386640.23917.3626035422388212873@ietfa.amsl.com> <301328AC-ECCC-41FA-A8E5-F81A9A7FDAF9@oracle.com> <CAMRcRGR2XkudwuWczgHbF23=E6tAgrzMrUNDNTjJbVR=bmhung@mail.gmail.com> <96353CFE-9CA9-4146-83D7-310E48AD4907@oracle.com> <CAMRcRGSD2JFSf+6T8+F+HqQi6NEjhqfGNDb16R=LS74PBh4i_g@mail.gmail.com> <EF797264-71CD-49AA-9A96-AB8B68188F1E@oracle.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/qXZkZqg33xC-XvW50WQUbFKh_fM>
Subject: Re: [nfsv4] [Gen-art] Genart last call review of draft-ietf-nfsv4-rpcrdma-cm-pvt-data-06
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Feb 2020 20:57:06 -0000

Suhas, thanks for your review. Chuck, thanks for your responses. I entered a No Objection ballot.

Best,
Alissa


> On Jan 29, 2020, at 10:43 AM, Chuck Lever <chuck.lever@oracle.com> wrote:
> 
> OK. The next submitted revision will include changes resulting from
> the Gen-ART review. I'm waiting for resolution of SecDir comments
> before submitting a fresh revision.
> 
> Meanwhile, the changes so far are available to view as a diff with -06:
> 
> https://chucklever.github.io/i-d-rpcrdma-cm-pvt-data/#go.draft-ietf-nfsv4-rpcrdma-cm-pvt-data.diff <https://chucklever.github.io/i-d-rpcrdma-cm-pvt-data/#go.draft-ietf-nfsv4-rpcrdma-cm-pvt-data.diff>
> 
> 
>> On Jan 29, 2020, at 10:35 AM, Suhas Nandakumar <suhasietf@gmail.com> wrote:
>> 
>> Thanks Chuck for the additional clarification. That helped me to understand better.
>> Sorry that I missed it in my reading. 
>> 
>> Yes the suggested changes look great.
>> 
>> Cheers
>> Suhas
>> 
>> On Wed, Jan 29, 2020 at 7:23 AM Chuck Lever <chuck.lever@oracle.com> wrote:
>> 
>>> On Jan 29, 2020, at 12:03 AM, Suhas Nandakumar <suhasietf@gmail.com> wrote:
>>> 
>>> Thanks Chuck for the response. Please see inline
>>> 
>>>> On Tue, Jan 28, 2020 at 7:52 AM Chuck Lever <chuck.lever@oracle.com> wrote:
>>>> 
>>>> Zero is a permitted value for the size fields. Section 5.2 explains how
>>>> to compute the actual buffer size. If those fields contain zero, the
>>>> actual send and receive buffer sizes would be 1024 octets.
>>> 
>>> 
>>> [Suhas] I am not sure if i am reading it right here. Section 5.2 would result in the
>>> value of -1 if the min of the values is Zero (0/1024 - 1). Isn't it so ?
>> 
>> Section 5.2 says:
>> 
>>   Inline threshold sizes from 1KB to 256KB can be represented in the
>>   Send Size and Receive Size fields.  A sender computes the encoded
>>   value by dividing the actual value by 1024 and subtracting one from
>>   the result.  A receiver decodes this value by performing a
>>   complementary set of operations.
>> 
>> Here, "actual value" means the real size of the buffer. A 1024-octet
>> buffer would result in (1024 / 1024) - 1 = 0.
>> 
>> The computation done by the receiver is the inverse:
>> 
>>   (0 + 1) * 1024 = 1024
>> 
>> I could replace "actual value" by "buffer size, in octets". Would it
>> help if the text also spelled out the inverse computation?
>> 
>> 
>> --
>> Chuck Lever
>> 
>> 
>> 
> 
> --
> Chuck Lever
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org <mailto:Gen-art@ietf.org>
> https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>