Re: [nfsv4] Éric Vyncke's No Objection on draft-ietf-nfsv4-rpcrdma-cm-pvt-data-07: (with COMMENT)

"Eric Vyncke (evyncke)" <evyncke@cisco.com> Mon, 17 February 2020 21:37 UTC

Return-Path: <evyncke@cisco.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 609D4120874; Mon, 17 Feb 2020 13:37:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.521
X-Spam-Level:
X-Spam-Status: No, score=-14.521 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=lf1mStYp; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=bt5YAEvI
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ed3xrj5Haok4; Mon, 17 Feb 2020 13:37:31 -0800 (PST)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 234C3120052; Mon, 17 Feb 2020 13:37:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5720; q=dns/txt; s=iport; t=1581975451; x=1583185051; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=DEaL9JzIuRG2v3/1VtSdfFWPw0vE3B+pbz7aQvCtPrU=; b=lf1mStYpPXIfXP+6FP1uHpLfGDrwyLlAPCUAnl4Eymz9bRUfof4KKbRy 4DdrOhjxkRcGlXwnc5mLLWFDK49cHV5HBBxiZeN5zsGOUX1y/HbnNDdjL lqkIEYEmeJ1ykBAwH95fAg1PegUTBeb6wH7Dadp6KP4ypuo9igkY7NReU U=;
IronPort-PHdr: 9a23:+nnEKhyrONIQMmnXCy+N+z0EezQntrPoPwUc9psgjfdUf7+++4j5YhSN/u1j2VnOW4iTq+lJjebbqejBYSQB+t7A1RJKa5lQT1kAgMQSkRYnBZuIF1z9J/3nRyc7B89FElRi+iLzPA==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CUBQBdB0te/4oNJK1mHAEBAQEBBwEBEQEEBAEBgXuBVFAFbFggBAsqhBSDRgOKeoJfmBGBQoEQA1QJAQEBDAEBJQgCBAEBhEACF4FtJDgTAgMNAQEFAQEBAgEFBG2FNwyFZgEBAQECARIREQwBATcBDwIBCBgCAiYCAgIwFQULAgQOBSKDBAGCSgMOIAEOoWACgTmIYnWBMoJ/AQEFgUNBgzYYggwDBoEOKoUghwQagUE/gRABJyCBTn4+gmQCAQEBAYEsARIBOIJ5MoIsjWgOgmeGDZkYCoI6h02KWYQtHIJJiBaESotxg0uUDpJBAgQCBAUCDgEBBYFpImdYEQhwFWUBgkFQGA2OHQwXFYM7gmSCMIU/dAIBgSaLBIIyAQE
X-IronPort-AV: E=Sophos;i="5.70,454,1574121600"; d="scan'208";a="728383612"
Received: from alln-core-5.cisco.com ([173.36.13.138]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 17 Feb 2020 21:37:24 +0000
Received: from XCH-RCD-001.cisco.com (xch-rcd-001.cisco.com [173.37.102.11]) by alln-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id 01HLbOcu016691 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 17 Feb 2020 21:37:24 GMT
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-RCD-001.cisco.com (173.37.102.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 17 Feb 2020 15:37:23 -0600
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 17 Feb 2020 16:37:22 -0500
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 17 Feb 2020 16:37:22 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgoiJzhkIZuaJuW4XNfO0qDoU1HLn8fSZ9i2EZaWQSVUlE0hSwVkYQY93EtnQGxBxrYFIhtlTpeuiIS3gaPfuIAD+iiP2ej/c4GioeZpnRPVWrgQxwRp9bZiKqpYuOaTS8bQuJ0OuT2FsVOVqf1arDIxCT++pMpKOyVtjXMyddhm3nUXQHln0ZkjD+RnGoUzzndT3NAspMXy1t3Q8CsWQZTORkP575AcPLGDX5TYsfJzrduSzDBg30Eyb5mZIrkou3EoOAPQn14kx4ulvKVCImq3JN1LtrwWjrwsGc0wtGZaa1eKT/8Op+bCHfem7YYJPz/15bIWS/lm9+IGPVYEjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DEaL9JzIuRG2v3/1VtSdfFWPw0vE3B+pbz7aQvCtPrU=; b=N6wvbeCd52m7rIPe164RsG1+N9nNYGNmn1NANFxPaD4vbDsZgN6KiUQoFrkyT9uCMf5G0PiO+7rR3YitKXnA4g4uOapOWcJ9IY9CCir9R6g0g8jzLYUBvOzIOkuA21f5US369DAf7K/JrS/z38gBhAZImj+GzfqEnsBdQj/G6ctZuUtnpAKoWAdjAQ0hVYaB+70oQTDldutIGYZZPYZOwrvj+2W3ylQbeXM2Az5VAuICyjusEJF7DzVE2JIVzE9XvNkPFp2IYz2htK+5hH9hs3asFocmwqL+gxwumzrdWiUX9vx2RcYoeyn+mcuu6Tc5nZCjMWCJLSF+GM7lJvqWEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DEaL9JzIuRG2v3/1VtSdfFWPw0vE3B+pbz7aQvCtPrU=; b=bt5YAEvIbXfz1O8uG7X7rNechreqf/J/6nUR0m3gRr1GXpCZ3XO0DXSboseirEeDiZOGS2/KPKzIOpCy86mzV+156qy51oXduT6PmjfzuwqArmXsLIMmsvhUYaWaFEg4/MtSxAuvQyU+AbE9jPYOBTWGyni+sjYNqcJwYUlVnvI=
Received: from DM5PR11MB1753.namprd11.prod.outlook.com (10.175.88.141) by DM5PR11MB1865.namprd11.prod.outlook.com (10.175.85.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Mon, 17 Feb 2020 21:37:21 +0000
Received: from DM5PR11MB1753.namprd11.prod.outlook.com ([fe80::680d:e22e:72d5:67ca]) by DM5PR11MB1753.namprd11.prod.outlook.com ([fe80::680d:e22e:72d5:67ca%3]) with mapi id 15.20.2729.032; Mon, 17 Feb 2020 21:37:21 +0000
From: "Eric Vyncke (evyncke)" <evyncke@cisco.com>
To: Chuck Lever <chuck.lever@oracle.com>
CC: The IESG <iesg@ietf.org>, "nfsv4-chairs@ietf.org" <nfsv4-chairs@ietf.org>, "nfsv4@ietf.org" <nfsv4@ietf.org>, "draft-ietf-nfsv4-rpcrdma-cm-pvt-data@ietf.org" <draft-ietf-nfsv4-rpcrdma-cm-pvt-data@ietf.org>
Thread-Topic: [nfsv4] Éric Vyncke's No Objection on draft-ietf-nfsv4-rpcrdma-cm-pvt-data-07: (with COMMENT)
Thread-Index: AQHV5abKq3q80KevZkmkdlnmAzP4JKgf+lMA
Date: Mon, 17 Feb 2020 21:37:21 +0000
Message-ID: <8D48CD70-6C18-455F-BCAE-BEC43810F39E@cisco.com>
References: <158188978775.5805.14570069184424431737.idtracker@ietfa.amsl.com> <50BAA9D2-71E1-4BCA-A818-A5F650A4ADA5@oracle.com>
In-Reply-To: <50BAA9D2-71E1-4BCA-A818-A5F650A4ADA5@oracle.com>
Accept-Language: fr-BE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.22.0.200209
authentication-results: spf=none (sender IP is ) smtp.mailfrom=evyncke@cisco.com;
x-originating-ip: [2001:420:c0c1:36:2995:9523:c127:dacc]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 941e74f2-6ca0-4f67-c64c-08d7b3f19201
x-ms-traffictypediagnostic: DM5PR11MB1865:
x-microsoft-antispam-prvs: <DM5PR11MB1865330C5161BAE60AD566E9A9160@DM5PR11MB1865.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0316567485
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(189003)(199004)(71200400001)(966005)(4326008)(33656002)(224303003)(478600001)(2616005)(54906003)(316002)(66556008)(2906002)(6512007)(76116006)(64756008)(66476007)(66446008)(66946007)(91956017)(6916009)(66574012)(5660300002)(6486002)(36756003)(53546011)(186003)(6506007)(81166006)(81156014)(86362001)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR11MB1865; H:DM5PR11MB1753.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: FFAbSJgcHqAktBCaq6yDrQwwggdKLpS+1HOUVwr0p5J19+SScFhopj1qFYsUBjIMKEBoXXVVav6ZZyQ9wPEGVskk0GGnjiMHIWFfp5M6VhXLJVQIf80sLIQz9hnzQRcaJJUeG+Hn5mFiSNw7IhJMpRMbqFvJFszSlyvPd2eLI9Ap5QTi1H8slDfVLmWs7hthZS7y7I6xtlj8YkJR5wWUfPk7UwE5VsQ8FOICLqHogJd5YRs8+puOZtXacwrBm7Aly7wdRhv36TKNrvjaCCV3IPT9q3m7TvWVbQnsbgQ0YG2ghqVYyvGVi7WLrRRhG8WKuWj7aasxTKD3MIg/P8VCu3hPebFKcPF3rsN5t8YU1AxnFE4R/kAj9NqzShRUOFFqHVGkMnQZex8OOBs4mMpg7p4Tgv0xDy0itTBM57awCMA2ARjjdSiJLwbbJXN1XQo9GFQ8MJT86rjgZ7ZbyVRshrrsXle/+h5j26Kt1Xs/Q6EuPbPpyWRmzmD/0dscwjW+n5JTvE+mJhrLCTVW0NVbdw==
x-ms-exchange-antispam-messagedata: iSNMQUt/0INq2LfkQWWxO1WGKQYg0iM7KzX//eFS5AZIqRDpAMF1sX8gMbrDMzXF3xjhbIU0qVj8ENyE87W9QatQ1sdH56fJEEafqi/cxh23YoF5J02Ide4nBh8irWJVvQzqcG7bARhJjDi/LDsnXZIgCqwIWCm+QTr988dyMvpmhaDIH9lCY3ySVU8LHpOngAB2g0sqosiMPhl0jz1Wlg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <53F2933EB102574B8816AF66CB1E4400@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 941e74f2-6ca0-4f67-c64c-08d7b3f19201
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2020 21:37:21.3255 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NPyjwOLFBE8bFCXQFm0kqjI0euIfVSqZAkF2L446tds1TMmVzvvtpCF+sGvRUC70Nx97BInyBha7BgclLG3SxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1865
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.11, xch-rcd-001.cisco.com
X-Outbound-Node: alln-core-5.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/s7_-hdI0wpeyeWkalZ2NKkHMLcA>
Subject: Re: [nfsv4] Éric Vyncke's No Objection on draft-ietf-nfsv4-rpcrdma-cm-pvt-data-07: (with COMMENT)
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Feb 2020 21:37:33 -0000

Chuck

Thank you for your reply. 

For naming the bits in a flags field, here are some examples:
- RFC 8200 section 4.5
- RFC 4861 section 4.2
- ...

It really makes the text more readable but as written before, this is a non-blocking COMMENT only there to improve the clarity of the text.

-éric

PS: thank you for finding the É on your keyboard ;-)


On 17/02/2020, 16:27, "Chuck Lever" <chuck.lever@oracle.com> wrote:

    Hello Éric -
    
    Thanks for your comments! More responses below.
    
    
    > On Feb 16, 2020, at 4:49 PM, Éric Vyncke via Datatracker <noreply@ietf.org> wrote:
    > 
    > Éric Vyncke has entered the following ballot position for
    > draft-ietf-nfsv4-rpcrdma-cm-pvt-data-07: No Objection
    > 
    > When responding, please keep the subject line intact and reply to all
    > email addresses included in the To and CC lines. (Feel free to cut this
    > introductory paragraph, however.)
    > 
    > 
    > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
    > for more information about IESG DISCUSS and COMMENT positions.
    > 
    > 
    > The document, along with other ballot positions, can be found here:
    > https://datatracker.ietf.org/doc/draft-ietf-nfsv4-rpcrdma-cm-pvt-data/
    > 
    > 
    > 
    > ----------------------------------------------------------------------
    > COMMENT:
    > ----------------------------------------------------------------------
    > 
    > Thank you for the work put into this document. I found this document not so
    > easy to read as many acronyms are used without expansion (Stag, CM, ...)
    > notably in the abstract. While the introduction simply refers to RFC 8166, a
    > little more textual introduction would have been welcome.
    
    The document assumes the reader is already knowledgeable about this specific
    domain, true enough. I'm open to specific suggestions of what could be added
    to the Introduction to assist readers less familiar with the topic. I'm never
    sure how far back to start an Introduction section.
    
    Barry Leiba has already pointed out several unexpanded acronyms that I have
    corrected for the next revision. These include XDR, STag, RNIC, and the
    reference to RDMA-CM in the Abstract.
    
    Btw, here's what's been done to the document since -07:
    
    https://chucklever.github.io/i-d-rpcrdma-cm-pvt-data/#go.draft-ietf-nfsv4-rpcrdma-cm-pvt-data.diff
    
    
    > Nevertheless, please find below some non-blocking COMMENTs (and I would
    > appreciate a response from the authors but this is not required).
    > 
    > I hope that this helps to improve the document,
    > 
    > Regards,
    > 
    > -éric
    > 
    > == COMMENTS ==
    > 
    > -- Section 4 --
    > Just by sheer curiosity, I wonder where the value "0xf6ab0e18" comes from ?
    
    I used the center 32 bits of a randomly-generated uuid, iirc.
    
    
    > -- Section 4.1.1 --
    > "bit 15 of the Flags field" but the Flags field is only 8-bit long (to be
    > honest, I am sure that I understand the meaning of this but being clearer would
    > be better). Wording in section 5.1 should be used in section 4 when describing
    > the Flags field.
    
    > I would also suggest to name the different bits of the Flags field as usually
    > done in other IETF documents.
    
    Seeing an example or two would help me pick a name consistent with other IETF
    publications. Please send one my way if you have a favorite.
    
    If I define a name for the one flag used in Version 1, then Section 4.1.1 can
    refer to that flag by name instead of "bit 15 of the Flags field".
    
    Perhaps Section 5.1 should be moved to Section 4 as well.
    
    
    > -- Section 5.1 --
    > About the reserved bits, why not using the usual wording of "set to 0 when
    > sending and ignored when received" ?
    
    Barry also commented on this. See Section 5.1 in the pending revised draft
    above for the corrected text.
    
    
    --
    Chuck Lever