IETF Logo Mail Archive

Re: [nfsv4] [pnfs] [PATCH 1/1] pnfsd: DLM file layout only support read iomode layouts

"William A. (Andy) Adamson" <androsadamson@gmail.com> Wed, 16 December 2009 16:18 UTC

Return-Path: <androsadamson@gmail.com>
X-Original-To: nfsv4@core3.amsl.com
Delivered-To: nfsv4@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 971453A69DE for <nfsv4@core3.amsl.com>; Wed, 16 Dec 2009 08:18:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a-z8Dvkgch4s for <nfsv4@core3.amsl.com>; Wed, 16 Dec 2009 08:18:16 -0800 (PST)
Received: from mail-yx0-f192.google.com (mail-yx0-f192.google.com [209.85.210.192]) by core3.amsl.com (Postfix) with ESMTP id 9A2563A6A05 for <nfsv4@ietf.org>; Wed, 16 Dec 2009 08:18:16 -0800 (PST)
Received: by yxe30 with SMTP id 30so1227408yxe.29 for <nfsv4@ietf.org>; Wed, 16 Dec 2009 08:17:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=WTkXoBIW0xSXA7wFsspSJDwTr5d5PruJEruEz1QOKQg=; b=ry+avXHPmuasEv4Bvv+7+IMXNOv9H8Qm/AhfF6ZfM/sIlr+/xBX5Vx3OCJN2CSEM8b /8xfwYy6ZNVIvPhvZwMvH/s1tpK6Not0cEnPnZSfvcDF2VJ+o7C602J1F33pIfdU4qE7 gMWxDUgUbwFg+wHyAqcMU1M9oR0XRGS3llDi4=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=UgwHw9QgE5DQnQaC1TSE/aHWMlsoEHBr+YrfL/ya3LTGtlXnGbtPLJ3+SkcfjJkUoU 0Yb6S3JbkD9ARFC268PW1YoTtiksD/aOG+vaIdDpe0Fyu+hjDemBf3OAR2CBPq3TIRK9 wWlFW+r9hJA5sskZiRTBQDy1D5QBOBotH32zY=
MIME-Version: 1.0
Received: by 10.150.109.25 with SMTP id h25mr1917229ybc.257.1260980279430; Wed, 16 Dec 2009 08:17:59 -0800 (PST)
In-Reply-To: <4B2901FC.1060203@panasas.com>
References: <1260907434-7484-1-git-send-email-andros@netapp.com> <1260907434-7484-2-git-send-email-andros@netapp.com> <20091215224155.GF8686@fieldses.org> <4B28D006.4000409@panasas.com> <89c397150912160726l65469d9nb3df68d06fdc190d@mail.gmail.com> <20091216153740.GA23117@fieldses.org> <89c397150912160742x2b57e31cp7b5b4fd36d6566fd@mail.gmail.com> <4B2901FC.1060203@panasas.com>
Date: Wed, 16 Dec 2009 11:17:59 -0500
Message-ID: <89c397150912160817x79ad4852n98246904e6f0490d@mail.gmail.com>
From: "William A. (Andy) Adamson" <androsadamson@gmail.com>
To: Benny Halevy <bhalevy@panasas.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: "J. Bruce Fields" <bfields@fieldses.org>, pnfs@linux-nfs.org, NFSv4 <nfsv4@ietf.org>
Subject: Re: [nfsv4] [pnfs] [PATCH 1/1] pnfsd: DLM file layout only support read iomode layouts
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/nfsv4>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Dec 2009 16:18:17 -0000

On Wed, Dec 16, 2009 at 10:51 AM, Benny Halevy <bhalevy@panasas.com> wrote:
> On Dec. 16, 2009, 17:42 +0200, "William A. (Andy) Adamson" <androsadamson@gmail.com> wrote:
>> On Wed, Dec 16, 2009 at 10:37 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
>>> On Wed, Dec 16, 2009 at 10:26:57AM -0500, William A. (Andy) Adamson wrote:
>>>> On Wed, Dec 16, 2009 at 7:18 AM, Benny Halevy <bhalevy@panasas.com> wrote:
>>>>> 15.1.10.4.  NFS4ERR_LAYOUTUNAVAILABLE (Error Code 10059)
>>>>>
>>>>>   Returned when layouts are not available for the current file system
>>>>>   or the particular specified file.
>>>>>
>>>>> NFS4ERR_BADIOMODE seems to make more sense since layouts are available,
>>>>> just not for the requested iomode. However its definition indicates that
>>>>> the iomode in the client request is "invalid or inappropriate".
>>>>> It is not clear what "inappropriate" means in this context.
>>>> What difference does 'what inappropriate means' make to the client?
>>>> None! It's up to the server.
>>> We do have to worry how clients will react to the error:
>>>
>>>        - If clients really assume that this error can only result from
>>>          a bug, then they may choose to return an IO error to the
>>>          application, turn off pnfs entirely for this server, or
>>>          something similarly drastic.
>>
>> Then that client implementation won't be used for very long. This is
>> Darwin in action!
>>
>>>        - If they assume it means that the server doesn't feel like
>>>          giving out a layout of that iomode right now, then we're good.
>>>
>>> You're probably right that the latter is a reasonable interpretation of
>>> "inappropriate".
>>>
>>> However, the spec isn't entirely explicit about this, and the only
>>> specific example given of BADIOMODE use is an "invalid" case (client
>>> supplying IOMODE4_ANY on getlayout), so I think it would be easy for a
>>> client to get this wrong.
>>
>> Perhaps. Linux doesn't. What does the only other client (Solaris) do?
>>
>
> I'm not sure that matters much.  The fact that we got it wrong
> and it wasn't obvious for us what error the server should have returned
> is a pretty good indication that the spec isn't clear about it.

ummm - we got it right!

-->Andy

>
> Benny
>
>> -->Andy
>>
>>> --b.
>>>
>

v2.23.0 | Report a Bug | By Email