[nfsv4] draft-ietf-nfsv4-umask

Thomas Haynes <loghyr@primarydata.com> Tue, 22 August 2017 20:36 UTC

Return-Path: <loghyr@primarydata.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5B3B132A30 for <nfsv4@ietfa.amsl.com>; Tue, 22 Aug 2017 13:36:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=primarydata.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iKZZbADcS9Ui for <nfsv4@ietfa.amsl.com>; Tue, 22 Aug 2017 13:36:48 -0700 (PDT)
Received: from us-smtp-delivery-194.mimecast.com (us-smtp-delivery-194.mimecast.com [63.128.21.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9E037132A39 for <nfsv4@ietf.org>; Tue, 22 Aug 2017 13:36:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=primarydata.com; s=mimecast20170802; t=1503434205; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding; bh=oIRPXCs2wKx9ZIPuB7Qs6ensmV5DePx4ooTa0ozKOnE=; b=gd8tbDKFGGH6eibbEmSNVBduJcnvLxIsPLMzWcxeh739D1pKmpll+WhUr1MBR8F6atud+CE4EpR0arEUtHbvFsvqIlMd9CCCwI8XoViUiIr+sIyrE+eJ1JEftN3M7ToVon1moH7DUx1KXXm0CCbN/IilKFPaodzJjix+myRsCA0=
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02lp0052.outbound.protection.outlook.com [207.46.163.52]) (Using TLS) by us-smtp-1.mimecast.com with ESMTP id us-mta-178-mKArDuXkMdSOll1HDxzi0Q-1; Tue, 22 Aug 2017 16:36:43 -0400
Received: from BY2PR1101MB1093.namprd11.prod.outlook.com (10.164.166.21) by BY2PR1101MB1128.namprd11.prod.outlook.com (10.164.166.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Tue, 22 Aug 2017 20:36:39 +0000
Received: from BY2PR1101MB1093.namprd11.prod.outlook.com ([10.164.166.21]) by BY2PR1101MB1093.namprd11.prod.outlook.com ([10.164.166.21]) with mapi id 15.01.1362.019; Tue, 22 Aug 2017 20:36:39 +0000
From: Thomas Haynes <loghyr@primarydata.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
CC: "nfsv4@ietf.org" <nfsv4@ietf.org>
Thread-Topic: draft-ietf-nfsv4-umask
Thread-Index: AQHTG4ZaSLBKhn8460yMUEjjBWHHYw==
Date: Tue, 22 Aug 2017 20:36:38 +0000
Message-ID: <CCE6471D-5252-4313-BDED-5EAA468E3FAA@primarydata.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [63.157.6.18]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BY2PR1101MB1128; 20:Liq5sU75fPQ07pJhbxhwjDZMl7UG/SNrEjogrdW2YM7yVjE8Gd9JXH0s3IfdXZ85dhUdw6ev0SRPJUYBculkg5dyeAd36JF9Zueqws/AMH3O0ehEfV61sVbOlG0YwoU1yuaiQbR/TVCOQlkDPr5lOOKLps59x8c7esMWO00Z8+o=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: 9f619d4b-79fd-4058-fc39-08d4e99d7d88
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(2017052603173)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR1101MB1128;
x-ms-traffictypediagnostic: BY2PR1101MB1128:
x-exchange-antispam-report-test: UriScan:;
x-microsoft-antispam-prvs: <BY2PR1101MB1128EEC2D49134B70C45ABA5CE840@BY2PR1101MB1128.namprd11.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123562025)(20161123558100)(20161123560025)(2016111802025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(6043046)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR1101MB1128; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR1101MB1128;
x-forefront-prvs: 04073E895A
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39830400002)(199003)(189002)(3660700001)(14454004)(6916009)(7736002)(8676002)(68736007)(82746002)(478600001)(305945005)(83716003)(97736004)(189998001)(3280700002)(36756003)(2906002)(25786009)(2900100001)(101416001)(4326008)(6486002)(77096006)(6116002)(33656002)(6506006)(86362001)(50986999)(54356999)(105586002)(106356001)(6436002)(53936002)(81166006)(3846002)(99286003)(110136004)(81156014)(5660300001)(6512007)(230783001)(102836003)(66066001)(8936002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR1101MB1128; H:BY2PR1101MB1093.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:3; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-ID: <2E61B0E7DA4DC64BAB0CF9DF65E5AE2B@namprd11.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: primarydata.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2017 20:36:38.9474 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR1101MB1128
X-MC-Unique: mKArDuXkMdSOll1HDxzi0Q-1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/yFLRlHb-SwDZP8GNSe5kWRF8Jm8>
Subject: [nfsv4] draft-ietf-nfsv4-umask
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Aug 2017 20:36:51 -0000

Hi Bruce,

Can you modify your draft such that it generates xdr?

I.e., I went to add a new const for your new attribute, and unlike the xattr document, I had to guess:

%/*
% * New For UMASK
% */
const FATTR4_MODE_UMASK         = 81;

Iā€™d recommend that you add the ā€˜///ā€˜.

Also, you should use the <CODE BEGINS> and <CODE ENDS> at the very least here:

4.  mode_umask Attribute


         struct mode_umask4 {
           mode4  mu_mode;
           mode4  mu_umask;
         };


Thanks,
Tom