Re: [Ntp] Review of the YANG data model for NTP

Hal Murray <hmurray@megapathdsl.net> Wed, 22 January 2020 23:11 UTC

Return-Path: <hmurray@megapathdsl.net>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E55161200FD for <ntp@ietfa.amsl.com>; Wed, 22 Jan 2020 15:11:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.035
X-Spam-Level: *
X-Spam-Status: No, score=1.035 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_DYNAMIC_IPADDR=1.951, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XV4UbvL8nq1V for <ntp@ietfa.amsl.com>; Wed, 22 Jan 2020 15:11:56 -0800 (PST)
Received: from ip-64-139-1-69.sjc.megapath.net (ip-64-139-1-69.sjc.megapath.net [64.139.1.69]) by ietfa.amsl.com (Postfix) with ESMTP id 8208512003F for <ntp@ietf.org>; Wed, 22 Jan 2020 15:11:56 -0800 (PST)
Received: from shuksan (localhost [127.0.0.1]) by ip-64-139-1-69.sjc.megapath.net (Postfix) with ESMTP id 8DF9A40605C; Wed, 22 Jan 2020 15:11:55 -0800 (PST)
X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.3
To: "Dieter Sibold" <dsibold.ietf@gmail.com>
cc: ntp@ietf.org, hmurray@megapathdsl.net
From: Hal Murray <hmurray@megapathdsl.net>
In-Reply-To: Message from "Dieter Sibold" <dsibold.ietf@gmail.com> of "Wed, 22 Jan 2020 20:43:11 +0100." <DFD7A4A8-06FC-403C-89EF-CF08CA3E12CE@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 22 Jan 2020 15:11:55 -0800
Message-Id: <20200122231155.8DF9A40605C@ip-64-139-1-69.sjc.megapath.net>
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/NE112J4dvL6e9Wzym0w8013lInc>
Subject: Re: [Ntp] Review of the YANG data model for NTP
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2020 23:11:58 -0000

It's 50 pages.  I hope you aren't surprised that you aren't getting a lot of 
detailed feedback.

I don't know anything about YANG so I'm missing the big picture of what this 
is trying to accomplish and/or why I should be interested.  I am familiar with 
some NTP implementation.  I work on ntpsec.

It looks good if that is what you want.  I can't say anything about 
completeness.

Some/many of the counters are using a type of counter32.  We changed a few 
counters to 64 bits because we got a report that 32 bits had overflowed.

We dropped mode 7 (ntpdc)  which had a lot of binary encodings and 
reimplemented the functionally we wanted in mode 6 (ntpq) which is mostly 
text.  If numbers are sent as text the 32/64 doesn't matter.

I think there will always be corner cases on some of the slots where the fine 
print in the description will be "look at the code".  If a received packet 
fails authentication, does it get counted with the target association?  Was it 
a damaged packet for that association or an attempted forgery?

I think an important section would be how to keep things up to date and/or how 
to accommodate new features.  (I didn't find that section but I could easily 
have overlooked it.)  The obvious example is counters for NTS.
 
--------

Is state singular or plural?

  information about running state
  Operational State is included
  the operational state also include

I expected a "the" on the first one, and "includes" on the last one.  The 
middle looks right to me.


-- 
These are my opinions.  I hate spam.