Re: [Ntp] draft-ietf-ntp-roughtime-05: tag change makes implementation more complex

Danny Mayer <mayer@pdmconsulting.net> Wed, 22 September 2021 15:00 UTC

Return-Path: <mayer@pdmconsulting.net>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BFCF83A25B3 for <ntp@ietfa.amsl.com>; Wed, 22 Sep 2021 08:00:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 31bWZjz0UbNX for <ntp@ietfa.amsl.com>; Wed, 22 Sep 2021 08:00:12 -0700 (PDT)
Received: from chessie.everett.org (chessie.everett.org [IPv6:2001:470:1:205::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 652F13A25A1 for <ntp@ietf.org>; Wed, 22 Sep 2021 08:00:01 -0700 (PDT)
Received: from newusers-MBP.fios-router.home (pool-108-26-179-179.bstnma.fios.verizon.net [108.26.179.179]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by chessie.everett.org (Postfix) with ESMTPSA id 4HF1fy114YzMNQY; Wed, 22 Sep 2021 14:59:54 +0000 (UTC)
To: Marcus Dansarie <marcus@dansarie.se>, ntp@ietf.org
Cc: JP Sugarbroad <taralx@gmail.com>
References: <CAGZkp1-ZCuSvMyQyWCnE511O8-WL=OXfsTdraKsByMmWC3spVA@mail.gmail.com> <CACsn0ckZmR=k2NAmdyhVOA=V_XQ18AnBUBSTOu+bDXS1YsPpUg@mail.gmail.com> <CAGZkp18eASaF7qvubYpDgzvg643ZXuPwDs9qsiC1P_AVLcywLA@mail.gmail.com> <CACsn0cnjHFwxHT13nMavRFzRteWJ=SORY8v4RCZjdjYP0H3oaw@mail.gmail.com> <7dde7eb3-4dc7-94d3-e63a-6d5d0736b1c2@pdmconsulting.net> <54baf1fa-b138-4eb8-6f4e-99168cf2db7b@dansarie.se>
From: Danny Mayer <mayer@pdmconsulting.net>
Message-ID: <0a95d35f-f708-4a3c-4ecf-77597c42a7a4@pdmconsulting.net>
Date: Wed, 22 Sep 2021 10:59:53 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <54baf1fa-b138-4eb8-6f4e-99168cf2db7b@dansarie.se>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/SLmDrPzMccgXOpDLqULaJeNCXi0>
Subject: Re: [Ntp] draft-ietf-ntp-roughtime-05: tag change makes implementation more complex
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Time Protocol <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Sep 2021 15:00:23 -0000

On 9/21/21 3:24 PM, Marcus Dansarie wrote:
> I'll hijack this thread in an attempt to answer a number of related
> Roughtime questions in the same place. Apologies in advance for that.
>
> On 2021-09-21 16:27, Danny Mayer wrote:
>> It would be helpful if you explained why you changed it in the first
>> place. I assume you had a good reason to do so.
> I was the one to initially suggest terminating the PAD tag with zeros
> instead of ones (0xff) back in 2019:
>
>> The PAD tag key is encoded as PAD\xff, while the SIG tag key is
>> encoded as SIG\x00. For consistency, this should be changed so that
>> both are terminated with \x00. Additionally, terminating the tag keys
>> with the NULL character will make displaying them easier on many
>> platforms.
> In short, terminating all "ASCII-style" tags shorter than four
> characters with zeros allows for unambiguous translation into 32-bit
> integer tags. The entire message is archived at:
> https://mailarchive.ietf.org/arch/msg/ntp/BSYmaFGoEYHNECg2Mc2qgjzQZh4/

It would make more sense to make all of the tags 4 ascii characters and 
be done with it. I also don't understand the need for PAD and that the 
message has to be at least 1024 bytes in length. The length of the 
message is included in the packet so such a requirement is unnecessary.

Danny