Re: [Ntp] Roman Danyliw's No Objection on draft-ietf-ntp-yang-data-model-15: (with COMMENT)

Dhruv Dhody <dhruv.ietf@gmail.com> Thu, 09 December 2021 17:01 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 10F843A0FC2; Thu, 9 Dec 2021 09:01:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T57ZPO-PrPQW; Thu, 9 Dec 2021 09:00:59 -0800 (PST)
Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6104E3A0FCF; Thu, 9 Dec 2021 09:00:59 -0800 (PST)
Received: by mail-il1-x135.google.com with SMTP id w1so5897255ilh.9; Thu, 09 Dec 2021 09:00:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lGM2I+4uUJf5p3Wh4BD4pRuCa+bN+nLgTtZ1xGebUs8=; b=cVqhLRk44vCRU3iTEonqs/G+DDcU6KLC3zY9VB547raAKu2AY9VFCHhFzszKESih8U Ep5is1hY1fzwvN9s0mpfRbbC8oX1J2q82Q/UR6JZlxM5FD0IUkZpUpJWD1XUvQenhBe7 /Iz9zpBJv4Kqlb3CUFQQajV6hhzafizP1OITBJbqD5Rzx3nb9wKr8fGkVQn3I0fbmPNs 21vhH4ke/XJe7w51/KWA6nFKNXLqPr63pRkaIY/jo9TBuELKGDp3FclhKQC1XQZonhcV GdDqok7J8B3nbxP9YWxQA3juSNj8LIiXQO5qLkJaibfqsq1sj9Xbp4c20CWeBbqJmOqV mqlw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lGM2I+4uUJf5p3Wh4BD4pRuCa+bN+nLgTtZ1xGebUs8=; b=pCiWjStRemzQcXltyg5nUmkiZdMeItpCcHaVb7ZIduSmdG7n1W5T/3QZgoUeE6zR2M 9uE8R11yXVQhGvL2+CmdzApZWuR5j2yV7KZpEGwAfjks2tKE4t1fCqcLR/Bkf6+KikyY lBJBD/e9eQlrt0806IGgyEStp0XGPeHkuN5V5Qcze+a9E67X34j/0BC3JGP5FnJZKkd4 BOSFzWYcbhFO+dlM6A296DjAB6F68FLM61DDNywnwWaMs51dX9NGFQAR6IR10qEZitr8 lWJNugHx98CO8ikcq+umJ5ybMeFIp/X/jlF6/iEqicdpOtqg34ffhEwoNSjKt+5t4o0U 6WWw==
X-Gm-Message-State: AOAM531Hl6Kcuy9n7Gliq+OSDOlFev0wNpfB9NGRXxM7zYxuKa2QhALk CJldNKFWS7nHfGhbtv8Jy6o6UgwmRJqVcKtsZsU=
X-Google-Smtp-Source: ABdhPJysCKThb7TZuVJu1HEAgT2gx7/ETeyrfkVfQ26xy5HNhINoNnwxZcurX/LX3wVWdc6fiNAlgmryqHxR2fRWXqU=
X-Received: by 2002:a05:6e02:144f:: with SMTP id p15mr15813539ilo.180.1639069257843; Thu, 09 Dec 2021 09:00:57 -0800 (PST)
MIME-Version: 1.0
References: <162492349668.31080.1334454060517597879@ietfa.amsl.com>
In-Reply-To: <162492349668.31080.1334454060517597879@ietfa.amsl.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Thu, 9 Dec 2021 22:30:21 +0530
Message-ID: <CAB75xn6YaoAa+mb7RxqAGhRpLKWOb1qXWjQbAG+6NkfkDShxhg@mail.gmail.com>
To: Roman Danyliw <rdd@cert.org>
Cc: The IESG <iesg@ietf.org>, draft-ietf-ntp-yang-data-model@ietf.org, ntp-chairs@ietf.org, NTP WG <ntp@ietf.org>, Dieter Sibold <dsibold.ietf@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000e079f605d2b98c0d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/UespS8hrxN61KrUlBxQZKhULGwU>
Subject: Re: [Ntp] Roman Danyliw's No Objection on draft-ietf-ntp-yang-data-model-15: (with COMMENT)
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Time Protocol <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Dec 2021 17:01:04 -0000

Hi Roman,

Firstly let me apologize for this very late reply. Secondly thanks for your
review. I was finally able to make all the changes.

On Tue, Jun 29, 2021 at 5:08 AM Roman Danyliw via Datatracker <
noreply@ietf.org> wrote:

> Roman Danyliw has entered the following ballot position for
> draft-ietf-ntp-yang-data-model-15: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-ntp-yang-data-model/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Thank you to Takeshi Takahashi for the SECDIR review.
>
> ** YANG.  feature deprecated.  Typo. s/availaible/available/
>
>
Dhruv: ACK



> ** YANG.  Crypto algorithms. AES-CMAC has a reference but the others
> don’t.
> Consider adding them.
>
>
Dhruv:ACK, added FIPS PUB 180-4


> ** Section 9.1. Typo. s/would used the an/would use an/
>
>
Dhruv:ACK


> ** Section 11.
>
> A few clarifying items on describing the sensitivity of nodes:
>
> For writable nodes:
> -- /ntp/authentication/authentication-keys:  The entries in the list
> includes
> all the NTP authentication keys.  Altering this list could cause a
> disruption
> for clients and peers (for servers); or prevent a client from accessing a
> server.
>
> For readable notes:
>
> -- /ntp/authentication/authentication-keys. Recommend being clearer on the
> risk:
>
> s/can be exploited/can be exploited to permit unauthorized access to the
> NTP
> service/
>
> -- /ntp/authentication and /ntp/access-rules - The entries in the list
> include
> the authentication and access control configurations.  Exposure of these
> nodes
> could reveal network topology or trust relationship.
>
>
>
Dhruv: Made an update to the section.

Thanks!
Dhruv

Diff:
https://www.ietf.org/rfcdiff?url1=draft-ietf-ntp-yang-data-model-15&url2=https://raw.githubusercontent.com/dhruvdhody/ietf/master/draft-ietf-ntp-yang-data-model-16.txt
Working Copy:
https://raw.githubusercontent.com/dhruvdhody/ietf/master/draft-ietf-ntp-yang-data-model-16.txt

Consolidated Review Status:
https://notes.ietf.org/draft-ietf-ntp-yang-data-model