[Ntp] [Errata Verified] RFC5905 (5978)

RFC Errata System <rfc-editor@rfc-editor.org> Mon, 26 September 2022 00:14 UTC

To: david.verbree@dornerworks.com, mills@udel.edu, jrmii@isc.org, jack.burbank@jhuapl.edu, william.kasch@jhuapl.edu
From: RFC Errata System <rfc-editor@rfc-editor.org>
Cc: ek.ietf@gmail.com, iesg@ietf.org, ntp@ietf.org, iana@iana.org, rfc-editor@rfc-editor.org
Content-Type: text/plain; charset="UTF-8"
Message-Id: <20220926001357.20FA64C956@rfcpa.amsl.com>
Date: Sun, 25 Sep 2022 17:13:57 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/XzWihQs9IGMn--wgTJw9D1U0_ME>
Subject: [Ntp] [Errata Verified] RFC5905 (5978)
Precedence: list

The following errata report has been verified for RFC5905,
"Network Time Protocol Version 4: Protocol and Algorithms Specification". 

--------------------------------------
You may review the report below and at:
https://www.rfc-editor.org/errata/eid5978

--------------------------------------
Status: Verified
Type: Technical

Reported by: David Verbree <david.verbree@dornerworks.com>
Date Reported: 2020-02-08
Verified by: Erik Kline (IESG)

Section: A.5.1.1.

Original Text
-------------
    /*
        * Verify valid root distance.
        */
    if (r->rootdelay / 2 + r->rootdisp >= MAXDISP || p->reftime >
        r->xmt)
            return;                 /* invalid header values */


Corrected Text
--------------
    /*
        * Verify valid root distance.
        */
    if (p->rootdelay / 2 + p->rootdisp >= MAXDISP || p->reftime >
        r->xmt)
            return;                 /* invalid header values */


Notes
-----
The r->rootdelay and r->rootdisp are the received values not in double format and therefore, should not be compared against MAXDISP. Use the p->rootdelay and p->rootdisp instead which have already been converted to double via FP2D macro.

---

[verifier notes]

See also https://mailarchive.ietf.org/arch/msg/ntp/Cbg3sOhChyfenYoj7UG5wCymFMU/

--------------------------------------
RFC5905 (draft-ietf-ntp-ntpv4-proto-13)
--------------------------------------
Title               : Network Time Protocol Version 4: Protocol and Algorithms Specification
Publication Date    : June 2010
Author(s)           : D. Mills, J. Martin, Ed., J. Burbank, W. Kasch
Category            : PROPOSED STANDARD
Source              : Network Time Protocols
Area                : Internet
Stream              : IETF
Verifying Party     : IESG

[Ntp] [Errata Verified] RFC5905 (5978) RFC Errata System