Re: [Ntp] Francesca Palombini's Discuss on draft-ietf-ntp-yang-data-model-15: (with DISCUSS and COMMENT)

Dhruv Dhody <dhruv.ietf@gmail.com> Thu, 09 December 2021 16:59 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 90E9E3A0FC2; Thu, 9 Dec 2021 08:59:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tKosAG6wS4AT; Thu, 9 Dec 2021 08:59:37 -0800 (PST)
Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 56B0C3A0FC4; Thu, 9 Dec 2021 08:59:37 -0800 (PST)
Received: by mail-il1-x132.google.com with SMTP id 15so5952830ilq.2; Thu, 09 Dec 2021 08:59:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qq0lVixO8RrtjryonqCNQUQLTsqEa5sjSMre+5F6zUY=; b=A4wHTRXqFNgDHf84a09AM4gMsAc8J41SaKlo7buf2UKnrFOSqv89daYPUkqOFVz4gU Uyt6J/UOXzoNy4467FaZ1m0B+DWgY44uHdczag631znVrufORFf95YiZac8tGhykDm7n wUxyw+6ka4LDMHt0VLh2D9tGkvTofF3BiHCgsDgCLkLjoo8wW5c9hz+N8qNT1FAHZGgk mP+iZAziU6zy8lPSYs/PUFwQueP+XNYy51bbbD4b8fdmbMNafLHeT29T68e/aYF+zQ9r u3+bVMzsu43OX9Soa0j4Jiv2Me+QUWb0TJqbo//KpHPqhvwMrjkNvXz8FaJ2Eaz+BL5n xK0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qq0lVixO8RrtjryonqCNQUQLTsqEa5sjSMre+5F6zUY=; b=jd6RxpdQTU3hE34AX+F1luHqLjfwt4jsWwFyxAv1xF2opEvwM0A3pl0bbn4pnTm7f9 lizAShOxg4HHkiPeuz8n/kqrlcxrfHTpgmHKHwEnyode75SBFxGxiGrQwqZVeJTYgL0j 6KvU77+1qLWBSnCEBzeGDHOxzkZqsEdpKnbZ8u8/hGRG1J0spnx9tEWTgqo+dh6HffAb TP0/h+j2q04xXOyIWqHyyWnopCXTTeB67fJhZGNExzchNHZsOuJ+973cksgFp39WpmJR enZCZzThcYjubJXLyvaOn/6XVWSHxrECqL/R9DrVKeAUAt4dkO0GggCH24m17S2pmSrX ZTKw==
X-Gm-Message-State: AOAM532SrKYls2uVYhp9GTAiV+nRY4nRu113algBCvwe/Mh2+Eqn1mt8 WS0E4QkBgSF3PhqLBS9P5QyMCuhmCkk4/qZPFFM=
X-Google-Smtp-Source: ABdhPJyGVdxFMxZXDjZbEnNfw9DOEmijvGoaCLlf8Gb3aopN3AK6gqp1n+T3fheq8g3gabRtCmrIndKYgCImkastgX4=
X-Received: by 2002:a92:c012:: with SMTP id q18mr15587234ild.216.1639069175974; Thu, 09 Dec 2021 08:59:35 -0800 (PST)
MIME-Version: 1.0
References: <162506975525.16899.10820299795831774115@ietfa.amsl.com>
In-Reply-To: <162506975525.16899.10820299795831774115@ietfa.amsl.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Thu, 9 Dec 2021 22:28:59 +0530
Message-ID: <CAB75xn5BRac9phcx7J1Lezfb=ff_HAQGxJ3Ykaid1tqGVSTe2w@mail.gmail.com>
To: Francesca Palombini <francesca.palombini@ericsson.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-ntp-yang-data-model@ietf.org, ntp-chairs@ietf.org, NTP WG <ntp@ietf.org>, Dieter Sibold <dsibold.ietf@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000ff0eff05d2b9871e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/d_ikPvy03YLGFVei1yQm6d8ZRKM>
Subject: Re: [Ntp] Francesca Palombini's Discuss on draft-ietf-ntp-yang-data-model-15: (with DISCUSS and COMMENT)
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Time Protocol <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Dec 2021 16:59:42 -0000

Hi Francesca,

Firstly let me apologize for this very late reply. Secondly thanks for your
review. I was finally able to make all the changes.

On Wed, Jun 30, 2021 at 9:45 PM Francesca Palombini via Datatracker <
noreply@ietf.org> wrote:

> Francesca Palombini has entered the following ballot position for
> draft-ietf-ntp-yang-data-model-15: Discuss
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-ntp-yang-data-model/
>
>
>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> Thank you for the work on this document.
>
> I have a simple-to-solve DISCUSS point, and some non blocking comments.
>
> Francesca
>
>
> 1. -----
>
>         leaf clock-precision {
>           type int8;
>           units "Hz";
>
> FP: I believe the units should be seconds here.
>
>
Dhruv: The Hz was incorrect. BTW I am using a new typedef log2seconds now
(as per Ben's DISCUSS).



>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> 2. -----
>
>   typedef ntp-date-and-time {
>     type union {
>       type yang:date-and-time;
>       type uint8;
>     }
>     description
>       "Follows the normal date-and-time format when valid value
>        exist, otherwise allows for setting special value such as
>        zero.";
>
> FP: I'd rather the document avoided the term "normal", which could be just
> removed. Also, could a 'reference' be added, pointing to RFC 6991?
>
>
Dhruv: Agreed and updated.



> 3. -----
>
>         "The association was configured or dynamic
>          which result in clock synchronization.";
>
> FP: This sentence doesn't parse correctly for me. Is there any text
> missing? Or
> maybe a wrong copy paste?
>
>
Dhruv: Updated to - "Indicates if the association (that resulted in the
clock synchronization) is explicitly configured."



> 4. -----
>
>       description
>         "Configuration to control access to NTP service
>          by using NTP access-group feature.
>          The access-mode identifies how the acl is
>          applied with NTP.";
>
> FP: (here and other places) please make sure the capitalization of ACL is
> consistent in the descriptions and in the text of the doc.
>
>
> Dhruv: Ack.

Thanks!
Dhruv

Diff:
https://www.ietf.org/rfcdiff?url1=draft-ietf-ntp-yang-data-model-15&url2=https://raw.githubusercontent.com/dhruvdhody/ietf/master/draft-ietf-ntp-yang-data-model-16.txt
Working Copy:
https://raw.githubusercontent.com/dhruvdhody/ietf/master/draft-ietf-ntp-yang-data-model-16.txt

Consolidated Review Status:
https://notes.ietf.org/draft-ietf-ntp-yang-data-model