Re: [Ntp] [Technical Errata Reported] RFC5905 (6550)

Erik Kline <ek.ietf@gmail.com> Mon, 19 April 2021 04:26 UTC

Return-Path: <ek.ietf@gmail.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 066413A1D37 for <ntp@ietfa.amsl.com>; Sun, 18 Apr 2021 21:26:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.197
X-Spam-Level:
X-Spam-Status: No, score=-0.197 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sXz1u2sYS3ou for <ntp@ietfa.amsl.com>; Sun, 18 Apr 2021 21:26:36 -0700 (PDT)
Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 53B863A1D31 for <ntp@ietf.org>; Sun, 18 Apr 2021 21:26:36 -0700 (PDT)
Received: by mail-oi1-x232.google.com with SMTP id i81so34255921oif.6 for <ntp@ietf.org>; Sun, 18 Apr 2021 21:26:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2HhukdmKnE8pAxarsleQ5slJSJ0W4myXbJkkYoSo4aU=; b=a7zXLh+zJnR4piJ/dEFpkcYMx9sXx9hu3hYPZ0XrreSY2rJ5aJd4d0QL3fNXnI+Xa0 nrM0nJCaJNhb7OR2XRGNeZ/tGvxWpqbluvzZe5Q3KkcwLbsIAq6SGuGaXPLfJrEYdkNo Md2lhnBcxEW/lrYrbslNx72HytmBqdjd0KxMJmEx4M6YSZZxa0jgCGj5xhp/GUilMLAc S1KBHg5mN3XdbDkXp41JzkMnC21mwtLm2VKWCRlENQ2tGDawnm/5UAPFQD6RgIcl/3k3 8XaYo+XZ25Q7kbc87GqSWhZ3nY1K/gw2hFhcLup86hcSxUi8VqTbeFHApYZ4IYEiUZG/ jVkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2HhukdmKnE8pAxarsleQ5slJSJ0W4myXbJkkYoSo4aU=; b=TTqXgp3qWg3XrINKekb+QJTmjmFSt8237YBTUlKmlGn+fLL64xyjPxPouKOd537bUe 0v5Rxb2fMAtXhUz2987XUVbtyPvsxlAPs1bf5FInL0bgg7Aw3ObcI204ac9JE4yb7S31 pvWvI504NX4TykDa/yebR+52C6ev40tca0mW7VJMEM0Kl2/CFfcKuRFtMEtowbu5SQkp HkpwBmgEqFq6JO9iMMdJiZ1FHvbW/k0dIJ+iAV5fIqec+4epgfPgcmOJP8sho6XN5lVm ZbK9ircoX0GeMgISbFkm5vr9/Wc+z+L5Nv/wyjIDMN1NLrs3f6qkBBrbF1kpOz/Ppfpp e9tg==
X-Gm-Message-State: AOAM530iEVFf98uACZfBntdZU2XpQlXBsSe6NekypbWHJ7EySqWB8CZA PINgZnudhsYA1rOSr7RsNco/xzWJoOYMDhr+W4vErxbNU9U=
X-Google-Smtp-Source: ABdhPJxvMUT2FYvde9kWNigBBYMkBtmjcX6KAgahxWarZkrFqQhSddDSgGe1EdgC6Xg1hQ+PqM/4QQShjwr8H7VY384=
X-Received: by 2002:aca:bed7:: with SMTP id o206mr5052036oif.77.1618806394564; Sun, 18 Apr 2021 21:26:34 -0700 (PDT)
MIME-Version: 1.0
References: <20210417113938.5909CF407D4@rfc-editor.org>
In-Reply-To: <20210417113938.5909CF407D4@rfc-editor.org>
From: Erik Kline <ek.ietf@gmail.com>
Date: Sun, 18 Apr 2021 21:26:23 -0700
Message-ID: <CAMGpriXz_zFgUwg2i9eYwwrMYyeurMz8ST93JcnA=fD=YeiXGQ@mail.gmail.com>
To: NTP WG <ntp@ietf.org>
Cc: "Eric Vyncke (evyncke)" <evyncke@cisco.com>, Dieter Sibold <dsibold.ietf@gmail.com>, "Karen O'Donoghue" <odonoghue@isoc.org>, isomer@gmail.com
Content-Type: multipart/alternative; boundary="0000000000001bb54405c04bbc48"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/uTjkedPbiYtmf43nSNYOBzdFb14>
Subject: Re: [Ntp] [Technical Errata Reported] RFC5905 (6550)
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2021 04:26:41 -0000

All,

Any objection to me marking this as "verified" (or, since it's in appendix
code, an argument for "held for document update" might be made, I suppose).

Thanks,
-ek

On Sat, Apr 17, 2021 at 4:39 AM RFC Errata System <rfc-editor@rfc-editor.org>
wrote:

> The following errata report has been submitted for RFC5905,
> "Network Time Protocol Version 4: Protocol and Algorithms Specification".
>
> --------------------------------------
> You may review the report below and at:
> https://www.rfc-editor.org/errata/eid6550
>
> --------------------------------------
> Type: Technical
> Reported by: Perry Lorier <isomer@gmail.com>
>
> Section: A.5.2
>
> Original Text
> -------------
>         for (i = 0; i < NSTAGE; i++) {
>                 p->disp += f[i].disp / (2 ^ (i + 1));
>                 p->jitter += SQUARE(f[i].offset - f[0].offset);
>         }
>
> Corrected Text
> --------------
>         for (i = 0; i < NSTAGE; i++) {
>                 p->disp += f[i].disp / (1 << (i + 1));
>                 p->jitter += SQUARE(f[i].offset - f[0].offset);
>         }
>
> Notes
> -----
> ^ is the xor operator in C, not the exponent operator.  2 xor (i+1) will
> be zero when i == 1, causing a division by zero error.
>
> Instructions:
> -------------
> This erratum is currently posted as "Reported". If necessary, please
> use "Reply All" to discuss whether it should be verified or
> rejected. When a decision is reached, the verifying party
> can log in to change the status and edit the report, if necessary.
>
> --------------------------------------
> RFC5905 (draft-ietf-ntp-ntpv4-proto-13)
> --------------------------------------
> Title               : Network Time Protocol Version 4: Protocol and
> Algorithms Specification
> Publication Date    : June 2010
> Author(s)           : D. Mills, J. Martin, Ed., J. Burbank, W. Kasch
> Category            : PROPOSED STANDARD
> Source              : Network Time Protocol
> Area                : Internet
> Stream              : IETF
> Verifying Party     : IESG
>