Re: [nwcrg] IRSG review of draft-irtf-nwcrg-bats-03

Shenghao Yang <shenghao.yang@gmail.com> Tue, 06 December 2022 16:25 UTC

Return-Path: <shenghao.yang@gmail.com>
X-Original-To: nwcrg@ietfa.amsl.com
Delivered-To: nwcrg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BDAE3C14F727; Tue, 6 Dec 2022 08:25:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.094
X-Spam-Level:
X-Spam-Status: No, score=-7.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EBcVfIgt7ylB; Tue, 6 Dec 2022 08:25:31 -0800 (PST)
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E2797C14F606; Tue, 6 Dec 2022 08:25:30 -0800 (PST)
Received: by mail-ed1-x536.google.com with SMTP id v8so21046190edi.3; Tue, 06 Dec 2022 08:25:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=egbIyNjN+N13LNLjCIUqFlDpHetp9DdBF9nBpq/mfg8=; b=KTVZrv0PXscYBKBZe4vLz1rALtu4DKrNH/xQ9d66nsNe83vOPWCdQmxv31ciXhYMnU aZkevOyqh4mhAA1wrGVMt8WlLxEcRjbrY647ntD0WiBQoYj+2/Uo8RO5puYFrQeTEpWI 3GmDHoX0OHDsB0DTyoCJ2lI1ewA7LW1Lodvjeq9ZdqsejSzsQEYlooyo3wsftdh40sYG 97DNMSo3zceysO4Pdd98R2Z2+BAveyyYdMIv80A9h0WCv2d8+1D9sCDqgvTDIJhsQIDP k8HShQifS1JIxPQ+q8PYY349iHl44WGkoOuNiB4wlCxma9bkcGeGMgvjEbcK9AbizjP8 2vkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=egbIyNjN+N13LNLjCIUqFlDpHetp9DdBF9nBpq/mfg8=; b=C6ipH37F+pcOE42/rkeV0iAl159ANNIXsMg11m5U+RtnrPAVJdZqW4qAhXpN4ayNiJ SY1fTTuGFc4U1hAg9qWJt6vYvQaDlA4GhPqNyGQQem0Egjt1gQ91Z4mqMjJuvUm4uItT GGxr1CrqfTVZEz+kiIXGLZ0Xcmno0XhhYV2P9KYp3mQwW477sJCBp3vWhayQdTuaRdsA xZ21zkgggCNdbo6vdmDpHEE1qD7mhXiMGkpe54I8oWP9HVMyU5d9L8bB/e2hieZsaYgI QBr801wuCg4anxnZBkIIxfsptAwDPxW/fVU+hekjv+AJlRl3Z4M54dCYxuE45lg7ZaGx hG2A==
X-Gm-Message-State: ANoB5plUTUMW3UnnF8ECT1TIRRpSgqE3G4aTuLTyiRIVoLSxRs95WscG LOmHdk1bSowLkmHwgmwOMj1zCp0Dcn3DKQEWVTw=
X-Google-Smtp-Source: AA0mqf4FFzvBjkkqJVaFbfyp2Z1eexSeF/f8zgEkeenbfVw7YWL3X87MbNmIiTtNua3o5vquSeiE2B4X5bI1SbSFVTo=
X-Received: by 2002:aa7:dd45:0:b0:45a:3c66:b0e4 with SMTP id o5-20020aa7dd45000000b0045a3c66b0e4mr79556686edw.33.1670343928970; Tue, 06 Dec 2022 08:25:28 -0800 (PST)
MIME-Version: 1.0
References: <AEB59B2F-5D77-49C3-8A4F-265C19DD5502@csperkins.org> <5778CB87-DF64-47E0-88A2-3C8E423C643E@orandom.net> <2550D87D-FDB5-47E1-80EF-222933DE1752@csperkins.org> <1209B42F-9115-4796-9160-716D2D4EE23A@orandom.net> <610D2FA6-CFDD-4098-8DC0-25545F6D2A12@gmail.com> <E0B5D17C-07F6-404F-B10E-09ECEABDD662@orandom.net> <AF9F9B8E-AAD3-42CF-866D-5F41B0C4E034@csperkins.org>
In-Reply-To: <AF9F9B8E-AAD3-42CF-866D-5F41B0C4E034@csperkins.org>
From: Shenghao Yang <shenghao.yang@gmail.com>
Date: Wed, 07 Dec 2022 00:24:41 +0800
Message-ID: <CAMGveSXCPdnsVBf=T8a6M957DfGgmfbHyLZCMyzSZzBBQqvA+A@mail.gmail.com>
To: Colin Perkins <csp@csperkins.org>, "David R. Oran" <daveoran@orandom.net>, Vincent Roca <vincent.roca@inria.fr>
Cc: The IRSG <irsg@irtf.org>, Nwcrg <nwcrg@irtf.org>
Content-Type: multipart/alternative; boundary="00000000000089ff8405ef2b405c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/nwcrg/vOmVXuWZcz9VqnW8a-OKBAepe6o>
Subject: Re: [nwcrg] IRSG review of draft-irtf-nwcrg-bats-03
X-BeenThere: nwcrg@irtf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IRTF Network Coding Research Group discussion list <nwcrg.irtf.org>
List-Unsubscribe: <https://www.irtf.org/mailman/options/nwcrg>, <mailto:nwcrg-request@irtf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nwcrg/>
List-Post: <mailto:nwcrg@irtf.org>
List-Help: <mailto:nwcrg-request@irtf.org?subject=help>
List-Subscribe: <https://www.irtf.org/mailman/listinfo/nwcrg>, <mailto:nwcrg-request@irtf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Dec 2022 16:25:34 -0000

Dear Colin, David and Vincent,

Thank you for your quick comments. An update is submitted.
https://datatracker.ietf.org/doc/draft-irtf-nwcrg-bats/06/

We are happy to cite RFC 9265, which is very relevant.

2^(d-M)T>=2^T is changed to 2^(-(d-M)T)<=2^(-T)


Shenghao


On Tue, Dec 6, 2022 at 4:01 AM Colin Perkins <csp@csperkins.org> wrote:

> Thank you to Shenghao and the authors for the update, and to Dave and
> Vincent for the speedy response.
>
> It seems the changes address the major review comments, but there are a
> few minor issue remaining. If it’s possible to issue an update to address
> those, we can then move this draft forward.
>
> Regards,
> Colin
>
>
>
> On 5 Dec 2022, at 16:00, David R. Oran wrote:
>
> I looked over -04 and my comments have been addressed. Thank you! While I
> didn’t do a detailed re-read (looking mostly at the sections I had
> commented on) I did notice a few typos that should be fixed:
>
> in 4.2, s/packets of a batche on the same path/packets of a batch on the
> same path/
> in 6.2, s/reduancy/redundant/
>
> Also, I saw the good comments in an email from Vincent, which should get
> covered in a revision.
>
> I’m happy for this to advance past IRSG review as soon as you can issue a
> further update.
>
> Many Thanks,
> DaveO.
>
> On 3 Dec 2022, at 12:29, Shenghao Yang wrote:
>
> Dear David,
>
> We just submitted a revised version based on comments.
> https://datatracker.ietf.org/doc/draft-irtf-nwcrg-bats/04/
>
> See the point-to-point response below. The security related issues took us
> some time to revise.
>
>
> Best,
>
> Shenghao
>
> On Jun 22, 2022, at 21:43, David R. Oran <daveoran@orandom.net> wrote:
>
> I reviewed draft-irtf-nwcrg-bats-03 as designated reviewer for the IRSG.
> The document is in very good shape and the technical content sound. I have
> just a few minor comments and some grammar/typographic nits for the authors
> to consider prior to publication.
> Minor Comments
>
>    -
>
>    In the introduction (paragraph 2), you should mention more than just
>    interference as something that makes a wireless channel unreliable. There’s
>    also fading, multipath, etc.
>
>
> We mentioned fading and multiparty in the revision.
>
>
>    -
>
>    Discussion of multipath doesn’t show up until quite far along in the
>    document, and in a few places the wording seems to restrict operation to a
>    single receiver. There is in fact good discussion of multicast in the
>    research questions section, so I suggest just a brief mention in the
>    introduction that BATs is intended to work well in both unicast and
>    multicast environments, possibly with a forward reference to the later
>    discussion.
>
>
> Multicast is mentioned in the introduction with referring to Sec 4.
>
>
>    - On p7, the way the requirements on coded packets are laid out is bit
>    difficult to follow. I suggest starting each set with something like a
>    description list, with who the requirement applies to as the lead-in, for
>    example:
>    -
>
>    *Encoder* - the encoder DDP must deliver each coded packet with for
>    following:
>    - BID: batch ID
>
>    *Recoder* - The DDP MUST deliver the following information to each
>    recorder:
>    - M: batch size
>       - q: recoding field size
>
>    *Decoder* - The DDP MUST deliver the following information to each
>    decoder:
>    - M: batch size
>       - q: recoding field size
>       - K: the number of source packets
>       - T: the number of Octets in a source packet
>       - DD: the degree of distribution
>
> The presentation style of this part is revised.
>
>
>    -
>
>    p9, beginning of section 2.2.4 says “A destination node needs the data
>    transmitted by the source node”. Well, sure, but are you trying to say
>    something beyond the obvious here? If so, it isn’t coming through.
>
> This paragraph is rewritten.
>
>
>    -
>
>    In the various field descriptions and the equations, you use the
>    letter “O” for “octets”. This slowed me down a bit as I had to think each
>    time that you didn’t mean zero (“0”), despite the fact that the glyphs are
>    in fact distinguishable in all three target renderings. It might be a pain
>    to fix all of these, but I do think a better choice would either be “T”
>    (which you use in the example above as a parameter for the decoder), or a
>    two-letter variable name like “OC”.
>
>
> O is changed to CO (the first two letters of coefficient).
>
>
>    -
>
>    On p12 you say “A common primitive polynomial should be specified for
>    all the finite field multiplications over GF(256). Is this actually a MUST
>    for the operation of the code?
>
> “Should” is changed to “MUST"
>
>
>    -
>
>    In the discussion of routing issues, on p18, you talk about the
>    possibility of different batches being sent on different paths to achieve
>    multipath gain. Is there a reason why batches can’t be similarly split and
>    sent over different paths? If not, why not?
>
> We add the discussion about whether to transmit the packets of a batch on
> the same path or different paths for unicast and multicast.
>
>
>    -
>
>    Section 4.3 is titled “Application-related issues”, however most
>    (perhaps all?) of the discussion isn’t actually about applications but
>    about usage and deployment scenarios over different kinds of network
>    technologies and topologies. Suggest renaming this “Usage Scenario
>    Considerations” or something similar and if there are in fact application
>    issues (e.g. multimedia, IoT, etc.) split those out in a separate section.
>
> The section title is changed to “Usage Scenario Considerations”.
>
>
>    -
>
>    In section 6 on security considerations you address eavesdropping
>    well, but don’t talk at all about traffic analysis. Are there interesting
>    factors in BATs affecting the ability of traffic analysis to figure out
>    what is happening with the application data flows, e.g. does BATs produce
>    detectable timing or padding behavior that can be leveraged better than
>    non-coded data, or perhaps conversely make things harder for an adversary?
>
> A new subsection is added to discuss traffic analysis. See 6.2.
>
>
>    -
>
>    The discussion of attestation in section 6.2 left me feeling a bit
>    un-satisfied, given that the protocol doesn’t actually provide provenance
>    (i.e. the attestation of the chain of coders/recoders does not seem
>    explicitly bound into the data streams). Simple origin authentication (e.g.
>    using signatures) doesn’t seem to be adequate. Am I missing something here?
>
> The pollution attack part is rewritten. See 6.3.
>
> Nits
>
>    -
>
>    p7, s/DD[i] is the possibility/DD[i] is the probability/
>    -
>
>    p12, s/addition is an logical XOR/addition is a logical XOR/
>    -
>
>    p17, s/increasing too much end-to-end latency/increasing end-to-end
>    latency too much/
>    -
>
>    p17, s/achieves the mulicast/achieves the multicast/
>
> [End of review]
> _______________________________________________
> nwcrg mailing list
> nwcrg@irtf.org
> https://www.irtf.org/mailman/listinfo/nwcrg
>
>
> _______________________________________________
> nwcrg mailing list
> nwcrg@irtf.org
> https://www.irtf.org/mailman/listinfo/nwcrg
>
> DaveO
>
> _______________________________________________
> nwcrg mailing list
> nwcrg@irtf.org
> https://www.irtf.org/mailman/listinfo/nwcrg
>
>